Commit Graph

428130 Commits

Author SHA1 Message Date
Louis Vignier
c431475c6e [codeInspection.ui] Don't register custom inspection actions in ActionManager
#IDEA-340285 Fixed

GitOrigin-RevId: ff5089a6f5200963dbe447f58618f72753f710ec
2023-12-18 23:19:52 +00:00
Ilya Kirillov
d8c0a84a53 [kotlin] unmute passing K2UnusedSymbolHighlightingTestGenerated.Uncategorized.testJsExport test
GitOrigin-RevId: d1166dd6bb13aba98de057aa8311b15f4bfb6339
2023-12-18 22:54:22 +00:00
Ilya Kirillov
e31ac5609b [kotlin] Nls SpecifySuperTypeFixFactory
We can show rendered types for user without localization

GitOrigin-RevId: d58884c613884e3845451b2ff2587227677edf2c
2023-12-18 22:54:19 +00:00
Evgenii Zakharchenko
14b0395fbc [ultimate] IDEA-338573 Extract Reverse engineering plugin from JPA Buddy plugin
rollback acton update thread for DeleteAction

GitOrigin-RevId: 2f2e6fd5a3a91723b47f93193538c5d364656894
2023-12-18 22:38:06 +00:00
Dmitry Avdeev
02fb3c48c8 using UserDataHolder instead of fields to store cashed values
GitOrigin-RevId: f87e60a316ca7d18717c2f56e9257ff89635285f
2023-12-18 22:36:47 +00:00
Dmitry Kichinsky
9b8bd48a49 [maven] IDEA-341251 test code formatted
GitOrigin-RevId: 27d339b7d57ab3e3d680e4f479d1f3e25f041842
2023-12-18 21:50:40 +00:00
Dmitry Kichinsky
62f73e2c20 [maven] IDEA-341251 MavenDuplicateDependenciesInspection logging
GitOrigin-RevId: 0f755a8f4c51d482eefba579c5f87af193ec1ed8
2023-12-18 21:50:37 +00:00
Dmitry Kichinsky
486cde2af8 [maven] IDEA-341251 convert MavenDuplicateDependenciesInspection to kotlin
GitOrigin-RevId: c47d95b96ef7b918169aa7c51b882167ce4ad306
2023-12-18 21:50:33 +00:00
Dmitry Kichinsky
f30925b029 Rename .java to .kt
IDEA-341251

GitOrigin-RevId: 0f03a3654f38f5aa77896aac450d1888e8cb79e3
2023-12-18 21:50:29 +00:00
Ruslan Cheremin
6b1ae04f3e [vfs] EA-984945: safely close mapped storage in PersistentFSRecordsLockFreeOverMMappedFile ctor on failpath
GitOrigin-RevId: bc9727238c20b1473e38e7fe805aa2e26b85e602
2023-12-18 21:39:04 +00:00
Ruslan Cheremin
e338ceeb70 [cleanup] TODOs, comments, imports cleanup
GitOrigin-RevId: 799e758bd3dc2de680585c94de343f1d6ef02e2d
2023-12-18 21:39:04 +00:00
Georgii Ustinov
286bf8bddf Migrate RemoveDecoratorQuickFix and RemoveTrailingSemicolonQuickFix to ModCommand
PY-65297

GitOrigin-RevId: 8b76c57a5224e18d9cf6f12f62862ecc6d7b03ed
2023-12-18 21:24:23 +00:00
Georgii Ustinov
e69a429eb3 Migrate PyUpdatePropertySignatureQuickFix and RedundantParenthesesQuickFix to ModCommand
PY-65297

GitOrigin-RevId: c8c81e09ff6459f385437da50acc481afcd991ae
2023-12-18 21:24:19 +00:00
Georgii Ustinov
530b79d991 Migrate all QuickFixes in PyTypeHintsInspection
PY-65297

GitOrigin-RevId: e71c1074779ea706511fff07db0053f1335f6cc4
2023-12-18 21:24:16 +00:00
Georgii Ustinov
4d1b5b0bd0 Migrate AddFixtureToFuncParametersQuickFix and PyUnpackTypeVarTupleQuickFix to ModCommand
PY-65297

GitOrigin-RevId: 2695f20eb27475245fb48a93c5ee874041e54463
2023-12-18 21:24:12 +00:00
Mikhail Pyltsin
abed593937 [java-refactoring] IDEA-340785 Unable to rename file with implicit class
- add verifications for names

GitOrigin-RevId: 80d526e9a4f20d58875f59d81fd4c87f0c3cccd7
2023-12-18 20:57:27 +00:00
Mikhail Pyltsin
b1f90d405a [java-inspection] EA-941439 incorrect behavior for Java8MapApiInspection when a map is reused
GitOrigin-RevId: 0ac91b181c4dc245fa839ee3ccb2b0ba501c90bd
2023-12-18 20:57:23 +00:00
Mikhail Pyltsin
c402552b77 [java-inspection] EA-974827 incorrect behavior for EnhancedSwitchMigration when a variable is outside switch scope
GitOrigin-RevId: 5c88546b27597aba2b75141eb49439eb1a779dc8
2023-12-18 20:57:19 +00:00
Mikhail Pyltsin
4d18cc897e [java-highlighting] IDEA-340063 Don't offer import from implicitly declared classes
- fix incorrect return for a case: implicit class and non-implicit-class

GitOrigin-RevId: 690c9c8df180fcb814a4c4a342f46fcbbb921ebb
2023-12-18 20:57:15 +00:00
Semyon Kolton
ea6ba429f3 EA-928810 Do not assert on null
GitOrigin-RevId: 4cfeeba9d1c867e58135c20ad4c283afda99c570
2023-12-18 20:49:00 +00:00
Anna Kozlova
5acd6c99b9 [kotlin] k2: create from usage: fix testdata
GitOrigin-RevId: e82799f0e43ac0b876b170ae314f830c6827a558
2023-12-18 20:43:58 +00:00
Anna Kozlova
4249cec5ea [kotlin] k2: create from usage: don't cache KtType between sessions
part of KTIJ-27215

GitOrigin-RevId: 9ba61120eb53147896c96a21fc6067693c102685
2023-12-18 20:43:53 +00:00
Jaebaek Seo
c805951d9d K2 create-from-usage: Support KT2J
This commit creates Java method from the unresolved usage in Kotlin.

GitOrigin-RevId: 24f87b4bc53c338d04d32e213987c2c368064c34
2023-12-18 20:43:49 +00:00
Jaebaek Seo
9f38786686 K2 create-from-usage: Support Java-to-KT
This commit adds creating KT function from usage in Java.

GitOrigin-RevId: c78e97fe0151304a8081746e01008868c6b693a3
2023-12-18 20:43:45 +00:00
Jaebaek Seo
0d778e2a75 K2 create-from-usage: Avoid unnecessary KT to LC/PsiType conversion
The creation of Kotlin functions from Kotlin usage does not need LC and
PsiType because both sides use KtClass and KtType. To avoid the
unnecessary conversion between KtClass and LC and conversion between
KtType and PsiType, this commits adds wrapper classes for KtClass and
KtType that are child classes of JvmClass and JvmType. See
JvmClassWrapperForKtClass and JvmTypeWrapperForKtType.

GitOrigin-RevId: 13b67b3573d8acef98d41aa9681cfb3070767893
2023-12-18 20:43:41 +00:00
Jaebaek Seo
3da347b279 K2 create-from-usage: Support template for parameters and return type
Based on the template, this commit support the selection of parameter
names, parameter types, and return type. Now K2 create-from-usage for
functions has the same behaviors as K1 for "abstract" call test cases.
It was also tested in an instance of IJ as well.
Now the minimal K2 create-function-from-usage works:
Correct action messages for quick-fixes -> working
[WIP] Function creation
Container selection to inserts created functions -> working
Capturing parameter types information -> working
Parameter name selection -> working
Capturing return type information -> working
Rendering types -> working
Template -> working
Shortening reference -> working
Moving caret after inserting created function -> working
[TODO] Handling type parameter

GitOrigin-RevId: a41b54ec0d44607c0371ddeb2c85eca2948e01b6
2023-12-18 20:43:37 +00:00
Jaebaek Seo
8f97ab8cfb K2 create-from-usage: fix wrong '!' in type rendering
If we use KtTypeRendererForSource.WITH_QUALIFIED_NAMES for
KtType.render(..), it will render kotlin.String! for
kotlin.String, which causes a syntax error when we use it in
create-from-usage. This commit defines a new instance of
KtTypeRendererForSource to fix this issue.

GitOrigin-RevId: db9cc930eea8e500e95dba1fcaba755d8caa51a6
2023-12-18 20:43:32 +00:00
Jaebaek Seo
60f0505e7a K2: implement create-Kotlin-callable-from-usage-in-Kotlin
We have a powerful architecture that supports cross-language for
create-from-usage like creating Java elements from usage in Java and
Groovy. They share the same CreateMethodAction based on
CreateMethodRequest. When we want to add a create-Java-element
quickfix from a language, we can simply implement a request class that
is a child of CreateMethodRequest.
Likewise, we already have a skeleton classes to support the same
cross-language feature for create-Kotlin-element from usage, which is
CreateKotlinCallableAction. It creates Kotlin callable based on a given
request.
This commit implements K2 create-from-usage (previously, we had
CreateCallableFromCallActionFactory and CreateCallableFromUsageFix)
based on CreateKotlinCallableAction and request. Currently,
Correct action messages for quick-fixes -> working
[WIP] Function creation
Container selection to inserts created functions -> working
Capturing parameter types information -> working
Parameter name selection -> working
Capturing return type information -> working
[WIP] Rendering types
[TODO] Template
[TODO] Shortening reference
[TODO] Handling type parameter
[TODO] Moving caret after inserting created function

GitOrigin-RevId: 27ccc20dcc62acec889d978552f1a4c0e4b8423c
2023-12-18 20:43:28 +00:00
Jaebaek Seo
302795be62 K2: Rename "Method" to "KotlinFunction" for create-from-usage
This commit refactors class names for K2 create-from-usage from "Method"
to "KotlinFunction" because they handle Kotlin code rather than Java
methods.

GitOrigin-RevId: 8ec9e673ada8fe855494740ea92b6dcf3965a9c2
2023-12-18 20:43:24 +00:00
Anna Kozlova
44553bde15 [kotlin] k2: prepare pure move kotlin file from project view
better wording to explain the purpose of new extension
KTIJ-28234

GitOrigin-RevId: aba439f2f828349a2474cebfb10d52923df6df00
2023-12-18 20:43:20 +00:00
Anna Kozlova
f0a66c4beb [kotlin] k2: change signature: use PsiElement context to retrieve analysis session by module
otherwise, if session is build by the element itself and element is located in library, symbol origin would not be as expected LIBRARY but SOURCES

^KTIJ-28216 fixed
^KTIJ-28176 fixed

GitOrigin-RevId: 2a613e8d78a6c57e70fd42c7bf313186b7778fb6
2023-12-18 20:43:16 +00:00
Anna Kozlova
233bfc6038 [kotlin] k2: setup default parameter in UI
^KTIJ-28058 fixed

GitOrigin-RevId: 00036e80b507f527493304c20a4ae1b7c89a0294
2023-12-18 20:43:12 +00:00
Yuriy Artamonov
59fb01fa9e [testing] Make screenshots core capability of Driver to not have circular dependency in design
GitOrigin-RevId: f1f92ddfb7865ccff1fbeecb7717b2b015fed99f
2023-12-18 20:35:43 +00:00
Dmitry Pogrebnoy
f0b51f45f4 [Feedback] IDEA-335722 Cosmetics. Feedback form for plugins
GitOrigin-RevId: 5bfbf4c69ec93eff0deb98bfec9c13751a2b5f57
2023-12-18 20:31:06 +00:00
Andrey Cherkasov
6e95446bec [java] The 'Make class final' quick-fix must check final methods
...and remove their 'final' modifier. Since final classes cannot be inherited, marking a method as final is unnecessary and confusing.

^IDEA-309065

GitOrigin-RevId: de044d57c690772aefc7044d87159c42ebc92907
2023-12-18 20:25:02 +00:00
Kirill Likhodedov
cc6dbbc94e fix compilation
GitOrigin-RevId: 25bb0ac92e86b52c7a81962517b62ee5e6ffc4f1
2023-12-18 19:57:41 +00:00
Konstantin Hudyakov
1997641071 [terminal] IDEA-338899 Fix starting the Zsh in new terminal with p10k installed
GitOrigin-RevId: 048e1deb786864b4a744f1c03945be540279e56e
2023-12-18 19:39:24 +00:00
Maksim Zuev
4eb9436f30 [coverage] Refactor data file path creation
GitOrigin-RevId: 550e02318d79af05820036882ff9c4699de064b0
2023-12-18 19:33:12 +00:00
Maksim Zuev
1caf04687e [coverage] IDEA-340863 Refactor CoverageEnabledConfiguration
GitOrigin-RevId: f48a62e7f2873d067232b7a9d4dafd4ba5c7345e
2023-12-18 19:33:10 +00:00
Maksim Zuev
ae2cdd2555 [coverage] Refactor CoverageEngine.java: introduce default implementations
Most of the implementations (except for Java) had to introduce default methods that are actually not used

Deprecate unused methods

GitOrigin-RevId: 6019cb0da09a6bc1d28d05a5222736573e7c747b
2023-12-18 19:33:09 +00:00
Maksim Zuev
0592e0ca91 [coverage] Clean up properties file
GitOrigin-RevId: 7218c0c1887d1177bde96b9510f75f1c4c2d7c48
2023-12-18 19:33:07 +00:00
Maksim Zuev
b86edd8dd7 [coverage] Clean up CoverageConfigurable
GitOrigin-RevId: e922aa7eeda1e0820d3fb15b43a3ee97429ae1c6
2023-12-18 19:33:05 +00:00
Maksim Zuev
03906b7a26 [coverage] Fix CoverageSuitesTest
GitOrigin-RevId: c8b17e3affcc2b78e5c3363b4e5aa565bd665d95
2023-12-18 19:33:04 +00:00
Sergei Vorobyov
bce369891f [Core|TestFramework] fix: use actual value wrapper for getActualStringPresentation method
GitOrigin-RevId: 05b82dcf345417e9f71aecd460888a4004ca6b5b
2023-12-18 19:22:20 +00:00
Sergei Vorobyov
da28ba9d42 IDEA-341258 [Core|TestFramework] workaround: don't use new methods for FileComparisonFailure
Idea class loader in tests leaks for FileComparisonFailure. It takes FileComparisonFailure from IDE's local installation instead of test module dependency.

GitOrigin-RevId: 94d4867f5a169f1079482844bcaf67440ffa167d
2023-12-18 19:22:16 +00:00
Aydar Mukhametzyanov
2814a38cce IDEA-337121 Directory bookmark cannot be deleted
GitOrigin-RevId: 237e6c9001c60d185968ebaa13501e5362477713
2023-12-18 19:15:06 +00:00
Aydar Mukhametzyanov
3b5ee2cfba IDEA-306579 Welcome screen: fix removing and move to window initiated from a popup
GitOrigin-RevId: 94cd9ddba07fb8ffa861c7da526939598197ad01
2023-12-18 19:15:02 +00:00
Maxim.Kolmakov
49632565f9 Add new test on AI Login using browser and creating a user on staging
GitOrigin-RevId: 98f80d184101ac22e62dc63f451644a272a2713d
2023-12-18 18:59:22 +00:00
Aleksey Pivovarov
21fb15cd4d IDEA-336983 vcs: fix initial scroll position in Commit Dialog
GitOrigin-RevId: 9dcb6b4901f18d61316dfbe1cd8727fb2e442c58
2023-12-18 18:57:18 +00:00
Aleksey Pivovarov
af4628d757 IDEA-336983 vcs: fix initial selection in Commit Dialog
Reset initial tree state until after the 'SingleChangeListCommitWorkflowHandler.activate' is called,
as up-to-date inclusion is used to compute initial selection.

Follow-up: 20b8582f9186083c6b4470d7b85b5aa0eba2557a
           4b2df3f6754161cb35289a3f483b19c9056aa780

GitOrigin-RevId: 804419b8f32673c5f94e09271bf7f3891ea44abf
2023-12-18 18:57:18 +00:00