MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

IDEA-341258 [Core|TestFramework] workaround: don't use new methods for FileComparisonFailure

Browse Source 
Idea class loader in tests leaks for FileComparisonFailure. It takes FileComparisonFailure from IDE's local installation instead of test module dependency.

GitOrigin-RevId: 94d4867f5a169f1079482844bcaf67440ffa167d
This commit is contained in:
Sergei Vorobyov
2023-12-18 19:22:16 +00:00
committed by intellij-monorepo-bot
parent 2814a38cce
commit da28ba9d42
2 changed files with 1 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
java/java-runtime/src/com/intellij/rt/execution/junit/FileComparisonFailure.java
-4
View File
@@ -16,10 +16,6 @@ public class FileComparisonFailure extends ComparisonFailure implements FileComp
private final String myFilePath;
private final String myActualFilePath;
public FileComparisonFailure(String message, /*@NotNull */String expected, /*@NotNull */String actual) {
this(message, expected, actual, null, null);
}
public FileComparisonFailure(String message, /*@NotNull */String expected, /*@NotNull */String actual, String expectedFilePath) {
this(message, expected, actual, expectedFilePath, null);
}
platform/testFramework/src/com/intellij/testFramework/fixtures/impl/CodeInsightTestFixtureImpl.java
+1 -1
View File
@@ -1852,7 +1852,7 @@ public class CodeInsightTestFixtureImpl extends BaseFixture implements CodeInsig
if (!Objects.equals(expectedText, actualText)) {
if (loader.filePath == null) {
throw new FileComparisonFailure(expectedFile, expectedText, actualText);
throw new FileComparisonFailure(expectedFile, expectedText, actualText, null);
}
if (loader.caretState.hasExplicitCaret()) {