Commit Graph

4317 Commits

Author SHA1 Message Date
Anna Kozlova
b5ae17aeda testdata for IDEA-250434
GitOrigin-RevId: 2971531084debcf848f19d970f9beec9b9f702ae
2021-01-21 21:46:43 +00:00
Anna Kozlova
0efd80e15f unchecked warning: keep warning for all generic class types (IDEA-259694)
ignore if target type was raw, found by integration test

GitOrigin-RevId: eee1c2d03c94d25f25a9e709c1f6e776383b3401
2021-01-21 11:35:07 +00:00
Artemiy Sartakov
410e209f2d Sealed classes: fixed infinite recursion test (IJ-CR-5083)
GitOrigin-RevId: d6309295c2f77766fb22335c6aa1d65467a80fdc
2021-01-19 09:22:12 +00:00
Artemiy Sartakov
45d71a0820 Sealed classes: restricted keyword/identifier -> contextual keyword (IDEA-257414)
GitOrigin-RevId: a3b7cb3c6eb3a65f78cf473fb93ddfa9946dea38
2021-01-19 09:22:09 +00:00
Tagir Valeev
78652c8573 [java-inspections] RemoveInitializerFix: do not remove complete assignment when used
GitOrigin-RevId: 94dff2a177b1cc991c330276d093f5d3f652d6b9
2021-01-19 09:03:15 +00:00
Artemiy Sartakov
108183e621 Sealed classes: prevent infinite recursion (IJ-CR-5083)
GitOrigin-RevId: 162a2b3851a4303e48d99fcf41d319bdda6f84de
2021-01-19 04:28:47 +00:00
Anna Kozlova
ad18c7f009 java inference: setup initial constraints with respect of unchecked warning rules (IDEA-259701)
GitOrigin-RevId: e922b0cdfdecf6dfc3a50a334aa21e084aa1dd97
2021-01-18 14:29:55 +00:00
Anna Kozlova
d8b0b80a26 unchecked warning: keep warning for all generic class types (IDEA-259694)
GitOrigin-RevId: b5a09baadfb6837a9de679b2577732faaa05bcdb
2021-01-18 14:29:52 +00:00
Anna Kozlova
0a73a79b70 diamonds: fix parent hunting inside anonymous class (IDEA-259666)
GitOrigin-RevId: 51f47646dbe68e9182b75e3058b0d1216ada92e6
2021-01-18 10:18:03 +00:00
Anna Kozlova
51adbd8f32 introduce variable: ensure array initializer is wrapped in new expr for var usage (IDEA-259249)
GitOrigin-RevId: 910d524ec157012a46aa8586c200f1a1b310c38c
2021-01-15 11:54:05 +00:00
Vladimir Krivosheev
912da5a7e8 reduce trove lib usages
GitOrigin-RevId: da64d033d2fff69893958d9f8a652370c1a1212f
2021-01-14 16:56:35 +00:00
Nikita Eshkeev
c40da789be [PreviewFeature] IDEA-259284 Support the new PreviewFeature annotation's package
This patch encapsulates the logic that checks if a used feature is annotated with PreviewFeature in its own visitor. The visitor now checks both PreviewFeature annotations with old and new packages.

GitOrigin-RevId: f3ddc2a840b8c3a8bb4e1a731e2c208002a29fd4
2021-01-13 20:54:42 +00:00
Artemiy Sartakov
e35b38f161 Sealed classes: report narrow down conversion for sealed classes that have only sealed / final subclasses and don't have interface inheritors in hierarchy (IDEA-257414)
see JEP-397 - Sealed classes and conversions for details

GitOrigin-RevId: 297386ccd61f7762508b630a60894360215d9e11
2021-01-13 04:57:37 +00:00
Anna Kozlova
2005c6f14c java: testdata for IDEA-206570
GitOrigin-RevId: a4019ca264e699210cba91d30c47c266949d7563
2021-01-11 12:44:55 +00:00
Anna Kozlova
0e8e6abfcb java: override default with super call (IDEA-258822, IDEA-259098)
GitOrigin-RevId: 295ac3cb605800b005784674c2bac20f0de951ff
2021-01-11 12:44:53 +00:00
Anna Kozlova
d66d66d259 type annotations: skip type annotation in generated code if it also has normal applicable targets (IDEA-206570)
GitOrigin-RevId: 651526af474d80f2664229f8c000c790152b3f0d
2021-01-11 10:31:05 +00:00
Anna Kozlova
7793b16164 java: replace explicit type with var: disable if TYPE_USE annotated (IDEA-259100)
GitOrigin-RevId: 4096a327d8c8f9f569fd82c2d6684f7f3d2090fe
2021-01-11 10:31:04 +00:00
Alexey Kudravtsev
a2233e727f move test for fix in IJ-CR-4970 away from SuppressLIIJspTest because it has nothing to do with jsp
GitOrigin-RevId: 84111526ca761cc9b4cb468371e4455ef5b0fead
2021-01-07 13:57:00 +00:00
Anna Kozlova
888b1151d6 java: report error if repeatable annotation has Documented/Inherited annotation and its container doesn't (IDEA-256253)
GitOrigin-RevId: d6dab9a587b2e4d7663a5b0c44ecf65bba9113bd
2020-12-30 19:38:19 +00:00
Anna Kozlova
42bb6297bc java create field from usage: don't go polyadic too deep for reference expressions (IDEA-235781)
GitOrigin-RevId: e3b48d82a489fd91917ffb0027f383aa236c425f
2020-12-30 13:08:33 +00:00
Tagir Valeev
b6c02d3fd2 [java-highlighting] StaticInInnerJava16: remove redundant comments
GitOrigin-RevId: 5ac0bb4da8e0d8e62b2143180b719f20a76bc17d
2020-12-30 06:23:52 +00:00
Nikita Eshkeev
0f5a1abe0f [inspection] IDEA-257415 Warnings for value-based classes (Java 16)
This renames ValueBasedWarningsInspection to SynchronizeOnValueBasedClassInspection and alters the logic, it checks first the original type of the monitor and if it's not a value-based class then it employs DFA to infer the type more precisely and checks the inferred type if it differs from the type of the monitor. This solution is more robust, because DFA might fail sometimes.

This patch also adds the suppressId to SynchronizeOnValueBasedClassInspection in order to support the new javac warning category.

Signed-off-by: Nikita Eshkeev <nikita.eshkeev@jetbrains.com>

GitOrigin-RevId: f7c3520b84bf6f9080280dc2689ff4f63ac4be09
2020-12-29 22:41:46 +00:00
Anna Kozlova
454edfca70 java: move javac bug workaround to the suppressable inspection (IDEA-258347)
GitOrigin-RevId: 131d9adc783927a143393a59f98efe2afb414c68
2020-12-28 16:36:13 +00:00
Tagir Valeev
5d20b5dbb9 [java-highlighting] Allow statics inside inner since Java 16 (IDEA-257410)
Also remove redundant record tests

GitOrigin-RevId: ce57189891b3df3ba4659e8e3a2ded125234911a
2020-12-25 11:59:29 +00:00
Nikita Eshkeev
7760811391 [inspection] IDEA-257415 Warnings for value-based classes (Java 16)
This patch adds the inspection to detect usages of value-based classes' instances as monitors in the synchronize statement.

Signed-off-by: Nikita Eshkeev <nikita.eshkeev@jetbrains.com>

GitOrigin-RevId: 178533c1415b2a8f11d48db17c19baa7e6ff4d1a
2020-12-24 02:00:16 +00:00
Artemiy Sartakov
7de400f55b Sealed classes: report permits classes that miss final/sealed/non-sealed modifier at permits list (IDEA-255805)
GitOrigin-RevId: 7d1c2c6d8f40302177b369838238858e44427c51
2020-12-22 10:40:52 +00:00
Anna Kozlova
1c6857ec2d java create class from new: don't create non-static inner if new expression can't be used afterwards (IDEA-97433)
GitOrigin-RevId: 89616c077ca5141db53b624ae08bc54b04d53cae
2020-12-18 19:01:32 +00:00
Anna Kozlova
f535bd830e java create class from usage: setup super ref for created nested class (IDEA-257288)
GitOrigin-RevId: c5a37a119f50aa3468c74ce621108e00e1168852
2020-12-18 19:01:29 +00:00
Anna Kozlova
e9fb32668e overload resolution: don't reject first inapplicable vararg method
GitOrigin-RevId: 3e8246e5cbdab35327da0587aa62111b04f7dbed
2020-12-16 15:32:31 +00:00
Anna Kozlova
7d0ce7b928 overload resolution: N parameters of varargs target should be less than N parameters of corresponding interface (IDEA-257526)
GitOrigin-RevId: 811135c478f3f98fa1923f4b58c27d6ca0144939
2020-12-15 20:45:46 +00:00
Anna Kozlova
fd17a8bb75 language level 16, remove language level 14_preview (IDEA-257409)
GitOrigin-RevId: 1f9626ba04ffd9588b0cf9b8a9f699faa613359b
2020-12-14 20:59:58 +00:00
Roman Ivanov
bbcb50af87 JavaParser: parse yield() as call
GitOrigin-RevId: 31b4b0f9687bbaa6d1df65e459dcbe05e5c2c6b4
2020-12-14 17:25:01 +00:00
Andrey.Cherkasov
99e697f12b IDEA-253512: Fix SlowAbstractSetRemoveAllInspection
GitOrigin-RevId: 4629a9d2c9b72a7e4b9974bf7c4d93dea98fe7fe
2020-12-07 20:34:07 +00:00
Anna Kozlova
6a0c39b3ee java: missed type cast suggestion on annotated types (IDEA-256942)
GitOrigin-RevId: 86dd16b919e602d375267b868c84384eb4e097cd
2020-12-04 21:20:39 +00:00
Tagir Valeev
58a638bab9 [java-tests] Record rename tests moved to RenameFieldTest
GitOrigin-RevId: d6b5c15752a7e821829caf55db968bc67ebffa8d
2020-12-04 08:06:39 +00:00
Tagir Valeev
7c62cd67fe [java-highlighting] IDEA-256804 Highlighting bug when using JDK 15 Records
GitOrigin-RevId: fd7fe3f1bcfe89e65f754038b4021ac003abb9f7
2020-12-04 08:06:37 +00:00
Andrey.Cherkasov
95a12db895 IDEA-253512: Fixes after review
GitOrigin-RevId: 0c9d42259d6a5169c449b536aa4e7b982446b10a
2020-11-30 15:12:44 +00:00
Anna Kozlova
3a646d1f0c java create local from usage: do not duplicate comments inside variable initializer (IDEA-256107)
GitOrigin-RevId: 3f9298e0d38ca0840a57922a7b9eb23c27277668
2020-11-26 12:11:11 +00:00
Andrey.Cherkasov
d4dbc49dab IDEA-253512: Warn about possible O(N^2) in AbstractSet#removeAll calls
GitOrigin-RevId: 76f59d4f019482420142cdf760be3f9e4c7f4d1e
2020-11-25 15:18:45 +00:00
Andrey.Cherkasov
54ac372e2d Add tests for IDEA-173818
GitOrigin-RevId: 6646ccbf3c0ce543fba799d1a1f8ef5786ddc112
2020-11-24 18:20:43 +00:00
Tagir Valeev
d35974faf8 [java-inspections] IDEA-255926 Support streams generated by StreamSupport StreamToLoopInspection
Only for non-parallel streams

GitOrigin-RevId: 08b517f557f0c376cc504ac654a9353a66ae9014
2020-11-24 04:36:33 +00:00
Bas Leijdekkers
4b18db9bfb Add quick fix to remove duplicate annotation without parameters (IDEA-249508)
GitOrigin-RevId: fea7daeb0bb40724325182d6041a20aa141fbbf2
2020-11-23 21:56:24 +00:00
Anna Kozlova
73742cfcaa java records: rename component through implicit reference to the generated getter (IDEA-249683)
GitOrigin-RevId: 61907b128fb812c2b7df3769f2a80cc81ef43e54
2020-11-23 16:35:13 +00:00
Anna Kozlova
b93c815fbf java records: component used in outer class: search/rename fixes (IDEA-248803)
GitOrigin-RevId: 658be1b62e613484e82b1e7f24f1157813021179
2020-11-23 16:35:10 +00:00
Andrey.Cherkasov
1a75f19cff Don't warn about missing tag description on void methods
GitOrigin-RevId: 7125c41e5adfb4a45f96b6f5c9b6db12a9a0da6d
2020-11-23 13:25:11 +00:00
Anna Kozlova
cbff44d84f java diamonds: avoid recursion prevention (IDEA-255486)
GitOrigin-RevId: bb6e3e45899ede6c36278bfd3c74813b1fc64b38
2020-11-16 14:52:30 +00:00
Daniil Ovchinnikov
932ea20745 IDEA-252714 [java] use anchor if request is coming from tree child of target class
GitOrigin-RevId: 8248fb4f61867773b41c5274b52f2e73b3867972
2020-11-12 14:55:22 +00:00
Anna Kozlova
c9c3a31e74 redundant suppression: search for text with suppressId in narrow element if applicable (IDEA-221643)
GitOrigin-RevId: 1b13bcda0f78e882ddd51a0d6eccb4a662a441c4
2020-11-09 17:12:46 +00:00
Bas Leijdekkers
0954a97685 IPP: make intention texts more distinguishable from each other
GitOrigin-RevId: 47d0fe080875ef6f68bac5fa3b2e836c2f5430c0
2020-11-06 13:43:59 +00:00
Anna Kozlova
f8a53347cf java: split declaration & assignment: fix for very broken code (IDEA-254385)
forcePsiPostprocessAndRestoreElement may invalidate variable initializer

GitOrigin-RevId: 31b99804e5603cff36494ecbf9f98c1716b13d22
2020-11-02 20:18:09 +00:00