MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

redundant suppression: search for text with suppressId in narrow element if applicable (IDEA-221643)

Browse Source 
GitOrigin-RevId: 1b13bcda0f78e882ddd51a0d6eccb4a662a441c4
This commit is contained in:
Anna Kozlova
2020-11-09 17:12:46 +00:00
committed by intellij-monorepo-bot
parent ebab15db82
commit c9c3a31e74
3 changed files with 18 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
java/java-analysis-impl/src/com/intellij/codeInspection/SuppressManagerImpl.java
+12
View File
@@ -5,6 +5,8 @@ package com.intellij.codeInspection;
import com.intellij.codeInsight.daemon.HighlightDisplayKey;
import com.intellij.codeInsight.daemon.impl.RemoveSuppressWarningAction;
import com.intellij.openapi.diagnostic.Logger;
import com.intellij.openapi.util.TextRange;
import com.intellij.psi.PsiComment;
import com.intellij.psi.PsiDocCommentOwner;
import com.intellij.psi.PsiElement;
import com.intellij.psi.util.PsiTreeUtil;
@@ -65,6 +67,16 @@ public class SuppressManagerImpl extends SuppressManager implements RedundantSup
return suppressionScope != null && PsiTreeUtil.isAncestor(elementWithSuppression, suppressionScope, false);
}
@Override
public TextRange getHighlightingRange(PsiElement elementWithSuppression, String toolId) {
PsiElement annotationOrTagElement = elementWithSuppression instanceof PsiComment ? null : getElementToolSuppressedIn(elementWithSuppression, toolId);
if (annotationOrTagElement != null) {
int shiftInParent = annotationOrTagElement.getTextRange().getStartOffset() - elementWithSuppression.getTextRange().getStartOffset();
return RedundantSuppressionDetector.super.getHighlightingRange(annotationOrTagElement, toolId).shiftRight(shiftInParent);
}
return RedundantSuppressionDetector.super.getHighlightingRange(elementWithSuppression, toolId);
}
@Override
public LocalQuickFix createRemoveRedundantSuppressionFix(@NotNull String toolId) {
return new RemoveSuppressWarningAction(toolId);
java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/redundantUncheckedVarargs/after5.java
+3
View File
@@ -7,6 +7,9 @@ public class Test {
return null;
}
/**
* Some javadoc with unchecked word inside
*/
void foo() {
List<ArrayList<String>> list = foo(new ArrayList<String>());
}
java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/redundantUncheckedVarargs/before5.java
+3
View File
@@ -7,6 +7,9 @@ public class Test {
return null;
}
/**
* Some javadoc with unchecked word inside
*/
@SuppressWarnings("unch<caret>ecked")
void foo() {
List<ArrayList<String>> list = foo(new ArrayList<String>());