java: split declaration & assignment: fix for very broken code (IDEA-254385)

forcePsiPostprocessAndRestoreElement may invalidate variable initializer

GitOrigin-RevId: 31b99804e5603cff36494ecbf9f98c1716b13d22

java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/splitDeclaration/afterBroken.java

@@ -0,0 +1,11 @@
+// "Split into declaration and assignment" "true"
+
+class Foo {
+  {
+    int fieldIndexes;
+      fieldIndexes = getFieldIndexes(Hellonew String[;]{""});
+  }
+  public int getFieldIndexes(String[] columns) {
+    return 0;
+  }
+}

java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/splitDeclaration/beforeBroken.java

@@ -0,0 +1,10 @@
+// "Split into declaration and assignment" "true"
+
+class Foo {
+  {
+    <caret>int fieldIndexes = getFieldIndexes(Hellonew String[]{""});
+  }
+  public int getFieldIndexes(String[] columns) {
+    return 0;
+  }
+}

plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/psiutils/ExpressionUtils.java

@@ -1662,7 +1662,10 @@ public final class ExpressionUtils {
           return (PsiAssignmentExpression)((PsiExpressionStatement)block.addAfter(statement, declaration)).getExpression();
         }
         finally {
-          initializer.delete();
+          initializer = var.getInitializer();
+          if (initializer != null) {
+            initializer.delete();
+          }
         }
       }
     }