Commit Graph
188519 Commits
Author SHA1 Message Date
Dmitry Avdeev 774a1addaf fixing memory leak 2017-02-07 15:22:45 +03:00
Dmitry Avdeev f780f89eff IDEA-167726 PyCharm's XSD does not resolve the extension base when base schema does not have a na... 2017-02-07 15:22:45 +03:00
Alexander Zolotov bebc20f086 Live Templates: bulk update should change later segment first (IDEA-167694) 2017-02-07 15:17:23 +03:00
Semyon Proshev f69cc32911 PY-22222 Fixed: Type doesn't have expected attributes with __slots__
Don't forget about `__slots__` in PyClassTypeImpl.getMemberNames
2017-02-07 15:01:10 +03:00
Kirill Likhodedov 1752b5831b git tests: improve readability: use RunAll to chain tearDown tasks 2017-02-07 11:51:10 +00:00
Kirill Likhodedov 853b942db6 git tests: use correct method to edit file content
touch() is designed to create new file and have an assertion to check
that it is a new file. echo() should be used instead.
2017-02-07 11:51:09 +00:00
Kirill Likhodedov 8504e3ab40 git tests: simplify call to git
No need in format syntax: can use kotlin patterns now.
2017-02-07 11:51:09 +00:00
Kirill Likhodedov 185b03107d git tests: convert cucumber tests to kotlin
Cucumber tests are nice to read, but harder to debug.
Kotlin allows to achieve a close level of expressiveness
with much better abilities to debug and support.
2017-02-07 11:51:08 +00:00
Kirill Likhodedov bac02b92c7 git tests: better adjust notification content for assertions
Trim each line individually.
Treat <hr/> as line break to avoid fighting with presense or absense of line breaks around <hr/>.

Also use Streams to improve readability a bit.
2017-02-07 11:51:07 +00:00
Kirill Likhodedov e22b24ee12 git: propose better message for changelist name
Strip consecutive spaces.
Move this replacing before searching for changelists with same name,
which is more logical.
2017-02-07 11:51:07 +00:00
Kirill Likhodedov a12db512a5 git: fix the case when empty cherry-pick is in the middle of sequence
IDEA-73548 was fixed a long time ago and solved the problem when empty cherry-pick was the only one (or the last).
However if an empty commit was in the middle of the queue, the rest of cherry-picking queue was ignored.
2017-02-07 11:51:06 +00:00
Kirill Likhodedov 6b3e8f81b2 git: fix detection of "nothing to commit" situation
Git reports both to stdout and stderr in such situations, so the condition was always met.

If there is a more critical error during cherry-pick command execution, Git doesn't report the "nothing to commit" error, so there is no need in such condition anyway.
2017-02-07 11:51:05 +00:00
Kirill Likhodedov 6d508bb74e git: fix race condition in reading git command output
stdout and stderr are read by different threads, each of which modify same output collections.
These collections are non-thread-safe ArrayLists.

Because of this lack of synchronization, the list could get null elements,
which is unexpected by other code. null elements can appear if the size of the backing array and its elements are updated without proper synchronization.
2017-02-07 11:51:04 +00:00
Kirill Likhodedov 8470d20328 git tests: convert GitExecutor to kotlin 2017-02-07 11:51:01 +00:00
Kirill Likhodedov da2699102c git tests: rename to kotlin 2017-02-07 11:50:59 +00:00
Kirill Likhodedov 1f30734218 git tests: move some merge helpers to the base class
Also rename the AbstractVcsHelper instance: drop the 'my' prefix alien to Kotlin
2017-02-07 11:50:58 +00:00
Kirill Likhodedov e20aa16c4a git tests: move some utility method to the root class for future reuse
This caused method conflicts in GitChangeProviderTest,
which was adjusted (simplified) accordingly.
2017-02-07 11:50:56 +00:00
Semyon Proshev 83b4e14e22 Introduce separate unit test class for PyTupleAssignmentBalanceInspectionTest 2017-02-07 14:47:05 +03:00
Semyon Proshev 775a1c7ed0 Don't consider PyNoneType in PyTupleAssignmentBalanceInspection after None became keyword for Python 2 2017-02-07 14:47:04 +03:00
Semyon Proshev 51f0b3c60e Simplify PyTupleAssignmentBalanceInspection and move one method from PyUtil to it because the method is not used anywhere else 2017-02-07 14:47:04 +03:00
Semyon Proshev ed3b138827 PY-22224 Fixed: no warning about: x, y = None (TypeError: 'NoneType' object is not iterable)
Consider None reference and keyword in Py2 and Py3 in PyTupleAssignmentBalanceInspection
2017-02-07 14:47:04 +03:00
Semyon Proshev 9d12b3728b Simplify tests for PyTupleAssignmentBalanceInspection 2017-02-07 14:47:03 +03:00
Bas Leijdekkers c5f4701f6c RegExp: new "Exponential backtracking" inspection 2017-02-07 12:43:54 +01:00
Bas Leijdekkers 051acded35 RegExp: report error when atomic groups are not supported 2017-02-07 12:43:53 +01:00
Bas Leijdekkers 794018089a cleanup: use com.intellij.psi.PsiElementVisitor.EMPTY_VISITOR 2017-02-07 12:43:53 +01:00
Alexey Kudravtsev 9c6ba5b7d8 moved "implements PersistentStateComponent" to java-impl to avoid java-psi-api to project-model dependency 2017-02-07 14:36:46 +03:00
Alexey Kudravtsev ea76551d54 project leak: clean fields in case of injected editors too 2017-02-07 14:36:46 +03:00
Alexey Kudravtsev f374cc7d19 project leak: explicitly wait for project scan in background to complete 2017-02-07 14:36:46 +03:00
Alexey Kudravtsev 6b43161e60 leaks: explicitly close global static PersistentHashMap 2017-02-07 14:36:46 +03:00
Alexey Kudravtsev e760009aaa cleanup 2017-02-07 14:36:46 +03:00
Sergey Simonchik 1c0db1f71a allow passing live template default values when creating from file templates (WEB-25303) 2017-02-07 14:18:46 +03:00
Dmitry Trofimov 23e1ac8133 Merging github pull request, occasionally accepted directly in github repository 2017-02-07 13:59:43 +03:00
Dmitry Trofimov 29e5ef59f7 Merge remote-tracking branch 'origin/master' 2017-02-07 13:54:21 +03:00
Semyon Proshev 0e377b5dc6 PY-21651 Fixed: Unresolved reference for attributes created by with statements
Visit with-statements while collecting targets inside `__int__` and `__new__` methods
2017-02-07 13:51:25 +03:00
Dmitry Trofimov 7255d2db06 Merge branch 'master' of git.labs.intellij.net:idea/community 2017-02-07 13:50:13 +03:00
Dmitry Trofimov 388922655e Merge pull request #510 from plumpy/master
Pass the project as a parameter to getDefaultFolder.
2017-02-07 13:47:08 +03:00
Egor.Ushakov ea28ccc01d fixed eval of static methods with a qualifier 2017-02-07 13:27:03 +03:00
Dennis Ushakov 0739a9721d avoid adding&removing broken plugins, add only when not broken 2017-02-07 12:58:07 +03:00
Aleksey Pivovarov 9f2f10f6ec diff: remove unnecessary field 2017-02-07 12:49:50 +03:00
Aleksey Pivovarov 2544579a57 diff: update test data 2017-02-07 12:49:50 +03:00
Vladimir Krivosheev f21fe14091 fix test data 2017-02-07 10:37:38 +01:00
Vladimir.Orlov 92114d76de Bundle jdk instead of jre+tools.jar.
Reason: IDEA-166909 Compiling 1.5 with JDK9 problem
2017-02-07 12:02:56 +03:00
Kirill Kirichenko 3858f7980b IDEA-167799 HiPDI menu arrows are too small for Darcula/IntelliJ themes on Windows and Linux 2017-02-07 11:56:45 +03:00
Anna.Kozlova af7dd1def7 ensure project leak hunter is started (when first test which init the app is UsefulTestCase, then initial val of ourDebugMode is false and it would be restored in tearDown, afterwards only explicit setting to true would help) 2017-02-07 09:49:38 +01:00
Anna.Kozlova b45cf8967a check for case sensitive fs 2017-02-07 09:49:38 +01:00
vadim.lomshakov 80b791527c [rider]: share lookup colors with summary info popup 2017-02-07 11:46:37 +03:00
vadim.lomshakov 09cac118a9 [rider]: allow to disable autopopup quick doc for Rider lookup items 2017-02-07 11:39:31 +03:00
peter b4599c25d7 avoid races by updating all stub/AST-related data in a file atomically 2017-02-07 09:35:15 +01:00
Daniil Ovchinnikov d1e18502d0 [groovy] return null if it's impossible to start script run
configuration instead of throwing an assertion error (EA-94096)
2017-02-07 10:54:55 +03:00
Vladimir.Orlov 26e8deb056 PyCharm EDU windows installer: replace outdated ExecCmd plugin on ExecDos. 2017-02-07 10:47:18 +03:00