cleanup: use com.intellij.psi.PsiElementVisitor.EMPTY_VISITOR

This commit is contained in:
Bas Leijdekkers
2017-02-07 12:43:53 +01:00
parent 9c6ba5b7d8
commit 794018089a
4 changed files with 5 additions and 6 deletions
@@ -67,12 +67,12 @@ public class EqualsAndHashcodeBase extends BaseJavaBatchLocalInspectionTool {
return CachedValueProvider.Result.create(Pair.create(myEquals, myHashCode), psiObjectClass);
});
if (pair == null) return new PsiElementVisitor() {};
if (pair == null) return PsiElementVisitor.EMPTY_VISITOR;
//jdk wasn't configured for the project
final PsiMethod myEquals = pair.first;
final PsiMethod myHashCode = pair.second;
if (myEquals == null || myHashCode == null || !myEquals.isValid() || !myHashCode.isValid()) return new PsiElementVisitor() {};
if (myEquals == null || myHashCode == null || !myEquals.isValid() || !myHashCode.isValid()) return PsiElementVisitor.EMPTY_VISITOR;
return new JavaElementVisitor() {
@Override public void visitClass(PsiClass aClass) {
@@ -38,8 +38,7 @@ public abstract class GenericsInspectionToolBase extends BaseJavaBatchLocalInspe
@Override
public PsiElementVisitor buildVisitor(@NotNull ProblemsHolder holder, boolean isOnTheFly) {
PsiFile file = holder.getFile();
if (!PsiUtil.isLanguageLevel5OrHigher(file)) return new PsiElementVisitor() {
};
if (!PsiUtil.isLanguageLevel5OrHigher(file)) return PsiElementVisitor.EMPTY_VISITOR;
return super.buildVisitor(holder, isOnTheFly);
}
@@ -86,7 +86,7 @@ public class NullableStuffInspectionBase extends BaseJavaBatchLocalInspectionToo
public PsiElementVisitor buildVisitor(@NotNull final ProblemsHolder holder, boolean isOnTheFly) {
final PsiFile file = holder.getFile();
if (!PsiUtil.isLanguageLevel5OrHigher(file) || nullabilityAnnotationsNotAvailable(file)) {
return new PsiElementVisitor() { };
return PsiElementVisitor.EMPTY_VISITOR;
}
return new JavaElementVisitor() {
@Override
@@ -122,7 +122,7 @@ public abstract class BaseInspection extends BaseJavaBatchLocalInspectionTool {
final PsiFile file = holder.getFile();
assert file.isPhysical();
if (!shouldInspect(file)) {
return new PsiElementVisitor() { };
return PsiElementVisitor.EMPTY_VISITOR;
}
final BaseInspectionVisitor visitor = buildVisitor();
visitor.setProblemsHolder(holder);