test expectations for IDEA-92380 "Constant Conditions & Exceptions": relax possible NPE reporting for fields (volatile fields)

This commit is contained in:
peter
2012-11-07 20:47:54 +01:00
parent 1341348316
commit f565a0b614
2 changed files with 69 additions and 0 deletions
@@ -0,0 +1,68 @@
import org.jetbrains.annotations.Nullable;
class Foo {
@Nullable volatile Object data;
void checkNotNullAndUse(Foo f) {
if (f.data != null) {
System.out.println(<warning descr="Method invocation 'f.data.hashCode()' may produce 'java.lang.NullPointerException'">f.data.hashCode()</warning>);
}
}
void checkNullAndReturn(Foo f) {
if (f.data == null) {
return;
}
System.out.println(<warning descr="Method invocation 'f.data.hashCode()' may produce 'java.lang.NullPointerException'">f.data.hashCode()</warning>);
}
void warnWhenWrongCheck() {
if (data != null) {
return;
}
System.out.println(<warning descr="Method invocation 'data.hashCode()' may produce 'java.lang.NullPointerException'">data.hashCode()</warning>);
System.out.println(<warning descr="Method invocation 'data.hashCode()' may produce 'java.lang.NullPointerException'">data.hashCode()</warning>);
}
void warnWhenNotChecked(Foo f) {
System.out.println(<warning descr="Method invocation 'f.data.hashCode()' may produce 'java.lang.NullPointerException'">f.data.hashCode()</warning>);
}
void warnWhenNotCheckedThis() {
System.out.println(<warning descr="Method invocation 'data.hashCode()' may produce 'java.lang.NullPointerException'">data.hashCode()</warning>);
}
void dontWarnWhenDoubleChecked(Foo f) {
if (f.data == null) {
return;
}
if (f.data == null) {
return;
}
System.out.println(<warning descr="Method invocation 'f.data.hashCode()' may produce 'java.lang.NullPointerException'">f.data.hashCode()</warning>);
}
void dontWarnWhenDoubleChecked_This_Synchronized() {
if (data == null) {
return;
}
synchronized (this) {
if (data == null) {
return;
}
}
System.out.println(<warning>data.hashCode()</warning>);
}
void dontWarnWhenDoubleChecked_This_WithMethodCall() {
if (data == null) {
return;
}
System.out.println(<warning>data.hashCode()</warning>);
if (data == null) {
return;
}
System.out.println(<warning>data.hashCode()</warning>);
}
}
@@ -133,6 +133,7 @@ public class DataFlowInspectionFixtureTest extends JavaCodeInsightFixtureTestCas
public void testConstantDoubleComparisons() { doTest(); }
public void _testMutableNullableFieldsTreatment() { doTest(); }
public void _testMutableVolatileNullableFieldsTreatment() { doTest(); }
public void testMutableNotAnnotatedFieldsTreatment() { doTest(); }
}