MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

test expectations for IDEA-92380 "Constant Conditions & Exceptions": relax possible NPE reporting for fields

Browse Source
This commit is contained in:
peter
2012-11-07 20:44:08 +01:00
parent 5ee417fd7b
commit 1341348316
3 changed files with 141 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
java/java-tests/testData/inspection/dataFlow/fixture/MutableNotAnnotatedFieldsTreatment.java
+68
View File
@@ -0,0 +1,68 @@
import org.jetbrains.annotations.Nullable;
class Foo {
Object data;
void checkNotNullAndUse(Foo f) {
if (f.data != null) {
System.out.println(f.data.hashCode());
}
}
void checkNullAndReturn(Foo f) {
if (f.data == null) {
return;
}
System.out.println(f.data.hashCode());
}
void warnWhenWrongCheck() {
if (data != null) {
return;
}
System.out.println(<warning descr="Method invocation 'data.hashCode()' may produce 'java.lang.NullPointerException'">data.hashCode()</warning>);
System.out.println(data.hashCode());
}
void dontWarnWhenNotChecked(Foo f) {
System.out.println(f.data.hashCode());
}
void dontWarnWhenNotCheckedThis() {
System.out.println(data.hashCode());
}
void dontWarnWhenDoubleChecked(Foo f) {
if (f.data == null) {
return;
}
if (f.data == null) {
return;
}
System.out.println(f.data.hashCode());
}
void dontWarnWhenDoubleChecked_This_Synchronized() {
if (data == null) {
return;
}
synchronized (this) {
if (data == null) {
return;
}
}
System.out.println(data.hashCode());
}
void dontWarnWhenDoubleChecked_This_WithMethodCall() {
if (data == null) {
return;
}
System.out.println(data.hashCode());
if (data == null) {
return;
}
System.out.println(data.hashCode());
}
}
java/java-tests/testData/inspection/dataFlow/fixture/MutableNullableFieldsTreatment.java
+70
View File
@@ -0,0 +1,70 @@
import org.jetbrains.annotations.Nullable;
class Foo {
@Nullable Object data;
void checkNotNullAndUse(Foo f) {
if (f.data != null) {
System.out.println(f.data.hashCode());
}
}
void checkNullAndReturn(Foo f) {
if (f.data == null) {
return;
}
System.out.println(f.data.hashCode());
}
void warnWhenWrongCheck() {
if (data != null) {
return;
}
System.out.println(<warning descr="Method invocation 'data.hashCode()' may produce 'java.lang.NullPointerException'">data.hashCode()</warning>);
System.out.println(data.hashCode());
}
void warnWhenNotCheckedOnce(Foo f) {
System.out.println(<warning descr="Method invocation 'f.data.hashCode()' may produce 'java.lang.NullPointerException'">f.data.hashCode()</warning>);
System.out.println(f.data.hashCode());
}
void warnWhenNotCheckedThisOnce() {
System.out.println(<warning descr="Method invocation 'data.hashCode()' may produce 'java.lang.NullPointerException'">data.hashCode()</warning>);
System.out.println(data.hashCode());
}
void dontWarnWhenDoubleChecked(Foo f) {
if (f.data == null) {
return;
}
if (f.data == null) {
return;
}
System.out.println(f.data.hashCode());
}
void dontWarnWhenDoubleChecked_This_Synchronized() {
if (data == null) {
return;
}
synchronized (this) {
if (data == null) {
return;
}
}
System.out.println(data.hashCode());
}
void dontWarnWhenDoubleChecked_This_WithMethodCall() {
if (data == null) {
return;
}
System.out.println(data.hashCode());
if (data == null) {
return;
}
System.out.println(data.hashCode());
}
}
java/java-tests/testSrc/com/intellij/codeInspection/DataFlowInspectionFixtureTest.java
+3
View File
@@ -131,5 +131,8 @@ public class DataFlowInspectionFixtureTest extends JavaCodeInsightFixtureTestCas
}
public void testConstantDoubleComparisons() { doTest(); }
public void _testMutableNullableFieldsTreatment() { doTest(); }
public void testMutableNotAnnotatedFieldsTreatment() { doTest(); }
}