disable loading extension defined in "implementation details" plugin if dependency is missing IDEA-215572 IDEA-200709

GitOrigin-RevId: 1b17a3e7a52e06239efff931a52ac064590121e8
This commit is contained in:
Nikita Skvortsov
2019-07-02 06:52:16 +03:00
committed by intellij-monorepo-bot
parent 5f9b1249e5
commit ce266374c4
@@ -1084,9 +1084,7 @@ public class PluginManagerCore {
checkDependants(pluginDescriptor, idToDescriptorMap::get, pluginId -> {
if (!idToDescriptorMap.containsKey(pluginId)) {
pluginDescriptor.setEnabled(false);
if (!pluginId.getIdString().startsWith(MODULE_DEPENDENCY_PREFIX)) {
if (pluginDescriptor.isImplementationDetail()) return true;
if (!pluginId.getIdString().startsWith(MODULE_DEPENDENCY_PREFIX) && !pluginDescriptor.isImplementationDetail()) {
faultyDescriptors.add(pluginId.getIdString());
disabledPluginIds.add(pluginDescriptor.getPluginId().getIdString());
String name = pluginDescriptor.getName();