From ce266374c4bb6393e9f16613ec6f14c3aab3ce7d Mon Sep 17 00:00:00 2001
From: Nikita Skvortsov <nikita.skvortsov@jetbrains.com>
Date: Mon, 17 Jun 2019 13:03:49 +0300
Subject: [PATCH] disable loading extension defined in "implementation details"
 plugin if dependency is missing IDEA-215572 IDEA-200709

GitOrigin-RevId: 1b17a3e7a52e06239efff931a52ac064590121e8
---
 .../src/com/intellij/ide/plugins/PluginManagerCore.java       | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/platform/core-impl/src/com/intellij/ide/plugins/PluginManagerCore.java b/platform/core-impl/src/com/intellij/ide/plugins/PluginManagerCore.java
index c21adaa39ec5..5443b0049a7d 100644
--- a/platform/core-impl/src/com/intellij/ide/plugins/PluginManagerCore.java
+++ b/platform/core-impl/src/com/intellij/ide/plugins/PluginManagerCore.java
@@ -1084,9 +1084,7 @@ public class PluginManagerCore {
       checkDependants(pluginDescriptor, idToDescriptorMap::get, pluginId -> {
         if (!idToDescriptorMap.containsKey(pluginId)) {
           pluginDescriptor.setEnabled(false);
-          if (!pluginId.getIdString().startsWith(MODULE_DEPENDENCY_PREFIX)) {
-            if (pluginDescriptor.isImplementationDetail()) return true;
-
+          if (!pluginId.getIdString().startsWith(MODULE_DEPENDENCY_PREFIX) && !pluginDescriptor.isImplementationDetail()) {
             faultyDescriptors.add(pluginId.getIdString());
             disabledPluginIds.add(pluginDescriptor.getPluginId().getIdString());
             String name = pluginDescriptor.getName();