MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

SubtractionInCompareToInspectionBase: simplify overflow check

Browse Source 
Review ID: IDEA-CR-24978
This commit is contained in:
Tagir Valeev
2017-09-29 17:38:35 +07:00
parent 96c5bbef2f
commit b3596b56d5
1 changed files with 2 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/bugs/SubtractionInCompareToInspectionBase.java
+2 -10
View File
@@ -140,18 +140,10 @@ public class SubtractionInCompareToInspectionBase extends BaseInspection {
long leftMax = leftRange.max();
long rightMin = rightRange.min();
long rightMax = rightRange.max();
if (PsiType.INT.equals(type) &&
!overflowsInt(leftMin, rightMin) &&
!overflowsInt(leftMin, rightMax) &&
!overflowsInt(leftMax, rightMin) &&
!overflowsInt(leftMax, rightMax)) {
if (PsiType.INT.equals(type) && !overflowsInt(leftMin, rightMax) && !overflowsInt(leftMax, rightMin)) {
return true;
}
if (PsiType.LONG.equals(type) &&
!overflowsLong(leftMin, rightMin) &&
!overflowsLong(leftMin, rightMax) &&
!overflowsLong(leftMax, rightMin) &&
!overflowsLong(leftMax, rightMax)) {
if (PsiType.LONG.equals(type) && !overflowsLong(leftMin, rightMax) && !overflowsLong(leftMax, rightMin)) {
return true;
}
}