From b3596b56d5c0b8cedce82ad529c530ca775c392f Mon Sep 17 00:00:00 2001 From: Tagir Valeev Date: Fri, 29 Sep 2017 17:38:35 +0700 Subject: [PATCH] SubtractionInCompareToInspectionBase: simplify overflow check Review ID: IDEA-CR-24978 --- .../bugs/SubtractionInCompareToInspectionBase.java | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/bugs/SubtractionInCompareToInspectionBase.java b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/bugs/SubtractionInCompareToInspectionBase.java index 7d5387da04da..f7e98cf08ed8 100644 --- a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/bugs/SubtractionInCompareToInspectionBase.java +++ b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/bugs/SubtractionInCompareToInspectionBase.java @@ -140,18 +140,10 @@ public class SubtractionInCompareToInspectionBase extends BaseInspection { long leftMax = leftRange.max(); long rightMin = rightRange.min(); long rightMax = rightRange.max(); - if (PsiType.INT.equals(type) && - !overflowsInt(leftMin, rightMin) && - !overflowsInt(leftMin, rightMax) && - !overflowsInt(leftMax, rightMin) && - !overflowsInt(leftMax, rightMax)) { + if (PsiType.INT.equals(type) && !overflowsInt(leftMin, rightMax) && !overflowsInt(leftMax, rightMin)) { return true; } - if (PsiType.LONG.equals(type) && - !overflowsLong(leftMin, rightMin) && - !overflowsLong(leftMin, rightMax) && - !overflowsLong(leftMax, rightMin) && - !overflowsLong(leftMax, rightMax)) { + if (PsiType.LONG.equals(type) && !overflowsLong(leftMin, rightMax) && !overflowsLong(leftMax, rightMin)) { return true; } }