better name for interface method - IDEA-CR-31998

This commit is contained in:
Egor Ushakov
2018-04-24 15:16:09 +03:00
parent 10271291eb
commit 72c211c59c
6 changed files with 9 additions and 6 deletions
@@ -156,7 +156,7 @@ public abstract class BreakpointWithHighlighter<P extends JavaBreakpointProperti
protected Icon getValidatingIcon(boolean muted) {
if (myXBreakpoint != null) {
Icon icon = myXBreakpoint.getType().getValidatingIcon();
Icon icon = myXBreakpoint.getType().getPendingIcon();
if (icon != null) {
return icon;
}
@@ -70,7 +70,7 @@ public class JavaFieldBreakpointType extends JavaLineBreakpointTypeBase<JavaFiel
@NotNull
@Override
public Icon getValidatingIcon() {
public Icon getPendingIcon() {
return AllIcons.Debugger.Db_validate_field_breakpoint;
}
@@ -66,7 +66,7 @@ public abstract class JavaLineBreakpointTypeBase<P extends JavaBreakpointPropert
@Nullable
@Override
public Icon getValidatingIcon() {
public Icon getPendingIcon() {
return AllIcons.Debugger.Db_validate_breakpoint;
}
@@ -58,7 +58,7 @@ public class JavaMethodBreakpointType extends JavaLineBreakpointTypeBase<JavaMet
@NotNull
@Override
public Icon getValidatingIcon() {
public Icon getPendingIcon() {
return AllIcons.Debugger.Db_validate_method_breakpoint;
}
@@ -116,8 +116,11 @@ public abstract class XBreakpointType<B extends XBreakpoint<P>, P extends XBreak
return AllIcons.Debugger.Db_muted_disabled_breakpoint;
}
/**
* @return the icon shown for a breakpoint which is scheduled but not yet set (validated, resolved) in the debugger engine
*/
@Nullable
public Icon getValidatingIcon() {
public Icon getPendingIcon() {
return null;
}
@@ -397,7 +397,7 @@ public class XDebugSessionImpl implements XDebugSession {
synchronized (myRegisteredBreakpoints) {
myRegisteredBreakpoints.put(b, new CustomizedBreakpointPresentation());
if (b instanceof XLineBreakpoint) {
updateBreakpointPresentation((XLineBreakpoint)b, b.getType().getValidatingIcon(), null);
updateBreakpointPresentation((XLineBreakpoint)b, b.getType().getPendingIcon(), null);
}
}
handler.registerBreakpoint(b);