From 72c211c59c20f06378ee35c84c20bf684b481290 Mon Sep 17 00:00:00 2001
From: Egor Ushakov <egor.ushakov@jetbrains.com>
Date: Tue, 24 Apr 2018 15:13:09 +0300
Subject: [PATCH] better name for interface method - IDEA-CR-31998

---
 .../debugger/ui/breakpoints/BreakpointWithHighlighter.java   | 2 +-
 .../debugger/ui/breakpoints/JavaFieldBreakpointType.java     | 2 +-
 .../debugger/ui/breakpoints/JavaLineBreakpointTypeBase.java  | 2 +-
 .../debugger/ui/breakpoints/JavaMethodBreakpointType.java    | 2 +-
 .../com/intellij/xdebugger/breakpoints/XBreakpointType.java  | 5 ++++-
 .../src/com/intellij/xdebugger/impl/XDebugSessionImpl.java   | 2 +-
 6 files changed, 9 insertions(+), 6 deletions(-)

diff --git a/java/debugger/impl/src/com/intellij/debugger/ui/breakpoints/BreakpointWithHighlighter.java b/java/debugger/impl/src/com/intellij/debugger/ui/breakpoints/BreakpointWithHighlighter.java
index 2dc34b4fa66b..fda89ac4fc1f 100644
--- a/java/debugger/impl/src/com/intellij/debugger/ui/breakpoints/BreakpointWithHighlighter.java
+++ b/java/debugger/impl/src/com/intellij/debugger/ui/breakpoints/BreakpointWithHighlighter.java
@@ -156,7 +156,7 @@ public abstract class BreakpointWithHighlighter<P extends JavaBreakpointProperti
 
   protected Icon getValidatingIcon(boolean muted) {
     if (myXBreakpoint != null) {
-      Icon icon = myXBreakpoint.getType().getValidatingIcon();
+      Icon icon = myXBreakpoint.getType().getPendingIcon();
       if (icon != null) {
         return icon;
       }
diff --git a/java/debugger/impl/src/com/intellij/debugger/ui/breakpoints/JavaFieldBreakpointType.java b/java/debugger/impl/src/com/intellij/debugger/ui/breakpoints/JavaFieldBreakpointType.java
index 99412305ad3b..fc98ab6bfdc9 100644
--- a/java/debugger/impl/src/com/intellij/debugger/ui/breakpoints/JavaFieldBreakpointType.java
+++ b/java/debugger/impl/src/com/intellij/debugger/ui/breakpoints/JavaFieldBreakpointType.java
@@ -70,7 +70,7 @@ public class JavaFieldBreakpointType extends JavaLineBreakpointTypeBase<JavaFiel
 
   @NotNull
   @Override
-  public Icon getValidatingIcon() {
+  public Icon getPendingIcon() {
     return AllIcons.Debugger.Db_validate_field_breakpoint;
   }
 
diff --git a/java/debugger/impl/src/com/intellij/debugger/ui/breakpoints/JavaLineBreakpointTypeBase.java b/java/debugger/impl/src/com/intellij/debugger/ui/breakpoints/JavaLineBreakpointTypeBase.java
index 236e37d0c52c..b8a70c351523 100644
--- a/java/debugger/impl/src/com/intellij/debugger/ui/breakpoints/JavaLineBreakpointTypeBase.java
+++ b/java/debugger/impl/src/com/intellij/debugger/ui/breakpoints/JavaLineBreakpointTypeBase.java
@@ -66,7 +66,7 @@ public abstract class JavaLineBreakpointTypeBase<P extends JavaBreakpointPropert
 
   @Nullable
   @Override
-  public Icon getValidatingIcon() {
+  public Icon getPendingIcon() {
     return AllIcons.Debugger.Db_validate_breakpoint;
   }
 
diff --git a/java/debugger/impl/src/com/intellij/debugger/ui/breakpoints/JavaMethodBreakpointType.java b/java/debugger/impl/src/com/intellij/debugger/ui/breakpoints/JavaMethodBreakpointType.java
index a8311a49a3fc..95bbf91fd2b3 100644
--- a/java/debugger/impl/src/com/intellij/debugger/ui/breakpoints/JavaMethodBreakpointType.java
+++ b/java/debugger/impl/src/com/intellij/debugger/ui/breakpoints/JavaMethodBreakpointType.java
@@ -58,7 +58,7 @@ public class JavaMethodBreakpointType extends JavaLineBreakpointTypeBase<JavaMet
 
   @NotNull
   @Override
-  public Icon getValidatingIcon() {
+  public Icon getPendingIcon() {
     return AllIcons.Debugger.Db_validate_method_breakpoint;
   }
 
diff --git a/platform/xdebugger-api/src/com/intellij/xdebugger/breakpoints/XBreakpointType.java b/platform/xdebugger-api/src/com/intellij/xdebugger/breakpoints/XBreakpointType.java
index c8cf0542c6a5..a77bf8c5991c 100644
--- a/platform/xdebugger-api/src/com/intellij/xdebugger/breakpoints/XBreakpointType.java
+++ b/platform/xdebugger-api/src/com/intellij/xdebugger/breakpoints/XBreakpointType.java
@@ -116,8 +116,11 @@ public abstract class XBreakpointType<B extends XBreakpoint<P>, P extends XBreak
     return AllIcons.Debugger.Db_muted_disabled_breakpoint;
   }
 
+  /**
+   * @return the icon shown for a breakpoint which is scheduled but not yet set (validated, resolved) in the debugger engine
+   */
   @Nullable
-  public Icon getValidatingIcon() {
+  public Icon getPendingIcon() {
     return null;
   }
 
diff --git a/platform/xdebugger-impl/src/com/intellij/xdebugger/impl/XDebugSessionImpl.java b/platform/xdebugger-impl/src/com/intellij/xdebugger/impl/XDebugSessionImpl.java
index 4f6c284340ce..d76a67ba599a 100644
--- a/platform/xdebugger-impl/src/com/intellij/xdebugger/impl/XDebugSessionImpl.java
+++ b/platform/xdebugger-impl/src/com/intellij/xdebugger/impl/XDebugSessionImpl.java
@@ -397,7 +397,7 @@ public class XDebugSessionImpl implements XDebugSession {
         synchronized (myRegisteredBreakpoints) {
           myRegisteredBreakpoints.put(b, new CustomizedBreakpointPresentation());
           if (b instanceof XLineBreakpoint) {
-            updateBreakpointPresentation((XLineBreakpoint)b, b.getType().getValidatingIcon(), null);
+            updateBreakpointPresentation((XLineBreakpoint)b, b.getType().getPendingIcon(), null);
           }
         }
         handler.registerBreakpoint(b);