mirror of
https://gitflic.ru/project/openide/openide.git
synced 2026-09-27 10:03:11 +07:00
diff: code review
IdRunnable is unnecessary - additional callbacks will do nothing, because myQueuedApplyRequest will be cleared
This commit is contained in:
@@ -240,19 +240,20 @@ public abstract class DiffRequestProcessor implements Disposable {
|
||||
// Abstract
|
||||
//
|
||||
|
||||
@Nullable private ApplyData myApplyData;
|
||||
@Nullable private ApplyData myQueuedApplyRequest;
|
||||
|
||||
@CalledInAwt
|
||||
protected void applyRequest(@NotNull DiffRequest request, boolean force, @Nullable ScrollToPolicy scrollToChangePolicy) {
|
||||
myIterationState = IterationState.NONE;
|
||||
|
||||
myApplyData = new ApplyData(request, force || (myApplyData != null && myApplyData.force), scrollToChangePolicy);
|
||||
IdRunnable task = new IdRunnable(this) {
|
||||
force = force || (myQueuedApplyRequest != null && myQueuedApplyRequest.force);
|
||||
myQueuedApplyRequest = new ApplyData(request, force, scrollToChangePolicy);
|
||||
Runnable task = new Runnable() {
|
||||
@Override
|
||||
public void run() {
|
||||
if (myApplyData == null || myDisposed) return;
|
||||
doApplyRequest(myApplyData.request, myApplyData.force, myApplyData.scrollToChangePolicy);
|
||||
myApplyData = null;
|
||||
if (myQueuedApplyRequest == null || myDisposed) return;
|
||||
doApplyRequest(myQueuedApplyRequest.request, myQueuedApplyRequest.force, myQueuedApplyRequest.scrollToChangePolicy);
|
||||
myQueuedApplyRequest = null;
|
||||
}
|
||||
};
|
||||
|
||||
|
||||
Reference in New Issue
Block a user