From 202f6d8cefb5d28b37d7a6b2aa26f43ec5777631 Mon Sep 17 00:00:00 2001
From: Aleksey Pivovarov <AMPivovarov@gmail.com>
Date: Mon, 13 Apr 2015 16:30:47 +0300
Subject: [PATCH] diff: code review

IdRunnable is unnecessary - additional callbacks will do nothing, because myQueuedApplyRequest will be cleared
---
 .../intellij/diff/impl/DiffRequestProcessor.java    | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/platform/diff-impl/src/com/intellij/diff/impl/DiffRequestProcessor.java b/platform/diff-impl/src/com/intellij/diff/impl/DiffRequestProcessor.java
index 73aec7c9cf20..a857f612cb5e 100644
--- a/platform/diff-impl/src/com/intellij/diff/impl/DiffRequestProcessor.java
+++ b/platform/diff-impl/src/com/intellij/diff/impl/DiffRequestProcessor.java
@@ -240,19 +240,20 @@ public abstract class DiffRequestProcessor implements Disposable {
   // Abstract
   //
 
-  @Nullable private ApplyData myApplyData;
+  @Nullable private ApplyData myQueuedApplyRequest;
 
   @CalledInAwt
   protected void applyRequest(@NotNull DiffRequest request, boolean force, @Nullable ScrollToPolicy scrollToChangePolicy) {
     myIterationState = IterationState.NONE;
 
-    myApplyData = new ApplyData(request, force || (myApplyData != null && myApplyData.force), scrollToChangePolicy);
-    IdRunnable task = new IdRunnable(this) {
+    force = force || (myQueuedApplyRequest != null && myQueuedApplyRequest.force);
+    myQueuedApplyRequest = new ApplyData(request, force, scrollToChangePolicy);
+    Runnable task = new Runnable() {
       @Override
       public void run() {
-        if (myApplyData == null || myDisposed) return;
-        doApplyRequest(myApplyData.request, myApplyData.force, myApplyData.scrollToChangePolicy);
-        myApplyData = null;
+        if (myQueuedApplyRequest == null || myDisposed) return;
+        doApplyRequest(myQueuedApplyRequest.request, myQueuedApplyRequest.force, myQueuedApplyRequest.scrollToChangePolicy);
+        myQueuedApplyRequest = null;
       }
     };