IG: ignore visibility for covariant equals (IDEA-158274)

plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/bugs/CovariantEqualsInspection.java

@@ -55,9 +55,6 @@ public class CovariantEqualsInspection extends BaseInspection {
       if (!HardcodedMethodConstants.EQUALS.equals(name)) {
         return;
       }
-      if (!method.hasModifierProperty(PsiModifier.PUBLIC)) {
-        return;
-      }
       final PsiParameterList parameterList = method.getParameterList();
       if (parameterList.getParametersCount() != 1) {
         return;
@@ -71,7 +68,7 @@ public class CovariantEqualsInspection extends BaseInspection {
       if (aClass == null) {
         return;
       }
-      final PsiMethod[] methods = aClass.getMethods();
+      final PsiMethod[] methods = aClass.findMethodsByName("equals", false);
       for (PsiMethod method1 : methods) {
         if (MethodUtils.isEquals(method1)) {
           return;

plugins/InspectionGadgets/test/com/siyeh/igtest/bugs/CovariantEqualsInspection.java

@@ -1,13 +0,0 @@
-package com.siyeh.igtest.bugs;
-
-public class CovariantEqualsInspection
-{
-    public CovariantEqualsInspection()
-    {
-    }
-
-    public boolean equals(CovariantEqualsInspection foo)
-    {
-        return true;
-    }
-}

plugins/InspectionGadgets/test/com/siyeh/igtest/bugs/CovariantEqualsInspection2.java

@@ -1,18 +0,0 @@
-package com.siyeh.igtest.bugs;
-
-public class CovariantEqualsInspection2
-{
-    public CovariantEqualsInspection2()
-    {
-    }
-
-    public boolean equals(CovariantEqualsInspection2 foo)
-    {
-        return true;
-    }
-
-    public boolean equals(Object foo)
-    {
-        return true;
-    }
-}

plugins/InspectionGadgets/test/com/siyeh/igtest/bugs/covariant_equals/CovariantEquals.java

@@ -28,4 +28,9 @@ class D implements I {
   public boolean equals(I i) {
     return false;
   }
+}
+class E {
+  boolean <warning descr="'equals()' should take 'Object' as its argument">equals</warning>(E e) {
+    return false;
+  }
 }