diff --git a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/bugs/CovariantEqualsInspection.java b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/bugs/CovariantEqualsInspection.java index 5e89b0b9c519..9c4217f3c5bb 100644 --- a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/bugs/CovariantEqualsInspection.java +++ b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/bugs/CovariantEqualsInspection.java @@ -55,9 +55,6 @@ public class CovariantEqualsInspection extends BaseInspection { if (!HardcodedMethodConstants.EQUALS.equals(name)) { return; } - if (!method.hasModifierProperty(PsiModifier.PUBLIC)) { - return; - } final PsiParameterList parameterList = method.getParameterList(); if (parameterList.getParametersCount() != 1) { return; @@ -71,7 +68,7 @@ public class CovariantEqualsInspection extends BaseInspection { if (aClass == null) { return; } - final PsiMethod[] methods = aClass.getMethods(); + final PsiMethod[] methods = aClass.findMethodsByName("equals", false); for (PsiMethod method1 : methods) { if (MethodUtils.isEquals(method1)) { return; diff --git a/plugins/InspectionGadgets/test/com/siyeh/igtest/bugs/CovariantEqualsInspection.java b/plugins/InspectionGadgets/test/com/siyeh/igtest/bugs/CovariantEqualsInspection.java deleted file mode 100644 index e0ea3d2009f0..000000000000 --- a/plugins/InspectionGadgets/test/com/siyeh/igtest/bugs/CovariantEqualsInspection.java +++ /dev/null @@ -1,13 +0,0 @@ -package com.siyeh.igtest.bugs; - -public class CovariantEqualsInspection -{ - public CovariantEqualsInspection() - { - } - - public boolean equals(CovariantEqualsInspection foo) - { - return true; - } -} diff --git a/plugins/InspectionGadgets/test/com/siyeh/igtest/bugs/CovariantEqualsInspection2.java b/plugins/InspectionGadgets/test/com/siyeh/igtest/bugs/CovariantEqualsInspection2.java deleted file mode 100644 index 526f7e7887ac..000000000000 --- a/plugins/InspectionGadgets/test/com/siyeh/igtest/bugs/CovariantEqualsInspection2.java +++ /dev/null @@ -1,18 +0,0 @@ -package com.siyeh.igtest.bugs; - -public class CovariantEqualsInspection2 -{ - public CovariantEqualsInspection2() - { - } - - public boolean equals(CovariantEqualsInspection2 foo) - { - return true; - } - - public boolean equals(Object foo) - { - return true; - } -} diff --git a/plugins/InspectionGadgets/test/com/siyeh/igtest/bugs/covariant_equals/CovariantEquals.java b/plugins/InspectionGadgets/test/com/siyeh/igtest/bugs/covariant_equals/CovariantEquals.java index e34f07954ea3..8c53ae024b66 100644 --- a/plugins/InspectionGadgets/test/com/siyeh/igtest/bugs/covariant_equals/CovariantEquals.java +++ b/plugins/InspectionGadgets/test/com/siyeh/igtest/bugs/covariant_equals/CovariantEquals.java @@ -28,4 +28,9 @@ class D implements I { public boolean equals(I i) { return false; } +} +class E { + boolean equals(E e) { + return false; + } } \ No newline at end of file