Tagir Valeev 5bd30e691d IDEA-181743 IntelliJ suggests bad refactoring for compareTo with Optionals ...

Reference expressions are compared instead of variables now

2017-11-10 17:38:53 +07:00

..

accessStaticViaInstance

java 8: access static method through instance variable: don't show warning, error is enough; add quick fix for an error same as for inspection

2017-04-07 18:20:18 +02:00

addAnnotationAttributeName

Java inspection: Added a fix for single-value annotations where the annotation doesn't have a 'value()' method and therefore "Expand Annotation to Normal Form" fix couldn't be applied (IDEA-158456, IDEA-157727)

2016-07-20 13:33:13 +03:00

addAssert

…

addCatchBlock

…

addMethodBody

…

addMethodCallQualifier

…

addMissingRequiredAnnotationParameters

AddMissingRequiredAnnotationParametersFix: handle nameless parameter as value (EA-105427)

2017-08-09 12:48:39 +03:00

addNewArrayExpression

EA-91047 - IOE: PsiJavaParserFacadeImpl.createExpressionFromText

2016-11-02 17:02:29 +01:00

addOnDemandStaticImport

fix yet another PSI internals exception while updating "add on demand static import" intention

2017-07-22 08:08:18 +02:00

addReturn

Java: When generating return statement where the returned type is an array use raw type in array creation (IDEA-163341)

2017-01-30 13:37:29 +03:00

addRuntimeExceptionToThrows

…

addSingleStaticImport

ensure method, imported statically, is not hidden by a local one (IDEA-175967)

2017-07-18 14:32:41 +02:00

addToConstructorThrows

…

addToThrows

…

addTypeArguments

…

addTypeArgumentsConditional

…

addTypeCast

HighlightVisitorImpl: add standard quick-fixes for lambda return value

2017-08-28 17:30:01 +07:00

addVariableInitializer

"Initialize variable" leads to an exception on invalid code IDEA-181272

2017-10-27 16:35:42 +03:00

adjustFunctionContext

AdjustFunctionContextFix: suggest to change method accepting lambda/methodRef

2017-08-28 14:55:00 +07:00

annotateMethod

update AnnotateMethodTest data

2017-08-08 16:41:09 +02:00

anonymous2lambda

resolve references by qualified class name when qualifiers can't be resolved

2017-09-06 19:42:00 +03:00

anonymous2lambdaAlternative

better quick fix name

2017-05-02 20:47:50 +02:00

anonymous2methodReference

disable conversion from anonymous if method has javadoc

2016-05-31 18:38:26 +03:00

assignFieldFromParameter

disable assign parameter to final field (IDEA-173815)

2017-06-06 14:54:06 +03:00

bindFieldsFromParameters

bind parameter to field: ensure applicable field is chosen/skip already assigned (IDEA-160180)

2016-08-25 21:03:40 +03:00

breakStringOnLineBreaks

LightQuickFixTestCase: Check whether <caret> is present in "before" files; wrong tests fixed

2016-10-07 16:34:42 +07:00

bringVariableIntoScope

bring var to scope: disabled for resource variables (IDEA-180436)

2017-10-12 19:38:49 +02:00

castConstructorParameters

…

castMethodParameters

…

castMethodParameters15

make add cast fix available for vararg methods (IDEA-169541)

2017-03-14 14:17:14 +01:00

changeExtendsToImplements

…

changeMethodSignatureFromUsage

don't qualify with this in static context (IDEA-166793)

2017-01-20 12:58:34 +03:00

changeMethodSignatureFromUsage8

change signature from usage: ignore types of poly expressions if they are not assignable (IDEA-156521)

2016-05-25 18:40:17 +03:00

changeNewOperatorType

…

changeParameterClass

make type parameter implements interface: don't insert any methods in code

2017-09-06 10:53:09 +03:00

changeToAppend

…

changeTypeArgs

…

comparatorCombinators

ComparatorCombinatorsInspection: support chain comparisons, provide fix

2017-10-02 18:43:25 +07:00

comparatorResultComparison

ComparatorResultComparisonInspection: support >/>=/</<= checks

2017-06-08 10:14:34 +07:00

composeFunctionChain

[java formatter] c style comments formatting supported. Note, only single line comments or comments with each line starting with asterisks will be formatted, since by using /* and */ you

2017-06-20 14:48:26 +03:00

convert2Local

…

convertCollectionToArray

IDEA-113585 Cast to Type quick fix creates code that doesn't help

2017-09-19 16:10:34 +07:00

convertColorRepresentation

Java: Fixed conversion of constructor parameters for java.awt.Color (IDEA-172996)

2017-06-01 13:30:14 +03:00

convertDoubleToFloat

…

convertSwitchToIf

fix ControlFlowUtil.canCompleteNormally() regression (IDEA-141259)

2017-07-24 19:34:17 +02:00

copyAbstractMethodImplementation

fix testdata

2017-05-18 10:50:55 +03:00

createAnnotationMethodFromUsage

…

createAnnotationTypeFromUsage

…

createCastExpressionFromInstanceof

…

createClassFromNew

create class from new: put caret on name (IDEA-166356)

2017-01-13 16:24:36 +01:00

createClassFromUsage

…

createConstructorFromCall

[jvm-lang] java: add more Create Constructor tests

2017-11-09 18:52:51 +03:00

createConstructorFromSuper

…

createConstructorMatchingSuper

…

createConstructorParameterFromField

resolve references by qualified class name when qualifiers can't be resolved

2017-09-06 19:42:00 +03:00

createEnumConstantFromUsage

…

createFieldFromParameter

…

createFieldFromUsage

[jvm-lang] disable Create Field from Java method calls

2017-09-06 15:33:11 +03:00

createGetterOrSetter

…

createInnerClassFromNew

fix modifiers for created inner classes (IDEA-167750)

2017-02-06 19:08:41 +01:00

createInnerClassFromUsage

fix modifiers for created inner classes (IDEA-167750)

2017-02-06 19:08:41 +01:00

createLocalFromUsage

create local from usage: check containing code block (IDEA-178443)

2017-09-05 12:00:19 +03:00

createLocalVarFromInstanceof

Insert casted declaration in a nice place without exceptions (IDEA-176211)

2017-07-20 20:14:11 +02:00

createMethodFromMethodRef

process overloads to create method by method reference (IDEA-172193)

2017-05-02 12:31:24 +03:00

createMethodFromUsage

[jvm-lang] update Java-to-Java Create Method from usage tests

2017-09-06 21:24:13 +03:00

createParameterFromUsage

…

createPropertyFromUsage

…

defaultAnnotationParamValue

ConstantExpressionVisitor: for class access expression return the operand type

2017-09-28 13:15:14 +07:00

deferFinalAssignment

defer assignment: choose anchor from same code block

2016-10-12 14:04:38 +02:00

delegateWithDefaultValue

delegate params: compound 2 intentions in one, set preselection (IDEA-112043)

2016-06-24 12:04:48 +03:00

deleteCatch

…

deleteMultiCatch

…

deleteRepeatedInterface

…

deleteSideEffectsAware

IDEA-179128 Quick-fix for "'if' statement has empty body"

2017-09-19 13:04:21 +07:00

deleteUnreachable

Java: Better handling of unreachable code (IDEA-172642)

2017-05-23 12:28:44 +03:00

emptyIntention

…

emptyStatement

DeleteSideEffectsAwareFix: do not remove message for non-expression-statement

2017-10-11 15:51:21 +07:00

enableOptimizeImportsOnTheFly

…

encapsulateField

…

excessiveLambdaUsage

ExcessiveLambdaUsageInspection: support Java 9 requireNonNullElseGet

2017-09-13 10:46:01 +07:00

expandStaticImport

expand static import for all (IDEA-169239)

2017-03-07 14:57:35 +01:00

explicit2diamond

convert to diamonds: ensure check for applicability is performed on static factory as otherwise it would be just skipped (IDEA-170813)

2017-04-05 10:00:19 +02:00

explicit2var

[java] fixes formatting around soft keywords

2017-10-02 17:56:32 +02:00

extractIfCondition

…

extractSetFromComparison

unresolved qualifiers in ref expressions chain (follow IDEA-CR-24382)

2017-09-11 13:35:36 +03:00

extractStreamMap

ExtractChainedMapAction: more specific message; Guava FluentIterable support; Collection.forEach test

2017-03-07 13:50:45 +07:00

fieldHandle

Java: Improved inspection "MethodHandle/VarHandle type mismatch" - show candidates for replacement of method/constructor in a separate pop-up menu (IDEA-167318)

2017-03-17 15:15:45 +03:00

fixAll

test "Fix all 'Unnecessary fully qualified name' problems in file"

2017-04-27 19:21:50 +02:00

fixAllAnnotator

…

flipIntersection

…

fuseStreamOperations

FuseStreamOperationsInspection: fixes according to review IDEA-CR-24873

2017-09-27 10:50:03 +07:00

generalizeCatch

unhandled exception: shrink the highlighted range (IDEA-177234)

2017-08-09 18:38:29 +02:00

genericCreateFromUsage

GuessTypeParameters: explicitly set type element to the expected type

2017-09-05 21:13:29 +03:00

generifyFile

…

i18n

…

i18nize

…

implementAbstractFromNew

…

implementAbstractMethod

fix testdata

2016-04-29 14:41:28 +02:00

implementMethods

default Optional.empty for Optional type (IDEA-174268)

2017-06-14 19:27:02 +03:00

increaseLanguageLevel

…

initializeFinalFieldInConstructor

Cleanup (formatting)

2017-07-13 12:55:25 +02:00

inlineStreamMap

[java formatter] c style comments formatting supported. Note, only single line comments or comments with each line starting with asterisks will be formatted, since by using /* and */ you

2017-06-20 14:48:26 +03:00

insertNew

disable "insert new" fix on invalid code

2017-07-25 13:15:10 +02:00

insertSamMethodCall

IDEA-166827 Quick-fix to insert SAM-method call

2017-01-23 12:55:51 +07:00

insertSuper

provide this(); fix when constructor requires super call (IDEA-151335)

2017-05-18 10:50:55 +03:00

introduceVariable

…

invalidComparatorMethodReference

InvalidComparatorMethodReferenceInspection: fixes according to IDEA-CR-13278

2016-08-25 16:45:13 +03:00

iterateOver

…

javadocTags

fix invalid negative tests for quick-fixes

2016-10-10 18:24:14 +07:00

joinDeclaration

Java inspection: In "Join Declaration and Assignment" intention action warn about side effects of the initializer being removed (IDEA-157727)

2016-06-27 15:37:13 +03:00

lambda2methodCall

IDEA-163062 [Java8][Feature] Function.identity() inspection

2016-12-13 16:17:43 +07:00

lambda2methodReference

lambda -> method ref: don't transform by default array access qualifiers (IDEA-166740)

2017-01-18 19:11:49 +03:00

lambdaCodeBlock2Expr

…

magicConstant

quick fix for MagicConstantInspection which suggests to replace 1 with Font.BOLD

2016-04-15 12:34:33 +03:00

makeExtendsThrowable

…

makeInnerStatic

make class static on unresolved 'static' method reference (IDEA-157364)

2016-06-20 10:29:14 +03:00

makePublic

provide accessibility and static modifier fixes for method references (IDEA-166707)

2017-01-18 16:55:38 +03:00

mergeFilter

grammar fix in merge and split filter intentions

2017-10-15 11:40:59 +02:00

mergeIfAnd

IDEA-179557 Merge nested if's removes comment

2017-09-26 16:58:46 +07:00

mergeModuleStatementsFix

[java] fixes formatting in "provides with" reference list

2017-04-21 13:39:40 +02:00

methodHandle

Java: Implemented sorting the candidates pop-up and added icons in that pup-up for "MethodHandle/VarHandle type mismatch" (IDEA-167318), refactored upon review feedback (IDEA-CR-19455)

2017-03-21 14:37:01 +03:00

methodReturn

MethodReturnTypeFix: do not suggest when type refers to type parameter not available at method declaration

2017-10-09 09:27:16 +07:00

methodReturn8

return type fix: change type arguments of dependant type parameters only (IDEA-158361)

2016-07-11 18:05:00 +02:00

methodReturnBooleanFix

…

methodThrows

redundant throws: filter out unchecked exception (IDEA-177478, IDEA-177506)

2017-08-14 10:47:25 +03:00

modifier

ensure local classes are not suggested to be made static (IDEA-167085)

2017-01-25 13:42:32 +03:00

modifier18

provide accessibility and static modifier fixes for method references (IDEA-166707)

2017-01-18 16:55:38 +03:00

modifier19

java 9: hide inappropriate for interface modifier suggestions, ensure valid combination of modifiers (IDEA-171091)

2017-04-07 18:20:18 +02:00

moveBoundClassToFront

…

moveCatchUp

…

moveFieldAssignmentToInitializer

MoveFieldAssignmentToInitializerInspection: allow unknown methods

2017-10-09 16:38:56 +07:00

moveInitializerToConstructor

NPE (IDEA-176934)

2017-08-07 08:12:25 +02:00

moveInitializerToSetUp

fix test data

2017-10-25 15:46:06 +03:00

mustBeFinal

…

mustBeFinal18

copy to final: ensure to walk up through nested lambdas (IDEA-177496)

2017-08-16 15:35:15 +02:00

negationBroadScope

…

optionalIsPresent

IDEA-181743 IntelliJ suggests bad refactoring for compareTo with Optionals

2017-11-10 17:38:53 +07:00

optionalNull

OptionalAssignedToNullInspection: added assignment test

2017-03-02 09:49:30 +07:00

orderEntry

removed default file header, because it adds no information but subtracts attention and space

2017-05-11 13:39:07 +03:00

overrideMethod

…

permuteArguments

process enum constant resolve separately (IDEA-162975)

2017-02-17 19:37:21 +01:00

pullUp

…

qualifyThis

provide quick fix to qualify super call to default interface method from class (IDEA-172325)

2017-05-30 15:00:42 +03:00

qualifyWithThisInSuperCall

…

redundantStringOperation

RedundantStringOperationInspection: fixes after review IDEA-CR-25339

2017-10-17 10:58:07 +07:00

redundantTypeArgs

fix testdata

2017-10-18 10:50:03 +02:00

redundantUncheckedVarargs

LightQuickFixTestCase: Check whether <caret> is present in "before" files; wrong tests fixed

2016-10-07 16:34:42 +07:00

removeNewQualifier

…

removeQualifier

…

removeRedundantArgument

…

removeRedundantElse

Java: Merged ConfusingElseInspection and RemoveRedundantElseAction into RedundantElseInspection, made it an INFORMATION-level inspection (IDEA-162191)

2016-12-06 17:42:37 +03:00

removeTypeArguments

…

removeUnusedParameter

…

removeUnusedVariable

Java: Fixed removing unused variable occurrences from 'for' loop's update and init clauses (IDEA-180217)

2017-10-11 15:35:05 +03:00

renameConstructorMatchingClass

…

renameWrongReference

support Rename Reference on invalid method call (IDEA-176918)

2017-08-08 17:42:39 +02:00

replaceAddAllArrayToCollections

…

replaceAssignment

…

replaceAssignmentWithComparison

replace assignment with comparison in condition exps (IDEA-173860)

2017-06-06 19:07:58 +03:00

replaceCastWithVariable

…

replaceFieldWithGetterSetter

…

replaceFromOfNullable

IDEA-180288 Quick fix breaks code: Optional.ofNullable() with not-null argument

2017-10-11 10:28:14 +07:00

replaceIteratorForEachWithFor

Java intention: Quick fix for error "foreach not applicable to type java.util.Iterator" - handle comments and take care of empty block when copying the loop body (IDEA-124751)

2016-07-04 14:37:31 +03:00

replacePrimitiveWithBoxed

…

replaceWithConstant

…

replaceWithListAccess

…

replaceWithObjectsEquals

remove unnecessary parentheses in IDEA-161061 Quick-fix to replace nullableExpr.equals(...) with Objects.equals(nullableExpr, ...) (IDEA-CR-13960)

2016-09-21 10:50:32 +02:00

replaceWithOfNullable

…

replaceWithTernaryOperator

IDEA-179370 "Constant conditions and exceptions" quickfix "Replace with 'x != null ?:'" does nothing

2017-09-22 16:20:55 +07:00

replaceWithTrivialLambda

DataFlowInspection: highlight method references known to return constant true/false value with quick-fix changing them to trivial lambdas (partially fixes IDEA-170885).

2017-04-26 12:43:30 +07:00

returnSeparatedFromComputation

[java formatter] c style comments formatting supported. Note, only single line comments or comments with each line starting with asterisks will be formatted, since by using /* and */ you

2017-06-20 14:48:26 +03:00

returnSeparatedFromComputation8

Java inspection: Support inferred return type of lambda expression in EqualsReplaceableByObjectsCallInspection (IDEA-161076)

2016-09-16 17:26:41 +03:00

reuseVariableDeclaration

…

safeVarargs

…

simplifyBooleanExpression

make 'remove loop' fix work for '(false)' and 'for' (IDEA-CR-20896)

2017-05-10 17:11:34 +02:00

simplifyForEach

SimplifyForEachContext#from: fix nullability problem

2017-09-18 15:21:32 +07:00

sortContent

create SortContent intention to sort varargs and array initializers

2017-11-01 16:05:25 +07:00

splitDeclaration

split declaration: detect same variables after declaration (IDEA-175261)

2017-07-04 10:30:37 +02:00

splitFilter

fix split-filter intention on anyMatch()

2017-10-15 11:40:59 +02:00

staticImportConstant

disable import static constant at annotation position

2017-04-21 20:03:27 +02:00

staticImportMethod

renamed static import -> import static (IDEA-161681)

2016-09-27 17:21:04 +02:00

staticImportMethod8

static imports: don't compare with expected type when it depends on unresolved reference (IDEA-163072)

2017-03-31 18:01:29 +02:00

streamApiMigration

IDEA-180417 Generated code ("Replace with collect") is invalid follow-up

2017-10-13 13:12:17 +07:00

streamFilterNotNull

Quick-fix to insert .filter(Objects::nonNull) (IDEA-176699)

2017-08-08 12:14:36 +07:00

streamToLoop

StreamToLoop: support array slice (Arrays.stream(arr, from, to))

2017-09-18 17:30:53 +07:00

stringConcatInLoop

ChangeToAppendUtil: do not add useless .append("")

2017-10-09 12:12:34 +07:00

stringToCharacterLiteral

…

superMethodReturn

Cleanup (formatting)

2017-07-12 19:33:18 +02:00

suppress15Inspections

redundant throws inspection:

2017-08-09 12:14:26 +03:00

suppressLocalInspection

LightQuickFixTestCase: Check whether <caret> is present in "before" files; wrong tests fixed

2016-10-07 16:34:42 +07:00

suppressModuleInfoInspections

[java] class-like annotation wrapping in modules

2017-10-02 20:19:01 +02:00

suppressNonInspections

LightQuickFixTestCase: Check whether <caret> is present in "before" files; wrong tests fixed

2016-10-07 16:34:42 +07:00

surroundWithArray

surround with array fix: disable for non-denotable types (IDEA-173797)

2017-06-05 17:45:46 +03:00

surroundWithIf

DataFlowInspection: npe fixes fixed

2017-07-27 19:06:34 +07:00

surroundWithRequireNonNull

IDEA-176650 Provide a quick fix of "can produce NPE" that wraps qualifier with Obejcts.requireNonNull

2017-07-27 18:48:43 +07:00

surroundWithTry

RefactoringUtil#ensureCodeBlock enhanced and used in Surround with try-catch

2017-09-12 13:34:43 +07:00

swapIfStatements

…

trivialFunctionalExpressionUsage

trivial functional expression fix for empty lambda code block

2017-08-08 13:28:41 +02:00

trivialMethodReference

extend trivial method reference to support lambdas, convertible to method references

2017-08-07 16:00:10 +02:00

unimplement

…

unrollLoop

UnrollLoopAction: support counting loop; limit max iterations to unroll

2017-10-09 11:24:05 +07:00

unusedAssignment

side effects in for stmt declaration (IDEA-172700)

2017-06-28 16:10:43 +02:00

unwrapIfStatement

IG: fix containsConflictingDeclarations()

2017-10-22 19:41:59 +02:00

useBulkOperation

IDEA-178788 Suggestion code replace from list iteration to List.removeAll

2017-09-13 09:41:13 +07:00

useCompareMethod

[java formatter] c style comments formatting supported. Note, only single line comments or comments with each line starting with asterisks will be formatted, since by using /* and */ you

2017-06-20 14:48:26 +03:00

var2explicit

LVTI: var -> explicit type (IDEA-179177)

2017-09-26 16:13:12 +02:00

variableArrayType

…

variableParameterizedType

…

variableType

add fixes to change expected type when inference fails due to it (IDEA-162846)

2017-04-07 09:51:10 +02:00

varTypeFromCall

…

wrapAdapterCall

IDEA-180862 'Wrap using Collections.singletonList' intention doesn't work with subtypes of return type

2017-10-24 16:46:42 +07:00

wrapArrayToArraysAsList

WrapWithAdapterMethodCallFix replaces individual cases

2017-08-25 14:33:41 +07:00

wrapExpression

add parentheses to quick fix presentation

2016-11-23 11:31:36 +01:00

wrapLongWithMathToIntExact

HighlightVisitorImpl: add standard quick-fixes for lambda return value

2017-08-28 17:30:01 +07:00

wrapObjectWithOptional

LightQuickFixTestCase: Check whether <caret> is present in "before" files; wrong tests fixed

2016-10-07 16:34:42 +07:00