MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-05-06 05:10:22 +07:00
Code Issues Packages Projects Releases Wiki Activity

redundant throws: filter out unchecked exception (IDEA-177478, IDEA-177506)

Browse Source
This commit is contained in:
Dmitry Batkovich
2017-08-14 10:46:42 +03:00
parent 4232f8dd41
commit 7fb26c249d
2 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
java/java-analysis-impl/src/com/intellij/codeInspection/unneededThrows/RedundantThrowsDeclarationLocalInspection.java
View File

@@ -15,6 +15,7 @@
*/
package com.intellij.codeInspection.unneededThrows;
import com.intellij.codeInsight.ExceptionUtil;
import com.intellij.codeInsight.daemon.JavaErrorMessages;
import com.intellij.codeInsight.daemon.impl.analysis.JavaHighlightUtil;
import com.intellij.codeInsight.daemon.impl.quickfix.MethodThrowsFix;
@@ -135,7 +136,7 @@ public class RedundantThrowsDeclarationLocalInspection extends BaseJavaBatchLoca
.of(method.getThrowsList().getReferenceElements())
.map(ref -> {
PsiElement resolved = ref.resolve();
return resolved instanceof PsiClass ? new ReferenceAndType(ref) : null;
return resolved instanceof PsiClass && !ExceptionUtil.isUncheckedException((PsiClass)resolved) ? new ReferenceAndType(ref) : null;
})
.filter(Objects::nonNull)
.toArray(ReferenceAndType[]::new);

7
java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/methodThrows/beforeUncheckedException.java Normal file
View File

@@ -0,0 +1,7 @@
// "Remove 'RuntimeException' from 'f' throws list" "false"
import java.io.*;
class a {
void f() throws <caret>RuntimeException {
}
}