Commit Graph

400479 Commits

Author SHA1 Message Date
Tagir Valeev
ffca32cd79 [java-intention] Create method reference from usage: improve return type guess (IDEA-314907)
GitOrigin-RevId: 2e4e2eb156dcf6e0a739d9efd8b75b398d14ff2f
2023-03-20 17:26:05 +00:00
Tagir Valeev
31990e349d [java-intention] More tests for IDEA-314907
GitOrigin-RevId: 2ca51ee0d02ff7d36cd59efb8ce6b81af2372ea7
2023-03-20 17:26:01 +00:00
Tagir Valeev
32339d4c71 [javadoc] SnippetMarkup: report if regexp is too complex
GitOrigin-RevId: a131553de703e6f129e6228599a85f7fe852516d
2023-03-20 17:25:58 +00:00
Tagir Valeev
a99a0a890e [util] StringUtil#newBombedCharSequence: javadoc, better parameter name
GitOrigin-RevId: 7a263bda4f809d18dd1feff6d2ae2149a4a4ff06
2023-03-20 17:25:54 +00:00
Alexandr Suhinin
b5b3ceda3d [extract method] IDEA-315737: enable extract method on virtual expressions
GitOrigin-RevId: a6ca3dea5d3ab7ec8237c21a06e366e3e5c68a89
2023-03-20 17:18:51 +00:00
Alexandr Suhinin
094fff741c [extract method] IDEA-310330: change 'make static' default if it was changed in dialog
GitOrigin-RevId: bfb3804f0d120504ed44c4a9f42de45aa13f1350
2023-03-20 17:18:48 +00:00
Aleksey Pivovarov
b64219b690 git: do not ignore template commit message when initializing Staging area TW
GitOrigin-RevId: df9786b49a6bd8d16d9fba723a11947ca7898d63
2023-03-20 16:55:43 +00:00
Aleksey Pivovarov
abf4e0f515 vcs: rework DelayedCommitMessageProvider api
* Ensure the listeners are initialized before we compute initial commit message.
* Do not wait 10s before checking git templates

GitOrigin-RevId: fd77abe2ee1280d057942db9a9c4bcbead9bdb17
2023-03-20 16:55:40 +00:00
Aleksey Pivovarov
6ac807bc68 git: cleanup - rename class
GitOrigin-RevId: d2e8c93e329618b7567366943af67828a0c34aed
2023-03-20 16:55:36 +00:00
Aleksey Pivovarov
fb2473d756 IDEA-314816 git: fix infinite CommitMessage loading
Fix race in GitCommitTemplateTracker listeners

GitOrigin-RevId: cb1c89fef3bea4be80613a6d8031ede65bb1bb21
2023-03-20 16:55:33 +00:00
Aleksey Pivovarov
e39764009c vcs: cleanup - move CommitMessageUi dependency into CommitMessagePolicy
GitOrigin-RevId: 1da01b22070c3cbebdec96fd7c3a80e7df00833b
2023-03-20 16:55:30 +00:00
Aleksey Pivovarov
d0eff6c925 IDEA-314876 git: do not delay template commit message loading by 5 seconds
GitOrigin-RevId: ec89635e1e760550d1189e5b927e282370bf11cb
2023-03-20 16:55:27 +00:00
Aleksey Pivovarov
b62a8e858c git: unify the logic to choose commit message template for multiple repositories
It should not depend on a template being changed for a particular Repository.

GitOrigin-RevId: fcd0e04c48659e281cd39437311a11f5b98c6f63
2023-03-20 16:55:24 +00:00
Aleksey Pivovarov
8cd40770e9 vcs: ensure that overridden commit message is stored in history
GitOrigin-RevId: 797bcf5302f8b647b9649cf0c2383fe044fe0cfe
2023-03-20 16:55:21 +00:00
Aleksey Pivovarov
943fce9c95 git: cleanup
GitOrigin-RevId: cc0642dd1c4c0dc989953c199bc2dadecb2e413e
2023-03-20 16:55:18 +00:00
Aleksey Pivovarov
c4920fefcb vcs: remove unused parameter
Follow-up: 65292e6adf61552d8dd5b663db8e68e48c79af36

GitOrigin-RevId: fcaf484ea86ca9c6da54cbae5cc151b5064da9af
2023-03-20 16:55:15 +00:00
Ilia Motornyi
768bbd8d12 [platform] Fix run tool window toolbar exception
IJ-CR-104962

GitOrigin-RevId: a212735d4dd3a0f6e751de72a3d28de01cd3c873
2023-03-20 16:39:13 +00:00
Mikhail Pyltsin
ef15e33b26 IDEA-208195 [java-inspections] Failed enhanced switch conversion when branch has additional operation
GitOrigin-RevId: 81fe9fdfe77c51fc5521d969e48afc0dc80e4046
2023-03-20 16:29:33 +00:00
Andrei.Kuznetsov
46de08f0d1 Let MergingQueueGuiExecutor.ExecutorStateListener.afterLastTask have latest submitted task receipt as parameter
GitOrigin-RevId: 86eb2b66cad1ac3bb50e9e4bcce2679aa0344047
2023-03-20 16:07:47 +00:00
Andrei.Kuznetsov
30b97895ce Let MergingTaskQueue count submitted tasks
GitOrigin-RevId: 9090d00d234dcacb681e48da6d8fe3e12ff4ffe8
2023-03-20 16:07:45 +00:00
Andrei.Kuznetsov
40a98dd97a MergingQueueGuiExecutor should not catch exceptions that it cannot handle properly
GitOrigin-RevId: 480f2e6f061bdcdb8b2d6798c9579f98c3b769be
2023-03-20 16:07:44 +00:00
Andrei.Kuznetsov
a86e2a143f Add more tests for DumbService contracts
GitOrigin-RevId: 116cb9bb081d1c02253e1f0e4bd68003413a6af5
2023-03-20 16:07:43 +00:00
Andrei.Kuznetsov
befc0a0584 Fix unstable and hanging DumbServiceImplTest
Instability was caused by presence of two instances of DumbServiceImpl, each of which was publishing DumbModeListener events. In the end shared SmartModeScheduler might go into inconsistent state when project's DumbService is SMART, but scheduler thinks that it is DUMB because of mixed events from two sources.

Hangs were caused by absence of API for timed waiting. Now this API is introduced.

GitOrigin-RevId: b8ddcaa9518854baa9b5eb02a9eb08b8ef0922da
2023-03-20 16:07:41 +00:00
Andrei.Kuznetsov
2e4e032164 Remove queue management from DumbServiceImpl#DumbTaskListener
Now each `myTaskQueue.addTask` is followed by `myGuiDumbTaskRunner.startBackgroundProcess`. It's responsibility of `myGuiDumbTaskRunner` to react on every `startBackgroundProcess` and restart queue processing

GitOrigin-RevId: 4f73ac014d52076eb5ec92a5710bd18d9801f3f0
2023-03-20 16:07:40 +00:00
Andrei.Kuznetsov
2b13f8d897 Remove non-atomic state comparison in DumbServiceImpl. Nested tryEnterDumbMode does the same check in atomic way.
GitOrigin-RevId: edceca62f4c34df631ffae290b05ec2317807d5b
2023-03-20 16:07:38 +00:00
Andrei.Kuznetsov
fe6a4e69c0 MergingQueueGuiExecutor.startBackgroundProcess should do nothing if task queue is empty
GitOrigin-RevId: 711abdc8a0bc1c28ade7da6d4047b306a848ae5a
2023-03-20 16:07:37 +00:00
Andrei.Kuznetsov
ba769516ae Replace assert with Logger.assertTrue
GitOrigin-RevId: 3646e21238fc406e2b6ae7b6f1b6c7871079c3ac
2023-03-20 16:07:36 +00:00
Andrei.Kuznetsov
3689ebe60d Merge DumbServiceImpl#{SCHEDULED_TASKS and RUNNING_DUMB_TASKS} into single state
because these states are not different anymore

GitOrigin-RevId: 85438aaeaf2f2ec6568377d5ee4a61eadc084782
2023-03-20 16:07:34 +00:00
Andrei.Kuznetsov
f78464707e DumbService refactoring: DumbServiceImpl.processQueueUnderModalProgress should not depend on DumbService state...
... it should only depend on the state of DumbServiceGuiExecutor (it is up to DumbServiceGuiExecutor to decide if it wants to continue processing in background thread or start new processing in current thread as requested)

GitOrigin-RevId: 0b36aea5c2d5e327b638e2cad0b71289a3fb578b
2023-03-20 16:07:33 +00:00
Andrei.Kuznetsov
4f36022d7e Add more tests for DumbService contracts
GitOrigin-RevId: 16079d6b6fa1cfff9cc1412a6edfb3509365f1cc
2023-03-20 16:07:31 +00:00
Andrei.Kuznetsov
8ce7c98cd4 Convert MergingQueueGuiExecutorTest to JUnit4 to be able to run tests on background thread
GitOrigin-RevId: 79a1fe83d224060da4265909f696b56cdd63eaa6
2023-03-20 16:07:30 +00:00
Sergei Tachenov
34af9a2b3f [UI] IDEA-315632 Reword the Always Show Tool Window Icons setting
GitOrigin-RevId: 271eaa8532d0715699fae24fb514ce876509f600
2023-03-20 16:07:04 +00:00
Aleksey Pivovarov
d2e00e7737 IDEA-315760 UX-706 ui: do not try to enable disabled speedsearch
GitOrigin-RevId: 43146dd366976b87dfe3d5b6f2e2fa63202869e0
2023-03-20 16:05:55 +00:00
Aleksey Pivovarov
5e087d8cba ui: cleanup formatting
GitOrigin-RevId: b86f2efce4797b47b8e4fbffeac1c64e70d8a342
2023-03-20 16:05:50 +00:00
Yuriy Artamonov
282f1dc3ca [uast] IDEA-315618 Do not resolve bitwise operator for isConcatenation(uExpression) check in Kotlin
GitOrigin-RevId: f6bac6a39aa43de405bb59b0399789a4fc855723
2023-03-20 15:59:44 +00:00
Bas Leijdekkers
f33d9f61fe Java: don't show enum synthetic methods in Move Static Members refactoring dialog (IDEA-315779)
GitOrigin-RevId: 9c1f788ec3157e96af8c2f68ca0939fe4e932567
2023-03-20 15:58:59 +00:00
Bas Leijdekkers
bed790fde7 Java: add multi-caret and selection awareness to the Move Static Members refactoring (IDEA-315685)
GitOrigin-RevId: 0d15781c84749e948129f1d628688a798a740cd8
2023-03-20 15:58:57 +00:00
Bas Leijdekkers
4037a86899 Java Type Migration: use PanelFactory to get correct spacing between label and scroll pane automatically (IJ-CR-104304)
GitOrigin-RevId: 46c240b74e9927fd9bffa1d78dafb81e4f225774
2023-03-20 15:58:56 +00:00
Bas Leijdekkers
b395f524d7 Java: add multi-caret and selection awareness to the Encapsulate Fields refactoring (IDEA-315685)
GitOrigin-RevId: 0618ae31c550bacf809ae0496646ea9574786817
2023-03-20 15:58:54 +00:00
Bas Leijdekkers
779242d16d Java: add multi-caret and selection awareness to the Extract Superclass refactoring (IDEA-315685)
GitOrigin-RevId: c22f00bf76726acdf0421ddfcac0ab6079910c56
2023-03-20 15:58:52 +00:00
Bas Leijdekkers
c1041b1450 Java: add multi-caret and selection awareness to the Extract Interface refactoring (IDEA-315685)
GitOrigin-RevId: 8d1f585189c3826ca833edb5116c7b16db0ffc99
2023-03-20 15:58:51 +00:00
Bas Leijdekkers
8984a2c2a2 Java: inspection option tweak (IJPF-CR-8662)
GitOrigin-RevId: dd02eb32cd737d7fa0168a35572b5799526e842d
2023-03-20 15:58:49 +00:00
Bas Leijdekkers
b8563ed550 Java: add multi-caret and selection awareness to the Extract Delegate refactoring (IDEA-315685)
GitOrigin-RevId: fd096843f4fb8dda0df04d9c143ed000f7dc1bf4
2023-03-20 15:58:46 +00:00
Bas Leijdekkers
6ce29d7129 Java: add selection awareness to the Push Members Down refactoring (IDEA-315685)
GitOrigin-RevId: 0879169f1ef1d9045d6ce868fb15c3c83cf953a7
2023-03-20 15:58:44 +00:00
Bas Leijdekkers
42206c877e Java: add selection awareness to the Pull Members Up refactoring (IDEA-315685)
GitOrigin-RevId: 844f0cddb7af2fda71e241309003de5ebc3227d4
2023-03-20 15:58:42 +00:00
Sergei Tachenov
c3864df709 [UI] IDEA-315412 Convert Tool Window Layouts action group into DefaultActionGroup
This way its children are not visible in Customize Toolbar, as DefaultActionGroup
gets special treatment in ActionsTreeUtil.getActions(), only the children that are
defined in PlatformActions.xml are visible there.

Override update() to make it a popup action group by default, for example,
when it's added to a toolbar, but not in the main menu, where it's already
in a (popup group) submenu.

GitOrigin-RevId: dd910ea40a9ca8658151fcd956055456edd3e9c0
2023-03-20 15:50:47 +00:00
Alexey Kudravtsev
f9497d2b8a do not externalize disposed pointers to fix EA-822332 IAE: VirtualFilePointerManagerImpl.create
GitOrigin-RevId: 537d2d238cfcf674704a0d783e18826f7525db21
2023-03-20 15:28:49 +00:00
Mikhail Pyltsin
4390e0ec86 IDEA-312818 [java-inspections] "Replace concatenation" naming is too long
GitOrigin-RevId: 732e1b24a1ce6c3f3791ad18483865eada50f529
2023-03-20 15:27:55 +00:00
Dmitry Kichinsky
09a1e4c5e8 IDEA-315462 maven compound modules: outputRelativeToContentRoot refactoring
GitOrigin-RevId: ea13dadb6e4c88bbb1e6465bda353e5a2ecde051
2023-03-20 15:23:18 +00:00
Daniil Ovchinnikov
e988c6c894 ThreadContextTest does not need an application to run
GitOrigin-RevId: b34ac7e98834d7b1d02306141076426583d05004
2023-03-20 15:21:10 +00:00