Commit Graph
438402 Commits
Author SHA1 Message Date
Andrei.Kuznetsov adff273dbe An attempt to fix flaky tests caused by ADE via at FileBasedIndexImpl$5.isInSet(FileBasedIndexImpl.java:291)
According to logs, ProjectFileBasedIndexStartupActivity.onProjectClosing is invoked via message bus. Probably, it is invoked after myOpenProjects.add(project), but before fileBasedIndex.registerProjectFileSets(project). Try moving myOpenProjects.add(project) to the very end. In message bus event has already passed, the filter should be removed via disposable registered on project dispose.

GitOrigin-RevId: 2ebe4ea429d7f150ee13a48bc66af83f872e9f11
2024-03-22 23:02:40 +00:00
Vladimir Dolzhenko 4bbf267593 [kotlin] Fix java outside of java source root check
#KTIJ-1233 Fixed

GitOrigin-RevId: 76ca3f21ff5bb055fac5e28398e846df12af4552
2024-03-22 22:59:30 +00:00
Mikhail Pyltsin f96da6b5a3 [java-inspection] IDEA-349897 "Non-constant string concatenation for logging" must not offer fix for formattedLogger
GitOrigin-RevId: b1407fa846f06c03b2677573d0e4a0fe27bffa6d
2024-03-22 22:43:34 +00:00
Dmitriy.Panov 3206767805 IJI-1222 Idea Ultimate module sources of commercial plugins with public API are included in sources Maven artifact
GitOrigin-RevId: fb1b96d6860c5167becfea2c66648bf02c4998a1
2024-03-22 21:56:44 +00:00
Dmitriy.Panov cdc5f6bfdf IJI-1320 .form files published in IntelliJ sources archive
GitOrigin-RevId: b1dfe3106907c134d5a4c0590c45df97527b6e7a
2024-03-22 21:56:44 +00:00
Dmitriy.Panov b9da088eb6 reproducible builds: diff tool missing runtime dependency
GitOrigin-RevId: c1b377d4e9cf6a5e8c7cb12720ec68e8af38a45c
2024-03-22 21:56:44 +00:00
Georgii Ustinov 8940560c5d [Java. Logging] Refactor LoggingArgumentSymbolReferenceProvider
IDEA-342484

GitOrigin-RevId: 979e333aa1dd99b27e3d2851d184717ce640ba47
2024-03-22 21:23:15 +00:00
Andrei.Kuznetsov 48f3478425 IJPL-578 make sure indexes are ready in CodeInsightTestFixtureImpl.java before IdeaTestExecutionPolicy is invoked
GitOrigin-RevId: faf2e55fec592418cc61fd690efeb062c7f634f4
2024-03-22 21:19:37 +00:00
Mikhail Pyltsin 46d7f93b9b [java-run] IDEA-349848 Java: unable to run application in dumb mode from line marker. Don't update event manually
- delete updating actions

GitOrigin-RevId: 6f0d294c553623cd01b082852a16ddff3798534b
2024-03-22 20:36:03 +00:00
Mikhail Pyltsin 121e02006c [java-run] IDEA-349848 Java: unable to run application in dumb mode from line marker. Don't update event manually
- filter only RunContextAction

GitOrigin-RevId: 39a00ae4475109ef165220a84b79c90b78f9cf41
2024-03-22 20:35:58 +00:00
Mikhail Pyltsin ae303dd2a8 [java-inspection] IJ-CR-128589 IDEA-349655 Improvements for logging inspections. new LogStatementNotGuardedByLogCondition
- fix description

GitOrigin-RevId: f2d26236ef96e3cf2724091352c8b4296bd0ab32
2024-03-22 20:35:53 +00:00
Vladimir Krivosheev b7a35d35fa IDEA-330420 set idea.show.splash.longer by default to false, optmize splash showing and cancellation a bit
We will fix global lock on Windows soon, such a longer splash is less actual nowadays. The proper implementation is not easy.

GitOrigin-RevId: 0bf9f6004c87f1d94680b1cac64294a59d190e79
2024-03-22 20:22:34 +00:00
Sergei Vorobyov 2065a5ec1a [Project|Link] cleanup: use spendable project linking function where it is possible for free.
GitOrigin-RevId: 8101236fb3b48cd6f8ad5b7a5d36b97b669d93fa
2024-03-22 20:09:15 +00:00
Sergei Vorobyov 9575b17fca [SDK|Test] cleanup: use inline modifier for functions that define SDK lifecycle
The inline modifier allows using these functions in both threading models (blocking and suspendable)

GitOrigin-RevId: 14bd358a291cdadcee5da9b042813f58302080de
2024-03-22 20:09:12 +00:00
Eugene Zhuravlev 3a4f963bd5 JPS mappings for incremental compilation refactoring: filter static initializers out from some contexts; test data correction
GitOrigin-RevId: 88ab09c6d67e4ee5a6390fcbff2d4fde2933b83b
2024-03-22 19:51:19 +00:00
Daniil Ovchinnikov a5ae21d947 IJPL-850 extract intellij.platform.navbar.ide module (3/3)
GitOrigin-RevId: 33b0e898be7c556d3eee1accdd16a50fce32c52f
2024-03-22 19:42:27 +00:00
Daniil Ovchinnikov 0e0980d6aa IJPL-850 extract intellij.platform.navbar.ide module (2/3)
GitOrigin-RevId: e01078127e99de0d0a063bf8a91789836cc471ed
2024-03-22 19:42:22 +00:00
Daniil Ovchinnikov 8f5d79a32a IJPL-850 extract intellij.platform.navbar.ide module (1/3)
GitOrigin-RevId: 2fcb77d43ff9660af084f7b916dc01c7ceb72cbe
2024-03-22 19:42:17 +00:00
Daniil Ovchinnikov a427902436 utils: add withContainerContext
GitOrigin-RevId: f4b79cab323d5edc12aed40dbb6e97d3357a8dca
2024-03-22 19:42:12 +00:00
Anna Kozlova 156f86a322 [kotlin] k2: quick documentation: find annotations on backing field
- also fix links on annotation classes

^KTIJ-29181 fixed

GitOrigin-RevId: 450d4f2af447578480bc0ec7ae46f24ce0a3f904
2024-03-22 19:11:41 +00:00
Anna Kozlova 6839d9f650 [kotlin] k2: find documentation by source (navigation) element
^KTIJ-29185 fixed

GitOrigin-RevId: a12dded1a29719e39ff91f057eb1e73cabcefd60
2024-03-22 19:11:36 +00:00
Anna Kozlova 164b68b0c4 [kotlin] k2 quick doc: add test data for positive cases in KTIJ-27105
GitOrigin-RevId: b110f4cd251c66e7c33ac6d4ebfd718593e4f956
2024-03-22 19:11:31 +00:00
Anna Kozlova 87a9372ed2 [kotlin] k2 quick doc: show containing class for the companion object
^KTIJ-29182 fixed

GitOrigin-RevId: 60cd6975311c2b6dd83b8372ecf6c994f219b027
2024-03-22 19:11:27 +00:00
Anna Kozlova 237db3a9e8 [kotlin] k2 quick doc: show explicit abstract modifier
^KTIJ-29186 fixed

GitOrigin-RevId: 1475342d533dedec6574b224ee7e9c61a1d2157a
2024-03-22 19:11:22 +00:00
Anna Kozlova 5ad93308b1 [kotlin] inline: cleanup dangling dot after inline of selectorExpression
^KTIJ-29179 fixed

GitOrigin-RevId: 25d70db17384c700e9de49c22f531420cecf5ed4
2024-03-22 19:11:17 +00:00
Anna Kozlova 74b00e0243 [kotlin] inline: ensure to put run's lambda inside parenthesis when it's located in super's delegate clause
^KTIJ-29163 fixed

GitOrigin-RevId: 7e07e921a67e8a6a2f93285028bcbaa38f6a1d5f
2024-03-22 19:11:12 +00:00
Anna Kozlova d8c7446aa5 [kotlin] inline: delete when condition if when contains only else branch
^KTIJ-29176 fixed

GitOrigin-RevId: 52d6fbf2a12bed144caafd9b2cf3c70d4b8b2944
2024-03-22 19:11:08 +00:00
Kate Botsman e68cdb6036 RDCT-1200 Fix JetBrains Client doesn't report native crashes
To find and report native crashes `PerformanceWatcherImpl` requires two files: `.pid` and `.appinfo`

These files are stored in the system directory (`PathManager.getSystemPath()`).
For JetBrainsClient we replace default system path (`JetBrains/IntelliJIdea[VERSION]`) with custom per process path (`JetBrains/JetBrainsClient[VERSION]/tmp/per_process_system_0`)

This custom directory is cleaned up on every start therefore `.pid` and `.appinfo` files are also deleted and `PerformanceWatcherImpl` cannot send crash reports.

To fix that, we now keep these files between client restarts.

GitOrigin-RevId: 7c50445d07767cc3a12e36c5511778235e8142b6
2024-03-22 18:25:52 +00:00
Ilya.Kazakevich 78be43bdb1 Kotlinize class (required for PY-64402 to make fields bindable)
GitOrigin-RevId: d940f4984827399da77b2c2a0afbd57f01e7d2c1
2024-03-22 18:18:19 +00:00
Ilya.Kazakevich a23a5760f2 Rename .java to .kt
PY-64402

GitOrigin-RevId: dba98ef8b1e2d10d90894d265b333f7235a19f71
2024-03-22 18:18:13 +00:00
Alexey Kudravtsev 8c9ab4f72e optimization: do not keep (PsiElement -> empty highlights) in the map, to save on iteration and avoid storing invalid psi elements accidentally
GitOrigin-RevId: 4e1822dd64e78d1c4e8c4a263695d38304c7371d
2024-03-22 17:54:53 +00:00
Anna.Gromova 501628ded2 IDEA-173548 refactoring
GitOrigin-RevId: d76bdf4fb59945ca6b082b9d56c4bcf92a2185b3
2024-03-22 17:50:08 +00:00
Aleksei.Cherepanov d6d385913f Use script context to resolve SDK for a library that no modules depend on
Problem: The initial issues KTIJ-27480 [AE "Can't find built-in class kotlin.Cloneable" on opening build.gradle.kts with broken syntax highlighting] and KTIJ-25236 ["AssertionError: Can't find built-in class kotlin.Cloneable" after reload build.gradle.kts configuration] arose due to the following chain of events: we attempt to resolve a KTS script ⇒ in the script dependencies, we found a symbol for which Kotlin built-ins need to be created ⇒ creating of built-ins depends on the SDK and stdlib ⇒ (1) we find the SDK from the module to which this library is bound ⇒ (2) in our case, buildSrc module has no source set, so the library ends up hanging and not bound to any module ⇒ sdk=null ⇒ built-ins=Default (instead of JVM ones) ⇒ the required built-in is not found ⇒ internal resolve error. Such a situation (2) can occur if, for example, the buildSrc module does not have source folders and the Kotlin plugin is not applied. In this case, its list of source roots will be empty, and all libraries needed to resolve the script are not bound to any modules. Important notice: here we determine the SDK from the module. This behavior appears only when using the Composite resolver (only in the case of MPP projects). In the case of SEPARATE mode - the SDK is provided for the entire project, and such an error does not occur, while in SEPARATE it is prohibited and the SDK needs to be computed depending on the module.

Motivation: The situation where a library is not associated with any module because it is only used in a script remains unhandled. In this fix, we take into account this possible scenario and handle it to ensure correctness.

Solution: at the moment of building the mapping (1) between libraries and modules that use them, we also use information from `ScriptConfigurationManager` (if the search by direct dependencies does not yield results), to find the script that depends on this library. From this script, we add SDK information.

Note: in general, the architectural problem lies in the lack of context - in resolving, we can come to the same library from different contexts - scripts have their classpath, which requires the use of the Gradle JDK, the same library can be in the dependencies of buildSrc - there user can set any JDK using the toolchain. We can also find this library through symbol search. Thus, it turns out that the same library can have different environments, about which nothing is known at the moment.

^KTIJ-27480 Fixed


Merge-request: IJ-MR-129468
Merged-by: Aleksei Cherepanov <aleksei.cherepanov@jetbrains.com>

GitOrigin-RevId: 151c0bc82278ad379a8c091bcfc46850c9d83e9e
2024-03-22 17:46:39 +00:00
Ruslan Cheremin 22790fbb78 [core][monitoring][fus] JVM responsiveness reporting #3
+ adjust sampling params: sample less often, but make single sample heavier, collect more samples for reporting for more precision of high %-tiles
+ reduce reporting precision: double->float

GitOrigin-RevId: e42c422b6ca7d55019a44b220ae0d8633866f05f
2024-03-22 17:35:21 +00:00
Julia Beliaeva 5f4f444f69 [vcs-log] allow to not reset other filters when one filter is set
GitOrigin-RevId: bb6f5bae41275234a7add6e756c50da1a27a3f4c
2024-03-22 17:31:01 +00:00
Julia Beliaeva dbfaecfaef [vcs-log] do not reset other filters when one filter is removed
GitOrigin-RevId: 8f87c1b5757eb97fb2324092b3399b4d892b56e9
2024-03-22 17:30:56 +00:00
Julia Beliaeva c80143e4b7 [vcs-log] refactor filter accessor properties
GitOrigin-RevId: c1828661be45ad719f34b223b280214296b62995
2024-03-22 17:30:51 +00:00
Vladimir Dolzhenko 50fbbc61fd [kotlin] Provide kotlin source types aware create package action
#KTIJ-12018 Fixed

GitOrigin-RevId: 7013d9679eea45ec7af678ce8d91e1608239997e
2024-03-22 17:27:52 +00:00
Louis Vignier c38631ccd7 [java] Fix GraalVM version detection
#IDEA-349870 Fixed

GitOrigin-RevId: 4a6fbb3769a5c216c6e73d6a38fd3abc29874f75
2024-03-22 17:24:10 +00:00
Louis Vignier 49810e84cb [compiler] Use UI DSL in EclipseCompilerConfigurable
#IDEA-334671

GitOrigin-RevId: ce44d827c2b5ee4f7b30e8506a446e35a32d39a8
2024-03-22 17:24:07 +00:00
Louis Vignier d74ebdd5a4 [compiler] Use GridBag in CompilerModuleOptionsComponent
GitOrigin-RevId: 2562e53e54341437c6da525a1a0753851b0918bd
2024-03-22 17:24:03 +00:00
Louis Vignier ab8c7eb314 [compiler] Fix bytecode target combo in TargetOptionsComponent
#IDEA-144912 Fixed

GitOrigin-RevId: 689fb111984eb1d3e9c2c0f97a9d49c9ae2a77cc
2024-03-22 17:24:00 +00:00
Louis Vignier 9c363ae8a2 [compiler] Use GridBag in TargetOptionsComponent
GitOrigin-RevId: 33dd8f5e0c72f86a6edf097c78b548b002e41006
2024-03-22 17:23:57 +00:00
Louis Vignier ff8130b4fc [compiler] Use UI DSL in JavaCompilersTab
#IDEA-334671
#IDEA-344704 Fixed

GitOrigin-RevId: 5bc5529c7ae023f4039341d06dc65bbf8913b22a
2024-03-22 17:23:53 +00:00
Louis Vignier a0e94a1336 [compiler] Use UI DSL in JavacConfigurable
#IDEA-334671

GitOrigin-RevId: ecdcfa43f7008c1c7dc2b85423ffbb1d365505ba
2024-03-22 17:23:50 +00:00
Louis Vignier 0a10bd37e2 [compiler] Use UI DSL in CompilerConfigurable
GitOrigin-RevId: 8e337ec0932da57c78ce124816e4641459235cee
2024-03-22 17:23:46 +00:00
Andrei.Kuznetsov 3582fa2c1b IJPL-578 enable indexing in the background in tests and headless environments
GitOrigin-RevId: 05618428565c967b107c82cc5250f83a809d82cd
2024-03-22 17:17:01 +00:00
Vera Petrenkova ecb3b421de IDEA-348781 Update FileEditorManager.getFileTooltipText method parameters to handle null values
GitOrigin-RevId: a070d5c9783ae31b27bbe88a7ea0141808fe4490
2024-03-22 17:05:28 +00:00
Bart van Helvert b55f42d27d [kotlin] Remove unnecessary call to AA in final class constructor check
GitOrigin-RevId: ae1c4cca7fee52a9b4e2e7c0d8a96a2a79c1f316
2024-03-22 15:51:30 +00:00
Vladimir Dolzhenko 65e6f99184 [kotlin] update k1/k2 parity report
GitOrigin-RevId: ef36ac971dc714f8a996822b51d97fba01addbe3
2024-03-22 15:12:54 +00:00