Alexey Kudravtsev
40141272be
cleanup: reuse getTopLevelEditor
...
GitOrigin-RevId: fd489cce8fdbf1d9dec377feef8221bd318d3d83
2025-05-10 02:18:51 +00:00
Ivan Semenov
3e567f44f2
[platform] remove simpler usages of DumbServiceImpl
...
GitOrigin-RevId: ddbb065c29e63a45c1a5b0e940a9f65976de3211
2025-05-01 14:28:10 +00:00
Tagir Valeev
b22914aba7
[intention-preview] IJPL-185791 Wrong intention preview for modcommand that adds a space between words
...
GitOrigin-RevId: ba32d256ac6b65a453223200cb299fc29058e242
2025-04-28 16:39:47 +00:00
Alexey Kudravtsev
d00fbe19cf
test utility method CodeInsightSettings.runWithTemporarySettings
...
GitOrigin-RevId: aed6faffba4f7647ee797a59cbf0d7c6d8bfecb8
2025-04-23 13:48:20 +00:00
Alexey Kudravtsev
4d298d267e
fix test: do really test the smart indent
...
GitOrigin-RevId: c7ed82335b92b2655b6049a87da7b5856f3351a7
2025-04-22 12:28:14 +00:00
Aleksey Dobrynin
f2f2a358de
fix memory leak in LazyQuickFixTest
...
GitOrigin-RevId: a9daa7cef81c77eabdd43f5922730c6e92cc58ee
2025-04-17 11:25:13 +00:00
Alexey Kudravtsev
34db34ed54
avoid hard loop when failed to obtain PSI for some reason, to fix IJPL-183879 do not restart daemon too often after opening .git/config
...
GitOrigin-RevId: ad2d1fa58e7aa9f6142470e3cecabef185a0cf41
2025-04-15 12:00:10 +00:00
Tagir Valeev
ce42618fcc
[intention-preview] IntentionPreviewDiffResultTest: javadoc
...
GitOrigin-RevId: a51d9ad666abcfb337282ded0206c72fe446b117
2025-04-10 13:14:20 +00:00
Alexey Kudravtsev
36f9e0a5d8
cleanup: notnull
...
GitOrigin-RevId: 9f1c749ca7c43477002f98dbb935bbe1149145aa
2025-04-09 14:23:32 +00:00
Tagir Valeev
36e24ad205
[intention-preview] IJPL-183220 Intention preview: show deleted chunks if the result is a substring of the original chunk
...
GitOrigin-RevId: 3dea338111dcc6dd7b3cf59a5c41d635d8b73fda
2025-04-08 16:45:21 +00:00
Alexey Kudravtsev
6ce6f9e8c4
tests: print timeouts, more diags
...
GitOrigin-RevId: 726c98138aee23f1b3dd67008ee9325facb7dbd3
2025-04-04 19:46:27 +00:00
Mikhail Pyltsin
9cfd575fec
[uast-inspections] IDEA-370038 incorrect field type
...
GitOrigin-RevId: 20f8c4000322b05d090b0009688068f31c4e4947
2025-04-01 16:21:48 +00:00
Alexey Kudravtsev
0f8795413a
cleanup: print timeout values
...
GitOrigin-RevId: 84968bdd3e2615d0eaf14c372482f8ced79a9ab2
2025-03-31 11:34:43 +00:00
Tagir Valeev
b6806f1e7b
[java-highlighting] IDEA-369375 A syntax error (PsiErrorElement) should suppress the surrounding error
...
Also: allow a custom highlighter to supersede the default one
GitOrigin-RevId: c7d7a8be3ef762c9516ed3b637d467d4b544af00
2025-03-20 10:06:39 +00:00
Alexey Kudravtsev
aafc2dc341
IJPL-179246 Highlighting sometimes disappears after typing when Find tool window is open
...
Sometimes a highlighting pass should be run twice, e.g. when two file editors are opened for the same document.
When two GeneralHighlightingPasses for the same document are run reentrantly, they can compete for markup model, causing flicker as pass1 trying to reuse RangeHighlighter which pass2 already reused.
Also, running two identical piece of computation is bad performance-wise.
So when the document changed, we run highlighting passes for all file editors containing this document, but document-based passes are run only once per document, whereas editor-bound passes are run per file editor.
This document-bound pass is run only once, while its instances in all other file editors are waiting for the first instance to complete, instead of calling its own collectInformation().
We assume that ProgressableTextEditorHighlightingPass inheritors are document-bound passes.
GitOrigin-RevId: 85343ab33f53ba8b8d61342d2de3131be7650c6f
2025-03-12 11:59:14 +00:00
Alexey Kudravtsev
f69f700542
IJPL-29001 HighlightVisitor.analyze() should not be invoked when shouldHighlight() returned false
...
GitOrigin-RevId: 0c33b43b787f52497dfe9ba5527eed057913f0f9
2025-02-27 22:13:30 +00:00
Alexey Kudravtsev
74fe93899b
KTIJ-33100 K2: Import action caches stale state
...
GitOrigin-RevId: d6e38602d07e05e3a64422ddb8b07c43c8f81caa
2025-02-26 01:15:49 +00:00
Vladimir Krivosheev
0d69d3b443
fix MyEditable visibility
...
GitOrigin-RevId: 6e137cee2c57cb6634c6d28c371ede97753f9f47
2025-02-19 08:33:02 +00:00
Tagir Valeev
a0f777069b
[java-highlighting] move module-related warnings to JavaModuleDefinitionInspection
...
Part of IDEA-365344 Create a new Java error highlighter with minimal dependencies (PSI only)
GitOrigin-RevId: 66179a41da5e02b759f07f9d6638b87711181348
2025-02-17 12:04:21 +00:00
Alexey Kudravtsev
7694dbe247
do not rely on HighlightSeverity.toString() impl in string comparisons
...
GitOrigin-RevId: 88ef4f601158c936abfc0b240732bf14350a41e2
2025-02-16 16:56:24 +00:00
Alexey Kudravtsev
ddb2f0faef
restrict the total execution time of testImportHintsMustBeComputed test to avoid timing out builds
...
GitOrigin-RevId: 2e60439c6fb8800bce2634b66fb03a716294e692
2025-02-14 11:42:03 +00:00
Alexey Kudravtsev
65a7104258
make methods call contracts more visible, cleanup
...
GitOrigin-RevId: fd8004cf91f2364af7714f96d1e1b7463a927579
2025-02-14 11:42:03 +00:00
Max Medvedev
aa945fd575
IJPL-339 support separate highlighting for code insight contexts in editor
...
GitOrigin-RevId: 4a7c199fe792de703f2facc73eac75bbb683f048
2025-02-13 19:25:07 +00:00
Tagir Valeev
6fc7a8b6e5
[java-core] Split JavaServiceUtil
...
JavaServiceProviderUtil -> codeserver.core
JavaServiceLineMarkerUtil -> java-impl
GitOrigin-RevId: 65c42cdce19ab257ffd18143cc32ff4bd4aeacf7
2025-02-11 18:46:42 +00:00
Alexey Kudravtsev
0797be26a1
propagate Document to HighlightInfo.updateFields methods to correctly replace TextRange in IntentionActionDescriptor with RangeMarker to avoid incorrect fix range in IJPL-177149
...
GitOrigin-RevId: ab999ff6c504887f34108e8612b683e73a7b408d
2025-02-07 16:21:16 +00:00
Alexey Kudravtsev
4c83dc3b61
propagate Document to HighlightInfo.updateFields methods to correctly replace TextRange in IntentionActionDescriptor with RangeMarker to avoid incorrect fix range in IJPL-177149
...
GitOrigin-RevId: d36bf90cb262445e35b1701f95d7b596cfe9b1f7
2025-02-07 16:08:11 +00:00
Mikhail Pyltsin
4543b3fe66
[java-import] IDEA-366927 and IDEA-366926 improve auto-import
...
- fix inspections
GitOrigin-RevId: 629202f11b819d73aadbf9d0a6c6ce85b58bf39b
2025-02-05 15:36:45 +00:00
Leonid Shalupov
e4e5753846
housekeeping: remove unused imports
...
GitOrigin-RevId: ccba6d05260f5eb551ffa87e0d8a38dc93148a3a
2025-02-04 11:00:15 +00:00
Alexey Kudravtsev
d6e5c5ea8c
test for IJPL-160679 DaemonCodeAnalyzer.DaemonListener start/stop contract breaks when modal window is open
...
GitOrigin-RevId: 8fe46762f138cfd36d8f36cb7a5d24aca4a32233
2025-01-29 15:32:15 +00:00
Alexey Kudravtsev
4f69e19050
IJPL-175428 API for lazy quick fixes in highlighting
...
see
- com.intellij.lang.annotation.AnnotationBuilder.withLazyQuickFix
- com.intellij.codeInsight.daemon.impl.HighlightInfo.Builder.registerLazyFixes
GitOrigin-RevId: ebdda73c5bcc7a578a569b7126324c2886733dd4
2025-01-29 15:32:15 +00:00
Tagir Valeev
12d0001c52
[java-folding] JavaElementSignatureProvider.restoreBySignatureTokens: restore after incorrect numbers
...
Also do not serialize 'null' name (should not happen anymore, but just for the case)
Should help IDEA-344488 Class constructor is being constantly collapsed due to NumberFormatException from JavaElementSignatureProvider
GitOrigin-RevId: 3a123d4313bb10aaf6ccba55a8df8239b33920a0
2025-01-24 17:35:01 +00:00
Alexey Kudravtsev
b3403fad77
rename for clarity (part of KTIJ-28667 Lazy quick fix calculations for non unresolved references)
...
GitOrigin-RevId: feaa9f41875fa7ebf6fadc7e8a51c16df99cfaf8
2025-01-22 20:15:32 +00:00
Alexey Kudravtsev
835437db7e
tests: extract methods
...
GitOrigin-RevId: cf4436bdd7bb00c7945574565f7c585f0218e51e
2025-01-17 11:56:44 +00:00
Mikhail Pyltsin
3cb38fccaa
[java-imports] IDEA-13817 Create "favorites" for static import and completion
...
- part of "favorites" for static import. Inspection and refactoring
GitOrigin-RevId: a764a70000c3f0918e50a814908e5969b93688d7
2025-01-16 14:21:49 +00:00
Mikhail Pyltsin
9f03565ed9
[java-intentions] IDEA-365192 Use Object type for lambda type during creation field form usages
...
GitOrigin-RevId: f7532789d8aa7f3dcf17e1de3238a4a3847e5f42
2024-12-26 15:47:15 +00:00
Mikhail Pyltsin
36c497436c
IJ-CR-151305 [java-import] IDEA-364508 support optimize imports
...
- use layout table
GitOrigin-RevId: 6862419acc2beb72f87cca6b93612f9afe81f698
2024-12-19 18:02:44 +00:00
Tagir Valeev
0025dd535a
[java-intentions] IDEA-363624 Create Class generates invalid and redundant annotation @NotNull @NotNull for constructor parameter
...
GitOrigin-RevId: 9c3c9c55517369e6715c65a9696c287514261a10
2024-12-06 14:57:38 +00:00
Bartek Pacia
5569a2965d
[java-inspections] IDEA-14669 fixed: suggest adding specific non-null assertions from test frameworks
...
(cherry picked from commit 0d22d640ea4ee77a6bdfb5b4af504332e7456b68)
IJ-MR-150371
GitOrigin-RevId: 04a5fe47cf874ae78c5ad73282b55123f55e84cb
2024-12-05 12:35:38 +00:00
Tagir Valeev
d17386ed7f
[java] CreateMethodFromUsagePerformanceTest moved under com.intellij.java (IDEA-364184)
...
GitOrigin-RevId: 0d99b644ec6cee746dc920522c4154c2ae8ee7c1
2024-12-04 15:17:37 +00:00
Tagir Valeev
b257ed8a46
[java] Extract JavaCommentByLinePerformanceTest (IDEA-364184)
...
GitOrigin-RevId: 9478f8c3f8e52e3a0471d0b47e47d7ef1f914ffd
2024-12-04 15:17:36 +00:00
Tagir Valeev
37c03b015c
[java-intentions] IDEA-363734 "Make Xxx impelent Yyy" quick fix inserts @NotNull
...
GitOrigin-RevId: 4e9a3f94cf1aedadd0b2c4699e168ccb3be0e405
2024-12-03 14:25:33 +00:00
Mikhail Pyltsin
d92d827067
[java-inspections] IDEA-364068 don't use PsiType as field in ChangeExtendsToImplementsFix
...
GitOrigin-RevId: 51cb044bc1a3bad93f2ea34504a3c8e3f5ee9916
2024-12-02 11:55:32 +00:00
Bas Leijdekkers
c8ea468e8d
Java: add test for skipping array brackets when inserting type (IDEA-363482)
...
GitOrigin-RevId: bf6482a54a41ec6b88ec6f4016e75c7d9e9fb9ac
2024-11-27 16:21:35 +00:00
Tagir Valeev
01dab26f64
[java-intentions] Remove external type annotations on ChangeMethodSignatureFromUsageFix
...
Follow-up for IDEA-363866 Remove redundant type annotations on 'Change variable type' fix
GitOrigin-RevId: fc52a66f6b7192ed6c111737619d9fd5dab6817d
2024-11-27 12:52:44 +00:00
Tagir Valeev
00af22705e
[java-intentions] IDEA-363866 Remove redundant type annotations on 'Change variable type' fix
...
GitOrigin-RevId: 07cb03e013552ae9226b00072ca3f7218509d4ba
2024-11-26 14:32:10 +00:00
Alexey Kudravtsev
957ef400ec
highlighting: consider a case when several equivalent injected files could be accumulated in data
...
GitOrigin-RevId: 16d4c218fbd642f18ba6e4e376227f50f46d42bb
2024-11-25 16:30:45 +00:00
Bas Leijdekkers
b4654d3bd0
Java: fix misordered assertEquals() in tests
...
GitOrigin-RevId: f7a40a08cec843ca1a8e23aeb3756aad64ce3e3d
2024-11-21 08:55:07 +00:00
Alexey Kudravtsev
fdf92c211f
IJPL-166101 New failing perf unit tests DaemonRespondToChangesPerformanceTest
...
GitOrigin-RevId: 7a955d8efbbfae7a777f9d22edf8bd14429a43bb
2024-11-19 16:07:25 +00:00
Alexey Kudravtsev
6cb319cbbc
more immutable collections: mark transitive callees of ContainerUtil.filter() as Unmodifiable to help uncover "immutable is passed where mutable is expected" bugs via "data flow problems" inspection, fix some found bugs
...
GitOrigin-RevId: c9b57bd0bd8fadcbaf7cca373c2aefbf562ecd4b
2024-11-18 16:57:58 +00:00
Georgii Ustinov
7cce113eb2
[Java. Intention Actions] Disable extracting field when there are incomplete braces in the class
...
IDEA-361230
GitOrigin-RevId: 97fb3d5a71aa0f1d327f79fcf8789803ab5e5497
2024-11-07 16:48:55 +00:00
