[java-intentions] Remove external type annotations on ChangeMethodSignatureFromUsageFix

Follow-up for IDEA-363866 Remove redundant type annotations on 'Change variable type' fix

GitOrigin-RevId: fc52a66f6b7192ed6c111737619d9fd5dab6817d

java/java-impl/src/com/intellij/codeInsight/daemon/impl/quickfix/ChangeMethodSignatureFromUsageFix.java

@@ -354,8 +354,9 @@ public class ChangeMethodSignatureFromUsageFix implements IntentionAction/*, Hig
           if (PsiPolyExpressionUtil.isPolyExpression(expression)) return null;
           PsiType exprType = CommonJavaRefactoringUtil.getTypeByExpression(expression);
           if (exprType == null || PsiTypes.voidType().equals(exprType)) return null;
-          if (exprType instanceof PsiDisjunctionType) {
-            exprType = ((PsiDisjunctionType)exprType).getLeastUpperBound();
+          exprType = PsiTypesUtil.removeExternalAnnotations(exprType);
+          if (exprType instanceof PsiDisjunctionType disjunctionType) {
+            exprType = disjunctionType.getLeastUpperBound();
           }
           if (!PsiTypesUtil.allTypeParametersResolved(myTargetMethod, exprType)) return null;
           final ParameterInfoImpl changedParameterInfo = ParameterInfoImpl.create(i).withName(parameter.getName()).withType(exprType);

java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/changeMethodSignatureFromUsageModern/afterNoExternalTypeAnnotations.java

@@ -0,0 +1,15 @@
+// "Change 1st parameter of method 'use' from 'Map<String, String>' to 'Map<String, Integer>'" "true" 
+import java.util.Map;
+import java.util.stream.Collectors;
+
+class Test {
+  void testMethodRef(Map<String, Integer> list) {
+    var map = list.entrySet().stream()
+      .filter(e -> !e.getKey().isEmpty())
+      .collect(Collectors.toMap(Map.Entry::getKey, Map.Entry::getValue));
+    use(map);
+  }
+
+  private void use(Map<String, Integer> collect) {
+  }
+}

java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/changeMethodSignatureFromUsageModern/beforeNoExternalTypeAnnotations.java

@@ -0,0 +1,15 @@
+// "Change 1st parameter of method 'use' from 'Map<String, String>' to 'Map<String, Integer>'" "true" 
+import java.util.Map;
+import java.util.stream.Collectors;
+
+class Test {
+  void testMethodRef(Map<String, Integer> list) {
+    var map = list.entrySet().stream()
+      .filter(e -> !e.getKey().isEmpty())
+      .collect(Collectors.toMap(Map.Entry::getKey, Map.Entry::getValue));
+    use(<caret>map);
+  }
+
+  private void use(Map<String, String> collect) {
+  }
+}

java/java-tests/testSrc/com/intellij/codeInsight/daemon/impl/quickfix/ChangeMethodSignatureFromUsageModernTest.java

@@ -2,6 +2,10 @@
 package com.intellij.codeInsight.daemon.impl.quickfix;
 
 import com.intellij.codeInsight.daemon.quickFix.LightQuickFixParameterizedTestCase;
+import com.intellij.testFramework.LightProjectDescriptor;
+import org.jetbrains.annotations.NotNull;
+
+import static com.intellij.testFramework.fixtures.LightJavaCodeInsightFixtureTestCase.JAVA_21_ANNOTATED;
 
 public class ChangeMethodSignatureFromUsageModernTest extends LightQuickFixParameterizedTestCase {
 
@@ -10,4 +14,8 @@ public class ChangeMethodSignatureFromUsageModernTest extends LightQuickFixParam
     return "/codeInsight/daemonCodeAnalyzer/quickFix/changeMethodSignatureFromUsageModern";
   }
 
+  @Override
+  protected @NotNull LightProjectDescriptor getProjectDescriptor() {
+    return JAVA_21_ANNOTATED;
+  }
 }