Commit Graph

409269 Commits

Author SHA1 Message Date
Nikita Kudrin
e85aa76391 [workspace model metrics] IJ-CR-107012 removing dependency on platform implementation of open telemetry
GitOrigin-RevId: fcc52073f5dd623407853a433a189192ee5ea4b3
2023-06-20 09:44:34 +00:00
Nikita Kudrin
1eb5ca1f13 [workspace model metrics] IJ-CR-107012 move some extension function to telemetry api module
GitOrigin-RevId: 6dd3c1abea0974e15207335602fc94edf278a00f
2023-06-20 09:44:29 +00:00
Dmitry Kichinsky
e3e5e32eb8 [maven] convert AddFileAsMavenProjectAction to kotlin
GitOrigin-RevId: c24bd6174279460cbfe337d08689e491ed5075c0
2023-06-20 09:42:51 +00:00
Dmitry Kichinsky
247072af62 Rename .java to .kt
GitOrigin-RevId: d33e430c0626b21fde41a54f53b10dac18275d5d
2023-06-20 09:42:46 +00:00
Toshiaki Kameyama
0cf12c1085 [kotlin] "Redundant 'if' statement": Replace negated 'isEmpty' with 'isNotEmpty' if possible
^KTIJ-25818 Fixed

closes https://github.com/JetBrains/intellij-community/pull/2495

GitOrigin-RevId: 49e278713845152ffd015fd7b1f0474a480a1882
2023-06-20 09:03:25 +00:00
Alexey Belkov
978967b918 [kotlin] UsePropertyAccessSyntaxInspection: fix tests
^KTIJ-25858

GitOrigin-RevId: 4ffeb01a35d2c7f6e94e347445590deb257241f7
2023-06-20 09:03:24 +00:00
Toshiaki Kameyama
fa41b13ac0 [kotlin] "Redundant 'if' statement": don't highlight with floating-point types
^KTIJ-25820 Fixed

closes https://github.com/JetBrains/intellij-community/pull/2493

GitOrigin-RevId: 62c2e9bdc4e1c8726998b61de0869a71e517c50a
2023-06-20 09:03:22 +00:00
Alexey Belkov
295d20c0ce [kotlin] UsePropertyAccessSyntaxInspection: tighten the trivial-accessor check
* Abstract methods are considered non-trivial
* Make it work correctly for compiled Java code where we can decompile to source code

^KTIJ-25858

GitOrigin-RevId: 37d534bd7279b9655f7f64d93c3fee35572b1e88
2023-06-20 09:03:21 +00:00
Alexey Belkov
870cf1ebfe [kotlin] UsePropertyAccessSyntaxInspection: check all declarations for non-trivial body
There are cases when the descriptor resolves to multiple declarations in the IDE,
one of which has no body (ex. interface), and another has a non-trivial accessor body.

In that case we conservatively don't report a warning.

I failed to come up with a test for this, but reproduced it in intellij repo
with intellij->kotlinc->intellij dependency chain.

^KTIJ-25858

GitOrigin-RevId: 71cce8fcd6f252f44ec34d5c0757fe3c911a9d5f
2023-06-20 09:03:19 +00:00
Alexey Belkov
884f24e70b [kotlin] Add tests for obsolete issues
^KTIJ-12363
^KTIJ-21916

GitOrigin-RevId: ae3f1552397d322fbab673f0689602eea5846e86
2023-06-20 09:03:18 +00:00
Maxim.Kolmakov
e33b3c48e2 IDEA-321732 Preload main highlighting passes before file opening
Add performance test

GitOrigin-RevId: 1da701c35e868eb11577c0cfed9960ab6a6b9a17
2023-06-20 08:45:04 +00:00
Sergei Tachenov
142a10f79c IDEA-319986 Fix insertion bug in DefaultTreeLayoutCache
When a node is inserted, its row is often determined by the rows
of the previous sibling and its visible children.

However, when there are multiple insertions, then those
siblings and their children may have outdated rows, as
updating is postponed until after all insertions are done.

This led to row inconsistencies. Fix by updating them
manually in case of multiple insertions. Increment
the minimum affected index accordingly to avoid updating
them later for no reason.

GitOrigin-RevId: 5c92bc4b6db9ab3f2494256f0bcecd6fc8b317a1
2023-06-20 07:34:45 +00:00
Sergei Tachenov
123e0da568 IDEA-319986 Refactor DefaultTreeLayoutCache.Node.createChildAt
Remove multiple returns, add the child only after it's fully initialized,
including its row index.

GitOrigin-RevId: 8d3114b8817d0a0c6bf79b8c2a161c4be1870aa5
2023-06-20 07:34:37 +00:00
Sergei Tachenov
14c0342e68 IDEA-319986 Improve DefaultTreeLayoutCache row checking
Instead of just checking that every node is at the row it claims to be at,
check that the order actually makes sense: that the visible nodes occupy
all rows in the preorder traversal order.

GitOrigin-RevId: 67b0e568ddb3d61c3f9f49c88ab8023cf5e5296c
2023-06-20 07:34:29 +00:00
Sergei Tachenov
6d9ac59f74 IDEA-319986 Check invariants before calling auto expand handler
The handler may call other mutating operation, and it'll be harder
to understand which of them broke the invariants.

GitOrigin-RevId: 4a56d55ecdabf67e047a0ccfa6dda9bbe14b6ef3
2023-06-20 07:34:21 +00:00
Sergei Tachenov
b2d4ad99d1 Rename FindInProjectState to FindInProjectScopeService
To make it more consistent with its state name: FindInProjectScope,
and make it more obvious that it's a service.

GitOrigin-RevId: 2cca18b055d12e9ffa09716ceb9c50f71e35aa97
2023-06-20 07:34:13 +00:00
Sergei Tachenov
781f804748 IDEA-319986 Fix debug location constructor in DefaultTreeLayoutCache
Move formatting to toString(), as the whole point of passing a vararg there
is to avoid formatting when debugging is off.

GitOrigin-RevId: 1e2e73b25c2f1152db0062ca9db1731c3793c15f
2023-06-20 07:34:05 +00:00
Sergei Tachenov
c5797cc28a IDEA-319986 Improve exception messages in DefaultTreeLayoutCache
Since something like IOOBE is rather useless without any context,
we add the arguments of the call initiated the change and the old/new
sizes of the row collection, so that we at least have some idea
what exact operation caused the change and whether it was the only
change.

GitOrigin-RevId: df997cac319461c5ac8e7385b3dd3b52af3a8145
2023-06-20 07:33:57 +00:00
Sergei Tachenov
960670de1c IDEA-319986 Improve invariant violation messages in DefaultTreeLayoutCache
GitOrigin-RevId: 320f3d4da4eaf73aa9220af3a51e0992c19d3345
2023-06-20 07:33:49 +00:00
Sergei Tachenov
10dc2b1f0a IDEA-319986 Fix indices formatting in DefaultTreeLayoutCache invariants
It was calling toString() on an IntArray, which is useless for debugging,
as it formats into something like [I@2c093ee8.
Converted to list to see the actual indices.

GitOrigin-RevId: 4157d840b6163746788d48e615d9d5b827c30637
2023-06-20 07:33:41 +00:00
Sergei Tachenov
fcce843653 IDEA-322725 Create RenderingHelper.SHRINK_LONG_SELECTION key
If this property is set, then the selection is not extended even for long nodes.

This is currently needed to a customized tree in the writerside-stardust project.

GitOrigin-RevId: d17529b893f066c0a987d28f05bf51071d815bfd
2023-06-20 07:33:33 +00:00
Nebojsa.Vuksic
b1dd70e949 Merge branch 'master' of ssh://git.jetbrains.team/intellij
GitOrigin-RevId: ffc1f7394e613003bd80754d2ed853019aba3c25
2023-06-20 07:16:58 +00:00
Nebojsa.Vuksic
bacd217571 Safe-Push into master
GitOrigin-RevId: 2e2433d4e3cad3dab7b11609b1a7c866e93bc7ab
2023-06-20 07:16:26 +00:00
Nebojsa.Vuksic
728807b00b Safe-Push into master
GitOrigin-RevId: 06a8e87b8a51bc6dcab9c801f7854daec532969a
2023-06-20 07:16:18 +00:00
Nikolay Chashnikov
e7ab23b9bb Revert "json: improve JSON Schema caching (IDEA-251399)"
This reverts commit 74ae6ae256bb618878c2a223f6a0e1e2f64f8217 which caused many tests to hang in com.jetbrains.jsonSchema.impl.MyCompletableFuture.get.

GitOrigin-RevId: aede1d5dba4256a174c9fd036f619e264a442a85
2023-06-20 07:08:12 +00:00
Konstantin Aleev
2671cb264e [service] cleanup: remove redundant type cast
GitOrigin-RevId: a3ad9f444926dcc5380f7bcfc543a9f9908d2c3c
2023-06-20 06:04:22 +00:00
Daniil Kalinin
157b23ce53 PY-33261 Inlay parameter hints for Python method and function calls
Merge-request: IJ-MR-108471
Merged-by: Daniil Kalinin <Daniil.Kalinin@jetbrains.com>

GitOrigin-RevId: 1d9451020a755c0aaf57c12b16829f8b31291e5d
2023-06-20 05:27:45 +00:00
Konstantin Nisht
a61dc8fee2 [platform] Fix flaky test on cancellation propagation
GitOrigin-RevId: b8c27997773937ce141fbf1b3b2481ba2303690d
2023-06-20 05:18:37 +00:00
Konstantin Nisht
b24e66ef2e [platform] Enable cancellation propagation
This option enables tracking of the tasks, spawned under `blockingContextScope`. Since there are no usages of this function yet, this change is effectively no-op, but it enables `blockingContextScope` for the usage

GitOrigin-RevId: cf59fd9bb3ed37f7ef37adbe5bc83bee7b322748
2023-06-20 05:18:34 +00:00
Konstantin Nisht
ded2336cfa [warmup] Allow specifying unregistered keys in configuration
In tests, the necessary `plugin.xml` with registered implementations of an extension point is sometimes not available. This fix allows to describe any key in environment configuration, thus circumventing this problem

GitOrigin-RevId: 0c97b1503b9d69385591b3410128bb46ae5d95cb
2023-06-20 05:18:31 +00:00
Daniil Kalinin
eb2a834e65 PY-30190 Report unresolved class attributes in decorated classes
Previously, unresolved class attributes were not reported for the decorated classes because of potential dynamical attributes (see PY-7173). This commit enables this warning again because false-negative unresolved reference warning is much more common and distracting than the case with dynamic attributes

Merge-request: IJ-MR-105254
Merged-by: Daniil Kalinin <Daniil.Kalinin@jetbrains.com>

GitOrigin-RevId: 67d1ab3fe1d5a140836d49f8ef6a65cf01873456
2023-06-20 04:39:38 +00:00
Dmitriy Smirnov
4d60a1ad40 [git] IDEA-257690 Use dash instead of underscore in the branch name conversion
Make it configurable via Advanced settings.

Remove deduplication logic IDEA-258145
Drop all symbols except space

GitOrigin-RevId: 9f113d9567c2647bddfe71ab04f1f0f8c6d1bee2
2023-06-20 04:38:48 +00:00
Ivan.Yarkov
d90ae2049a RIDER-4128 support navigation format 'File.cs:line N' in Search Everywhere Files tab
GitOrigin-RevId: d9904e82586c1c5c6b0e2988434d521e7accc631
2023-06-20 04:38:39 +00:00
Maksim Zuev
3529106eb9 [debugger] IDEA-322207 Fix line breakpoint with anonymous function
Filter top level name as a candidate for anonymous function class name when it is used as a lambda parameter

Merge-request: IJ-MR-108544
Merged-by: Maksim Zuev <Maksim.Zuev@jetbrains.com>

GitOrigin-RevId: 12019da7288cb4273cd95ce8a847a0cc6712a848
2023-06-20 04:30:12 +00:00
Gleb Marin
8b5f8abc65 Remove limitation on internal users
GitOrigin-RevId: 6215613e32c02d3297ad0394dd5f01e8a14584e3
2023-06-20 04:28:08 +00:00
Aleksei Kniazev
2180aa6230 [python] support python dependencies in pyproject.toml (PY-59844)
- completion for package names in `dependencies` and `install-requires`
- completion for build-backends
- if a package is not installed, provide a quickfix to install it / run `pip install -e .`

GitOrigin-RevId: cad88e4058a45f6db717b8da8fd7f6c456008998
2023-06-20 04:18:25 +00:00
Pavel Gromov
03a517b29d [collab] Fix a reviewer status border
GitOrigin-RevId: 3ae741a23ee258dc0c5ad40588cbe184079c0079
2023-06-20 04:15:01 +00:00
Nebojsa.Vuksic
a983d2028c Merge remote-tracking branch 'origin/master'
GitOrigin-RevId: 5dd616174258280e8e4bf9c9e30d645f50328f86
2023-06-20 03:46:51 +00:00
TeamCity
463abfa4aa product version minor updated to 3 for PyCharm
GitOrigin-RevId: 7c2be90d88119ec5a1e75c37fc8c1f7d68b0ef56
2023-06-20 03:38:49 +00:00
TeamCity
a62031011f product version minor updated to 3 for IDEA
GitOrigin-RevId: 41c49256672af67011e50244d0fa769efd16267b
2023-06-20 03:38:46 +00:00
TeamCity
97e825e37b platform: base build number set to 233
GitOrigin-RevId: 0c4469c425adecf56ca12c9adb83b4eea8d8f10e
2023-06-20 03:38:30 +00:00
Ivan Semenov
a75a1ce85c [gitlab] move action
GitOrigin-RevId: 3fe4f46bd7675b5d713a97acaf52ab4e7c888810
2023-06-20 02:59:05 +00:00
Ivan Semenov
9e14922b9c [gitlab] add main menu item to open merge requests
GitOrigin-RevId: ff143841347490fb46a779971958cfdc60cf0403
2023-06-20 02:59:04 +00:00
Ivan Semenov
1bcacf59f2 [github] make PR toolwindow controller public
GitOrigin-RevId: e05247ca42dd15d3bdf0485ef9d02fe80dcf8d27
2023-06-20 02:59:02 +00:00
Ivan Semenov
1ec4bf6edb [gitlab] allow omitting server protocol during login
GitOrigin-RevId: 7a71e55b5fdd9e3a901ce9de95ca6d2147c73794
2023-06-20 02:59:01 +00:00
Ivan Semenov
73c5aaf80f [gitlab] check server version on login and in settings
IDEA-321265 Fixed

GitOrigin-RevId: a16b46b55fbdd0b347e9119a472896bed6e57fb6
2023-06-20 02:59:00 +00:00
Vladimir Krivosheev
bd01e2c058 vcs log(sqlite storage) - get rid of calling getCommitId on getRefIndex after insert/update, use statement pool
GitOrigin-RevId: de7c24b7a92415f02c98c1f286ca635e0ba205ad
2023-06-20 02:58:06 +00:00
Vladimir Krivosheev
4c5d9493fd vcs log(sqlite storage) - get rid of calling getPathIdOrFail after insert
GitOrigin-RevId: a03115d969ccdbd274375840a11fa65d11e547ba
2023-06-20 02:58:05 +00:00
Vladimir Krivosheev
54d21be0f5 vcs log(sqlite storage) - get rid of calling getCommitIndex after insert
GitOrigin-RevId: 0d349cd81045e3aff328554bb408977dae24acdc
2023-06-20 02:58:05 +00:00
Vladimir Krivosheev
6a2d369257 vcs log(sqlite storage) - compactCommits as one transaction
GitOrigin-RevId: dd24db36b5161cd7aa384aedbd8657a71a204639
2023-06-20 02:58:04 +00:00