Commit Graph

420033 Commits

Author SHA1 Message Date
Vladislav.Yaroshchuk
ccd91ed6be RepositoryLibraryUtilsTest: properly reset path macros and local maven repository path before and after test
GitOrigin-RevId: 8e7430d1597912af3b77749c2a2bf561a8baae75
2023-10-05 11:24:27 +00:00
Alexey Belkov
0c66c4c873 [kotlin] J2K: don't convert function with inapplicable-target annotation to getter/setter
^KTIJ-18777 Fixed

GitOrigin-RevId: bffa52cc2720946ecb64ebd74429501eaf5fbce4
2023-10-05 11:10:40 +00:00
Dima Golovkov
cd56640c30 Add report icons for both UIs
GitOrigin-RevId: 6b3f145013a48943440dc657ed535e53eeb242ec
2023-10-05 11:02:44 +00:00
Ruslan Cheremin
a5c7271d0b [core][tests] Use .closeAndClean() in unit-tests instead of just .close()
+ .closeAndClean() unmaps memory-mapped regions, if any, hence more reliable on Windows. Without unmapping tests fail because TemporaryDirectory can't remove the folder with mapped files in it

GitOrigin-RevId: f1e241a87102d1d9adbf94451ee0277d0cbe8a03
2023-10-05 10:43:17 +00:00
Maxim.Kolmakov
6340d5ed29 Don't invoke setDone on rejected callback
GitOrigin-RevId: c48b66ff0172429dcd03b7d848384e094890049f
2023-10-05 09:25:34 +00:00
Andrey Cherkasov
78d15b5cdf [kotlin k2] The "Introduce Variable" refactoring: fix "java.lang.AssertionError: New body is not found: FUN"
^KTIJ-26527
IJ-CR-113137

GitOrigin-RevId: f330bb93fb15368acf81b809fade5ce18f17a3ed
2023-10-05 08:58:36 +00:00
Kirill.Krylov
0c1f99dc08 [inline-completion] ML-1310 merge reset with dispose for InlineCompletionBlock. Remove duplicated disposable registry
GitOrigin-RevId: c6eaf97fa185ffc0da812682e60ca1154193a637
2023-10-05 01:21:36 +00:00
Sergey Simonchik
bdb6511fbb terminal: update jediterm to 3.26 (IDEA-230112)
GitOrigin-RevId: 0fd36a83713db4189c087bb5aa483c302b3006b8
2023-10-05 00:50:20 +00:00
Ruslan Cheremin
5b4205c9ef [core][cleanup] MMappedFileStorage fail-or-log if unmapping unavailable
+ `-Didea.fs.fail-if-unmap-failed=true` (default) fails if unmapping is called, but unavailable. Set false if just WARN (throttled) in logs is enough
+ adjusted class comments, remove outdated TODOs

GitOrigin-RevId: c7f41205ff27bf9690273ed9d613f9cb798fec98
2023-10-04 23:13:58 +00:00
Ruslan Cheremin
3926690341 [core] MMappedFileStorage.close(unmap) method
+ It is risky to provide unmap(), but seems like we can't reliably work on Windows without it

GitOrigin-RevId: 652600312cb695d51551221b3364698e8175b2e0
2023-10-04 23:13:58 +00:00
Ruslan Cheremin
836f6372af [core] FileUtilRt.doDelete() try System.gc() on windows if AccessDeniedException
+ `-Didea.fs.try-gc-if-file-delete-fails=true` (default: false) On Windows try call System.gc() and .runFinalization() if file delete still throws AccessDenied after several attempts

GitOrigin-RevId: 16993fdf399a0c9cc264986ef6e591414982427c
2023-10-04 23:13:58 +00:00
Daniil Ovchinnikov
bf9e443142 IJPL-160 don't cancel the scope which is passed to the constructor of EditorNotificationsImpl
GitOrigin-RevId: 291d7f34d1316565c5907b7bd740be44e08306e5
2023-10-04 22:39:33 +00:00
Roman Ivanov
67bbc0bf9a [fus] CodeVisionFusEditorListener: check project disposal in read action, use coroutines
GitOrigin-RevId: 5a74809ce0430f432cf8afeb3d01f1595dc264d6
2023-10-04 22:33:33 +00:00
Roman Ivanov
acddb246e8 get back signature check for instance main for kotlin
GitOrigin-RevId: 85ab38a64554eb53d4bf85bb702d32d98e9e90f0
2023-10-04 22:33:31 +00:00
Roman Ivanov
f7563d24a1 ensure that main method has proper signature IDEA-333318
GitOrigin-RevId: f324e646e922af24a2382073770ca195af52dc70
2023-10-04 22:33:30 +00:00
Roman Ivanov
7770d195fc check that main method has name "main"
GitOrigin-RevId: 3c49ec2ed2bbbc0cfce37cb3e399ab83cab93f7e
2023-10-04 22:33:29 +00:00
Roman Ivanov
f6587e1556 Revert "[code vision] return null in DaemonBoundCodeVisionProvider if the provider is not relevant to the file"
This reverts commit cb91adaa196588713507798c3cd27b11c9eb15fe.
IDEA-333332

GitOrigin-RevId: 4c7a8603fab6f6a3dd399b88f5bf0f785a1c6aac
2023-10-04 22:33:28 +00:00
Roman Ivanov
0a2042eedc [inlays] delete unused code in AnnotationsPreloader
GitOrigin-RevId: d6b8e9e4a6eb8555cab91f2d2ffb532e80cc8f0d
2023-10-04 22:33:26 +00:00
Roman Ivanov
1d5de19349 [inlays] remove old implementation of vcs code author hints
GitOrigin-RevId: 29f9b51b663c5f330ba743ba7c6053dbc23dbe6a
2023-10-04 22:33:25 +00:00
Roman Ivanov
eba6e0d551 [java, inspection] make global unused symbol inspection not report main methods for unnamed classes IDEA-333152
GitOrigin-RevId: 597ef591bebf0ee6968e08a05dd989aadc8bdd53
2023-10-04 22:33:23 +00:00
Roman Ivanov
b56e8cf4d9 [java, inspection] make unused symbol inspection not report main methods for unnamed classes IDEA-333152
GitOrigin-RevId: 1a1b41037a7bc28fc9a20620a182ca49ef789951
2023-10-04 22:33:22 +00:00
Roman Ivanov
258f4afc9d [suggested refactoring] avoid assert when import range is empty
GitOrigin-RevId: ab9e9634c924ae2d07628046710f59b41a26dfc6
2023-10-04 22:33:20 +00:00
Daniil Ovchinnikov
8dff35d866 [test-framework] dispose @TestDisposable in after-each to mirror extension registration order
GitOrigin-RevId: 795fb005df1220308893e042c7b5e0072357cdd2
2023-10-04 22:28:31 +00:00
Daniil Ovchinnikov
01dc640dbf clean up DocumentationComponent, add docs, mark it @Internal
GitOrigin-RevId: 2594a8195de4312650093be1736a880752173915
2023-10-04 21:04:53 +00:00
Roman Shevchenko
9a8136699c Cleanup (minor optimization; formatting)
GitOrigin-RevId: 23c7a479b5ff3d6bb0ae604ae6dbf891a9de1c4e
2023-10-04 20:37:32 +00:00
Roman Shevchenko
5cd46d4c2d [ui] simpler creation of HTML components in the IDE errors dialog
(hopefully fixes IDEA-332419)

GitOrigin-RevId: ef842a636eb6d6d6ee9ab7765fb4af84d549be35
2023-10-04 20:37:31 +00:00
Egor Ushakov
32178f6a6e IDEA-334090 Do not sync XBreakpointManagerImpl on global RW locks
Merge-request: IJ-MR-115088
Merged-by: Egor Ushakov <Egor.Ushakov@jetbrains.com>

GitOrigin-RevId: d081ae2ad13cb9afe17844e4407c0c68187e32db
2023-10-04 20:30:52 +00:00
Alexander Doroshko
1282b32ba0 FormattingServiceUtil.findService(): faster checks first
GitOrigin-RevId: 01af72e726ace4a4dfecd0c04735f526f3abf188
2023-10-04 20:14:31 +00:00
Pavel Karateev
ddc7ef51fd [python] PCQA-279 Add Python 3.12.0 to skeleton generation
GitOrigin-RevId: 3ec5b106bd92a7ffc68d3d5f37ea490e948ed0ea
2023-10-04 19:45:16 +00:00
Kirill Glazyrin
20f3fb9d3e Fix RIDER-95155
(cherry picked from commit 189c475338c96181464467844e0353b6f818a97f)

NET-MR-12114

GitOrigin-RevId: 5e84b2932f323225cda89a17a26fc78d1eb11582
2023-10-04 19:42:54 +00:00
Dmitry Avdeev
cf4c6c35d7 IDEA-325943 Editor gutter: always show 1 column of icons
return RIGHT_FREE_PAINTERS_AREA back in place to be used via setRightFreePaintersAreaWidth

GitOrigin-RevId: fba3ce1f48e79af3bd870b904b8a100fa4c5d184
2023-10-04 19:33:10 +00:00
Elena Shaverdova
e8acef8bdd IDEA-334077 Remove indexing.use.indexable.files.index key. Deprecate useless IndexableFilesContributor extension point
GitOrigin-RevId: 65152f9129b477f7b601babab170bd8202cb1aa5
2023-10-04 19:26:54 +00:00
Elena Shaverdova
fd716888fa IDEA-334077 Remove indexing.use.indexable.files.index key. Removed usages from EntityIndexingServiceImpl.java
GitOrigin-RevId: 83a71c6ac872be9f5ca981fb4553ab7a4aaccead
2023-10-04 19:26:51 +00:00
Elena Shaverdova
fafd267895 IDEA-334077 Remove indexing.use.indexable.files.index key. Removed usages from CustomEntitiesCausingReindexTracker
GitOrigin-RevId: be6943030738674d6c34f758cdbc50f178911da3
2023-10-04 19:26:47 +00:00
Elena Shaverdova
b67126211e IDEA-334077 Remove indexing.use.indexable.files.index key. Removed trivial usages of IndexableFilesIndex.isEnabled
GitOrigin-RevId: 53da28d5f29c3072c4ad6726d95a3bf5f1d420e3
2023-10-04 19:26:44 +00:00
Elena Shaverdova
fb121ffd7f Get rid of idea.test.files.allowed.iterators property which is not used anymore
GitOrigin-RevId: 68ec3cbada3807e962201583577c52adb9f83c86
2023-10-04 19:26:41 +00:00
Ruslan Cheremin
a696c5e991 [vfs][refactoring] checkNotDisposed() on .addCloseable()
+ otherwise closeable could be added after VFS disposed -> will never be called, without any notice

GitOrigin-RevId: 15d66f101c6307b35e9781bf86e4cf80c935e954
2023-10-04 19:14:22 +00:00
Ruslan Cheremin
0e9d844a49 [vfs][refactoring] close VFS by ShutDownTracker in tests
+ because otherwise we don't close VFS at all, since we don't regularly .dispose() services in test
+ but we use a regular, not eager ('cache') task priority to close VFS in tests, because otherwise there will be too much noise of AlreadyDisposedExceptions

GitOrigin-RevId: 5c6a06bab3821622f2f310d29c8ef99f9dbef63a
2023-10-04 19:14:22 +00:00
Ruslan Cheremin
f3046b4dfa [vfs][cleanup] comments/log message improved, outdated TODO removed
GitOrigin-RevId: 5c7fc4f3142a1f1b12d93446a67d5dffb6d32672
2023-10-04 19:14:22 +00:00
Alexey Merkulov
7f4dce1e90 IDEA-333982 Rework event processing for showing inlay Run-To-Cursor toolbar
GitOrigin-RevId: 3f8bbfe713f0876028aa4dd3a0a92cb34fb84f1b
2023-10-04 19:14:05 +00:00
Petr Surkov
7c3c47f5d4 [inline-completion] Launch providers on cpu-optimized Default dispatcher
GitOrigin-RevId: 0be94a72f167725a5edf36eaa24c14069926adbc
2023-10-04 19:10:57 +00:00
Vladimir Parfinenko
16c5db4644 [debugger] new UI for inline breakpoints, IDEA-324621
* fix column number calculation, IDEA-333642
* inline Registry.is() calls to be able to call them in any module

^IDEA-333642 fixed

GitOrigin-RevId: 449ae44601da3cba3d72c314b0d48557eb521baa
2023-10-04 19:06:23 +00:00
Valentina Kiryushkina
66c0749b9e EDU-6277 Learn tab on Welcome screen shows only Help and Resources in RustRover and PhPStorm
GitOrigin-RevId: baea67496387f5f787cd79710bcde2d7e328b871
2023-10-04 18:55:28 +00:00
Evgeny Abramov
8b53a38bee (IDEA-332279) ML in SE: use single RA to find search results and process them
The problem with deadlock is still resolved since we wait on condition outside the RA. However, the returned search candidates can be outdated before processing, so it's better to filter and process them under a single read lock. I also add read access assertion in the place where we need it.

GitOrigin-RevId: 64f6c4ddcd35f4db1819d88f00788828591da170
2023-10-04 18:39:27 +00:00
Evgeny Abramov
38670ae485 (IDEA-332279) ML in SE: do not explicitly use read lock in SearchEverywhereConcurrentElementsFetcher
Consumer might not need to run under read lock at all. Besides, consumer knows better how to acquire it only where needed. So I moved the read lock to consumer.

GitOrigin-RevId: 68616193f57288191beabc2d5619a57fb869cdc3
2023-10-04 18:39:24 +00:00
Evgeny Abramov
f8ed76afe3 (IDEA-332279) ML in SE: remove possible deadlock when searching for PSI elements
The deadlock was caused by waiting on condition variable in a blocking read action. Another thread, which sends a signal to this condition variable, could possibly execute write action before signaling. That's why write action and read action could block each other.

GitOrigin-RevId: 6e09659f672383472af7151e7c51495037a95f05
2023-10-04 18:39:21 +00:00
Dmitry Avdeev
12b59a527c diagnostics for using PsiElementListCellRenderer
GitOrigin-RevId: 2a8882ae8c65fae620f506750446081d88d96879
2023-10-04 18:32:25 +00:00
Alexey Belkov
a0c659e5cf [kotlin] J2K: Ignore nullability when checking compatibility of getter/setter type
^KTIJ-15214 Fixed

GitOrigin-RevId: 1c51dcb4b30ab4df719cfef33ad2f97c69e56cdf
2023-10-04 18:32:07 +00:00
Alexey Belkov
e9d2d9a86b [kotlin] J2K: ConvertGettersAndSettersToPropertyProcessing: clarify test
Now, if the setter in this test is merged into a property,
the test will fail with a "type mismatch" error for `takesString` function.

GitOrigin-RevId: 1449f3e34994b17f1c6b7235d4f0758213b033d9
2023-10-04 18:32:04 +00:00
Aleksey Pivovarov
71b7b60880 ui: add toString for JViewport border wrapper
GitOrigin-RevId: eab1d1c6daf3a8915d885a33a5653edaffa0c63b
2023-10-04 18:31:41 +00:00