Commit Graph
276870 Commits
Author SHA1 Message Date
Nikita Eshkeev cb47b00f60 [codeInsight] IDEA-240288 Inspection for StringBuilder.toString().substring()
This patch alters the `getRedundantStringBuilderToStringProblem` method with more sophisticated algorithm to detect unnecessary freestanding `StringBuilder#toString` calls. If the call is a part of a polyadic expression it checks if there is at least one string operand (either a constant literal or a local variable or a constant variable or a method call) and based on that information it detects redundant `StringBuilder#toString` calls.

Signed-off-by: Nikita Eshkeev <nikita.eshkeev@jetbrains.com>

GitOrigin-RevId: e09ea8b8829ad9e28e8ff1bcfad34cf6b191aa6b
2020-05-12 00:59:21 +00:00
Alexander Zolotov 264b599e59 Support expanding prompting macro not from EDT (GO-9289)
GitOrigin-RevId: fdded0455fbeb18873b49c90e2084b6fc2ecf487
2020-05-11 22:29:41 +00:00
Dmitriy Smirnov 11fb1df68f [vcs] Use correct path to settings in hints
Add missing space
Follow-up 9e63aab47fc5326e626ca6d7792ad8527032a19c

GitOrigin-RevId: 63fb565c3815aa488bb843df92a1f27925024d86
2020-05-11 22:29:41 +00:00
Dmitriy Smirnov 4c45e03201 [vcs] Treat too high idea.max.vcs.loaded.size.kb values as maximum allowed size
Handle overflow in the correct place

Follow up 552c947378e984f452a73323c73181dcd9791f2b

GitOrigin-RevId: 688c0dd16c0635c33b7f5c57697e44500175998c
2020-05-11 22:29:41 +00:00
Konstantin Bulenkov 328972643b typo at javadoc example of AnActionEvent#getRequiredData
https://github.com/JetBrains/intellij-community/pull/1320

GitOrigin-RevId: 4772696892e4ab88cc4464eb4700ce5032805bb1
2020-05-11 22:00:44 +00:00
Konstantin Bulenkov 6273a702fd color key for the border around highlighted items when searching in the Settings dialog
https://github.com/JetBrains/intellij-community/pull/1351

GitOrigin-RevId: dc4f8fded65ef6aebc6f879e731832fc4ccafb32
2020-05-11 22:00:44 +00:00
alexey.afanasiev d55dd5a07c Fix hanging InspectionIntegrationStressTest
GitOrigin-RevId: e5e7e79897e3416ef715316ef604049c01a48d36
2020-05-11 20:58:18 +00:00
Anna Kozlova c879ed4e4a java redundant cast: preserve multiple type casts around functional interface when if expected type is the same as cast
isAssignable check may fail otherwise

GitOrigin-RevId: d02c9d50645a2bbb0e957f077a4a66813c94afd6
2020-05-11 20:09:58 +00:00
Anna Kozlova b088cbd746 NPE
GitOrigin-RevId: cac6587190e100352e1302cfda0d3f09903724d6
2020-05-11 20:09:58 +00:00
Anna Kozlova 623f6f42c6 javafx: hide create actions for projects without javafx available (IDEA-240037)
it's still possible to create java class and extends it from Application as well as custom .fxml file manually

GitOrigin-RevId: 0158db39ab175c1bc849d3d9843f7c961c568586
2020-05-11 19:48:37 +00:00
Dmitry.Krasilschikov b266bd501c IJP-778 Reader mode: correct typos
GitOrigin-RevId: ff33318d975fa107c33770da5bf71e02034c9fac
2020-05-11 19:04:20 +00:00
Anna Kozlova 26c58f716c testng: show relative path in configuration name (IDEA-239752)
GitOrigin-RevId: c1707aeb8ed89fb78e3f56b23a62914338756fd8
2020-05-11 18:45:55 +00:00
Svetlana.Zemlyanskaya 5a117f19ef LAB-29: add tests for features encoding
GitOrigin-RevId: 994b951ddef3878c333933b1efbd8d80d1478da4
2020-05-11 18:45:55 +00:00
Julia Beliaeva f6b43b4c5a [git-index] fix revert process text
GitOrigin-RevId: beeaed41f85e2d9c02c1493b29e20539a83d2ffe
2020-05-11 18:39:53 +00:00
Julia Beliaeva e4f97eea12 [vcs-log] plugin listener to dispose and create log on plugin changes
This allows to recreate log once when a plugin is loaded or unloaded, rather than doing it for every extension point. This also gives disposing process a better chance to be finished before classloader checks, as it asynchronous.

GitOrigin-RevId: 549b6a9b60607383543f3c46234812faf8c3c7a8
2020-05-11 18:39:53 +00:00
Julia Beliaeva 69b851e2d9 [git-index] switch commit message when amend checkbox is toggled
Load last commit message when amend checkbox is checked, and return to the previously entered message when it is unchecked (unless amend message was manually edited).

GitOrigin-RevId: 6bb61165b3f48e477154a590511582f9e335ba32
2020-05-11 17:53:34 +00:00
Julia Beliaeva f8793e8195 [commit] i18n for AmendCommitHandlerImpl
GitOrigin-RevId: cae097c2960c56ab89fb765560339b1a9d1eed2a
2020-05-11 17:53:34 +00:00
Roman Shevchenko d7f6784cfb [project] OpenJDK issue navigation pattern
GitOrigin-RevId: 4bd9117fafab3b45e09c1f3d6dec6d73103ecb11
2020-05-11 17:42:43 +00:00
Dmitry.Krasilschikov 4ecdbad888 IJP-778 Reader mode: turn off by default
GitOrigin-RevId: fa7e9933334dfad594a0861416638c6a04e05628
2020-05-11 17:03:45 +00:00
Dmitry.Krasilschikov 79c84d6834 IJP-778 Reader mode: A special mode for code browsing and exploring
GitOrigin-RevId: b9d4370c6ff8bf2485f863cde83c55c9f3c9a318
2020-05-11 17:03:45 +00:00
Konstantin.Nisht 376b4ffb49 [groovy] Avoid resolving untyped parameters in the light version of extended inference
GitOrigin-RevId: 325d70ba8ad2c8dc026888395c9becaac97627f9
2020-05-11 16:53:16 +00:00
Konstantin.Nisht e7e42a5f65 [groovy] Stop processing operators in the light version of extended inference
GitOrigin-RevId: 625f4e688555e12d492d0301db7fe4e4100b6ce9
2020-05-11 16:53:16 +00:00
Konstantin.Nisht 71c9bf7d9b [groovy] Don't process return types in extended inference when it was invoked in lite mode
GitOrigin-RevId: a3cf9f2580be272db2f249dddf4eb3b2d418b705
2020-05-11 16:53:16 +00:00
Daniil Tsaryov f6fecbf935 vcs: i18n: fix quotation in Hg bundle
GitOrigin-RevId: d332c7f2331c8f494b1e8ba0899c5686db9d8ae1
2020-05-11 16:42:47 +00:00
Evgeniy.Stepanov 56c7ea5ada Modules in jar duplication diagnostic for thin client
GitOrigin-RevId: 4dfec3fef52b05cbb45a289ddbcd5e45ea61e112
2020-05-11 15:31:27 +00:00
Evgeniy.Stepanov bf2f759b68 Temporary return removed api, important for Rider
GitOrigin-RevId: b01207c362b629b84ddc339f701380b48bc48614
2020-05-11 15:08:57 +00:00
Piotr Tomiak 3b39c5bfd5 WEB-45429 SVG: Attributes are shown as invalid when using svg: prefix
GitOrigin-RevId: 6d7f21dbea06d565cfc78d93f5438038d5ad46d6
2020-05-11 14:45:10 +00:00
Vasily Romanikhin cbf064aacd CPP-19906: Remote host sync silently hangs: recursive symlinks in header paths.
GitOrigin-RevId: 3a59d2f6255fad010c3c0f16c72d0fa676788725
2020-05-11 13:52:49 +00:00
Anton Makeev cad68898e2 build-in server: ability to disable it via VM options
GitOrigin-RevId: e9e9668c863ae9742dbb4d8ff89f04e80289c653
2020-05-11 13:49:16 +00:00
Daniil Ovchinnikov 1a3c2669bc [groovy] IDEA-209501 remove pointless assertion of bundled jar name
GitOrigin-RevId: 5be31ddb2f6ad58dbe8c5ecdb8080456d01550fd
2020-05-11 13:12:29 +00:00
Yann Cébron e3bd504aba [devkit] <idea-plugin@require-restart> support
GitOrigin-RevId: 5813e6f5844447046f86de87a668790de7898023
2020-05-11 12:42:23 +00:00
Konstantin Kolosovsky 59c0c9c8f4 svn: Fix tests - update vcs mappings after configuring externals
GitOrigin-RevId: fb5cddf5e94f2ab0abdb578c60c5a13eef1f76cb
2020-05-11 12:00:59 +00:00
Dmitry Jemerov a81cf72dac Add possibility to explicitly mark plugin as requiring restart on load/unload
GitOrigin-RevId: 0cd92fdd5e3ff329c71403eb9a30a64dcb736cc2
2020-05-11 11:27:25 +00:00
Konstantin Bulenkov cd6e317dc8 show Bundled JRE by default
GitOrigin-RevId: 28954713e470cd02cddc6b83be125e671c41fb9b
2020-05-11 10:25:51 +00:00
Dmitry Jemerov a2d90da576 @NotNull (IDEA-CR-62440)
GitOrigin-RevId: b59a5884955b2d8f1ee57d7643c13e0ad608f39a
2020-05-11 10:20:26 +00:00
Dmitry Jemerov 174d436214 Add registry key to control classloader GC wait time on plugin unload
GitOrigin-RevId: c7828a28179898ba359643b334c1288cf47d746a
2020-05-11 10:20:26 +00:00
Ilia Shulgin ac2d05a252 [jps-caches] Check if file exists before move
GitOrigin-RevId: 6b3ab9795433fcee49513e6db793c34c0b76a7c3
2020-05-11 09:56:04 +00:00
Anna Kozlova dbde077457 java redundant cast: property test
GitOrigin-RevId: 6a02848ab0839c4a2cb3a7b0ccc8d153ef60e7d3
2020-05-11 08:33:17 +00:00
Anna Kozlova e218e80eeb NPE
GitOrigin-RevId: c000a7edd17ac10aad022333647b5cc183531b06
2020-05-11 08:33:17 +00:00
Anna Kozlova 52b11c119b java redundant cast: cleanup
GitOrigin-RevId: 0e7b9f52d326a1e2445282c1a06a1bd1bba2b40d
2020-05-11 08:33:17 +00:00
Anna Kozlova 7f02ca14a9 java redundant cast: check conditional expression as call argument inplace
GitOrigin-RevId: ee7fa6ef4cac4e39e9dad97c7d5ace983bc81044
2020-05-11 08:33:17 +00:00
Anna Kozlova e3bc888dc7 java redundant cast: cleanup checks for calls
GitOrigin-RevId: 2d999bc7356856ef7d2fea45f793d69f401f7256
2020-05-11 08:33:17 +00:00
Anna Kozlova 2d7494d72a java redundant cast: unconditionally skip casts with varargs
GitOrigin-RevId: 01a0c7b240679155fab2e93e6e60db08000b9233
2020-05-11 08:33:17 +00:00
Anna Kozlova 7107a6a626 java redundant cast: normalize captured wildcard contexts (IDEA-162080)
GitOrigin-RevId: 7265302824d034690900bb1a58a90c4021da8f67
2020-05-11 08:33:17 +00:00
Anna Kozlova 1bc4cda08e java redundant cast: cleanup: visitor finally inverted
GitOrigin-RevId: 8b4449e6d9163c24b046aad9065e5ec055d6d62c
2020-05-11 08:33:17 +00:00
Anna Kozlova 78891be4bb java redundant cast: cleanup: extract conditional
GitOrigin-RevId: ca95c0e70c197e27943596e91df8d526bbfbf1bb
2020-05-11 08:33:17 +00:00
Anna Kozlova efc6106e02 java redundant cast: cleanup: avoid dbl cast registration for expressions with expected type
GitOrigin-RevId: a31b1d892b2e19bfaf556e85724eb244189111b4
2020-05-11 08:33:17 +00:00
Anna Kozlova c3bda2dac0 java redundant cast: cleanup: refexpr
GitOrigin-RevId: d4a111e2a47885ef97983979200056612db26c93
2020-05-11 08:33:17 +00:00
Anna Kozlova fdc80d017c java redundant cast: fixed multiple casts in synchronized stmt
GitOrigin-RevId: 49a7d8dbcd26a3aa905c57db97d386bcbd285464
2020-05-11 08:33:17 +00:00
Anna Kozlova f0233d4e68 java redundant cast: cleanup: extract refexpr
GitOrigin-RevId: 04e04333b3f5b639c2923befd9b3637ee04de502
2020-05-11 08:33:17 +00:00