Commit Graph

332 Commits

Author SHA1 Message Date
Dmitry Avdeev
6ba55541ee IDEA-337197 Throwable: the expensive method should not be called inside the highlighting pass in JSP
check unresolved references in a dedicated XmlUnresolvedReferenceInspection

GitOrigin-RevId: d54b7a0b933c33c8656726c84a9611c97c1268ff
2023-12-13 18:12:42 +00:00
Piotr Tomiak
3601854d3f WEB-63626 Angular17: provide quick fix to escape @ and {; shorten message for unterminated expansion form
GitOrigin-RevId: 87b4282176c34230ebfb651a7a4c4f19541889ab
2023-12-08 19:41:30 +00:00
Christian Ivicevic
a7ddb28d54 WEB-60882 Introduce extendable highlighting of custom components including React Client Components
Merge-request: IJ-MR-115570
Merged-by: Christian Ivicevic <Christian.Ivicevic@jetbrains.com>

GitOrigin-RevId: 119ecd87900a7c3a7c416137377f61ecf5fcf2e1
2023-10-12 23:57:04 +00:00
Piotr Tomiak
c8ec813d11 IDEA-333866 Fix RemoveAttributeIntentionFix and XmlChangeAttributeValueIntentionFix to work with Quick Doc popup.
GitOrigin-RevId: 847bff0d14bdc63bbb51ff87db97b54039dbb3ee
2023-10-04 12:20:25 +00:00
Piotr Tomiak
cd2a639e6e WEB-63029 XML: allow for attribute validation messages with HTML code for tooltip
GitOrigin-RevId: 96b149a541b702e9eaa69965d7432a1912f09e5a
2023-09-26 10:28:02 +00:00
Piotr Tomiak
d027ba6898 WEB-54133 Angular: improve resolution of SVG element descriptors with Web Symbols
Also move most of com.intellij.html.webSymbols package from `impl` module to `xml-psi-impl` module to make it visible to `xml-analysis-impl` module and `HtmlUnknownTagInspectionBase` class.

GitOrigin-RevId: d34431683f52d9abd2e9d174917a818b6607536c
2023-07-27 08:58:50 +00:00
Christian Ivicevic
304a759f55 WEB-31414 Automatically close self-closing tags when pasting HTML to JSX
GitOrigin-RevId: d66eac14cc1d4caf295f3c976bd48c6d52bcfbfd
2023-07-25 12:33:10 +00:00
sergey.vasiliev
12c91e620f Performance issues in PathManager#createReferences() [Part 1]:
It collects references from all (24+) PathReferenceProvider instances and  invokes resolve() for every found reference(see mergeReferences() method).  see  https://youtrack.jetbrains.com/issues?q=tag:%20slow-op-highlighting

GitOrigin-RevId: 5cf5b1aef203f8ca8dd6fc5366382359db0e5859
2023-07-19 17:07:40 +00:00
Piotr Tomiak
c9ef2330da WEB-15620 Custom html attributes and elements are added lowercase only
GitOrigin-RevId: 9051538795501005b181af53e9e5db4061544c92
2023-07-06 12:43:53 +00:00
Alexey Kudravtsev
14ff37953d specify return type explicitly in Kotlin in some openapi and util to speedup Kotlin resolve
GitOrigin-RevId: 2b68c5d51524b822c645dbcb3828acbdd15245ad
2023-05-31 15:36:27 +00:00
Nicolay Mitropolsky
db84cf0e4f [analysis, xml] LazyMultipleReferencesWrapper makes it possible to postpone reference contribution (IDEA-304281)
It is a workaround for expensive references contributors like `CustomServletReferenceProvider`.

GitOrigin-RevId: 942827a1701b23958748e92c3da82058ca27afe1
2023-04-18 17:35:32 +00:00
Piotr Tomiak
fc03d03914 WEB-30806 Highlight HTML errors in Angular2HTML injections in inline templates
GitOrigin-RevId: 17e03a4d9201d24d20d44781c1b4bf66a1932e30
2023-04-06 14:10:03 +00:00
Piotr Tomiak
9b118175ce WEB-58267 WEB-58305 Support for NgOptimizedImage directive and inspection for converting from src to ngSrc
GitOrigin-RevId: c079af4ed192499ad97547eeccba9c0b8151ea90
2023-02-21 08:27:54 +00:00
Alexey Kudravtsev
91cd121707 assert no null LocalQuickFixes are passed to CommonProblemDescriptorImpl inside the "quickFixes" array (IDEA-312632), fix usages
null arrays still can be passed, but arrays with null elements are rejected because:
- consistency: it was very complicated (for both clients and implementation code) to understand if this particular fix could be null or not, and
- performance: filtering out null elements from the array and reallocating them back were noticeably expensive.
Currently, this assertion works inside tests only, to avoid irrecoverable failures in third-party plugins

GitOrigin-RevId: b71bc59eb811a807a0e6aae9609c368806f54869
2023-02-13 18:09:58 +00:00
Tagir Valeev
f456ed0604 Pattern variable can be used mass cleanup
GitOrigin-RevId: 55839bf0deca5f81d0f7eb5b1c190145a5ea0037
2023-02-07 13:58:20 +00:00
Yann Cébron
8e1eb731a3 XmlAttributeRenameProvider: javadoc cleanup
GitOrigin-RevId: f2bb0c47f07286abc6d5f44aaf566167ea4b99d7
2023-01-19 10:16:01 +00:00
Nikolay Chashnikov
1178f48134 cleanup: remove redundant '@author' tags from javadoc comments - 14
Now we have Code Vision hints which determine the author via Git history and show it in the editor automatically, and this information is more accurate than the tags which were automatically added when files were created.

GitOrigin-RevId: e0f2d6f1a9e6446397171170b4cf60d03a26b12c
2023-01-18 17:02:10 +00:00
Nikolay Chashnikov
37ce2ff8a6 cleanup: remove redundant '@author' tags from javadoc comments - 10
Now we have Code Vision hints which determine the author via Git history and show it in the editor automatically, and this information is more accurate than the tags which were automatically added when files were created.

GitOrigin-RevId: c9da0e5b671b6049f85db4824ea81782e2977d77
2023-01-18 17:01:57 +00:00
Nikolay Chashnikov
c1f2c8a692 cleanup: remove redundant '@author' tags from javadoc comments - 9
Now we have Code Vision hints which determine the author via Git history and show it in the editor automatically, and this information is more accurate than the tags which were automatically added when files were created.

GitOrigin-RevId: fcf3f973d7c945698016443c015023e73ac71572
2023-01-18 17:01:54 +00:00
Nikolay Chashnikov
98b622aa27 cleanup: remove redundant '@author' tags from javadoc comments - 5
Now we have Code Vision hints which determine the author via Git history and show it in the editor automatically, and this information is more accurate than the tags which were automatically added when files were created.

GitOrigin-RevId: e1f798814ca7f22747768b99cbcd962d820bbfb9
2023-01-18 17:01:41 +00:00
Nikolay Chashnikov
c732af0e17 cleanup: remove redundant '@author' tags from javadoc comments - 1
Now we have Code Vision hints which determine the author via Git history and show it in the editor automatically, and this information is more accurate than the tags which were automatically added when files were created.

GitOrigin-RevId: e9c6313db2c112ecf8370e86d264bec38467eb61
2023-01-18 17:01:28 +00:00
Tagir Valeev
5936f53ceb [html] Use OptPane
GitOrigin-RevId: c17a2ecd7664030b64cd1999834c4725a9ade69b
2023-01-16 12:18:15 +00:00
Tagir Valeev
0e563458e1 [xml] XmlDeprecatedElementInspection: use OptPane
GitOrigin-RevId: 9ca64abf20103d973a56db01e1e61eb0262aaa88
2022-12-16 15:42:40 +00:00
Vladimir Panimaskin
8ddb2c3ffe WEB-57509 support for Vite and Webpack aliases inside Vue style tag
GitOrigin-RevId: db1e8bc243eb824adb27df8bfe8f058de4598de5
2022-12-16 15:34:23 +00:00
Dmitry Jemerov
e2d1b2bc45 DOM nesting inspection: add reference to React sources, check for custom elements (IJ-CR-100147)
GitOrigin-RevId: 37c145ca9e381512e6822db5fadcc11e03603355
2022-12-16 13:42:12 +00:00
Dmitry Jemerov
60d08025e3 Initial support for text nodes in DOM nesting inspection
GitOrigin-RevId: 1032058f222dad90adf61e9e5107bae6b1a13145
2022-12-12 14:54:12 +00:00
Louis Vignier
838656a30a [intention-preview] Add a custom diff preview for XmlEntitiesInspection intentions
GitOrigin-RevId: ef6d778fbf761c96593a23ae9b0fad01df0f26bc
2022-12-10 06:27:19 +00:00
Tagir Valeev
604f30df53 Fix constant values warnings
GitOrigin-RevId: 294c425cf982195817b4c8c762930676187abd9d
2022-12-05 15:06:23 +00:00
Piotr Tomiak
bc1908d5c7 WEB-51585 "Character sequence ']]>' must not appear in content unless used to mark the end of a CDATA section" in HTML string
GitOrigin-RevId: 5a9f36623cc2df1071a4faaf307027cee0802898
2022-11-10 09:13:29 +00:00
Alexey Kudravtsev
6a373228b7 IDEA-305450 HighlightInfo must be shown immediately
Change HighlightInfo.Builder API to add "registerFix" method;
Port (almost) all usages of the old HighlightInfo.registerFix() to the new API;
Display HighlightInfo immediately after it's added to the HighlightInfoHolder in GeneralHighlightingPass to reduce latency between creating various HighlightInfos and showing them onscreen

GitOrigin-RevId: 9dca70b2198d346bf738895f8373f839b53aa940
2022-11-07 17:45:52 +00:00
Piotr Tomiak
59d8fb0ea0 WEB-57763 WEB-57420 XmlChangeAttributeValueIntentionFix should not be registered through an extension.
GitOrigin-RevId: 82bbc8c16ace2e7718ccad36d1fecb2ebd5b91f0
2022-11-07 08:53:03 +00:00
Sofya.Povarova
41029b387f WEB-45579 renamed class, added example in JSDoc, small optimization
(cherry picked from commit b34bd73638d535adeff70470db5e0940d8572170)

IJ-MR-97111

GitOrigin-RevId: f69eea01c054caa182d4e7dc0dd56b93d4586546
2022-10-29 19:10:21 +00:00
Sofya.Povarova
ac1608f224 WEB-45579 review fixes
(cherry picked from commit aca3fae57cccf6d3d2bb6607e4b2315ad72298b2)

IJ-MR-97111

GitOrigin-RevId: f7d88de7f44d5eac30736cced1412bb47792c883
2022-10-29 19:10:18 +00:00
Sofya.Povarova
bc2f92a61b WEB-45579 Support an ability to replace class attribute by className in React
(cherry picked from commit 4f6118d2f3b017c3178470e190585573e7d2f648)

IJ-MR-97111

GitOrigin-RevId: bf90c084c684c149a0ac11c914ec9e66cf3c3307
2022-10-29 19:10:15 +00:00
Nikolay Chashnikov
e7195f6214 cleanup: remove '@author peter' tags from javadoc comments
Now we have Code Vision hints which determine the author via Git history and show it in the editor automatically, and this information is more accurate than the tags which were automatically added when files were created.

GitOrigin-RevId: 99ea11604b3d5dfdf838d7f3685477814e642ceb
2022-10-13 14:39:10 +00:00
Bas Leijdekkers
254a11b3cf More efficient optimal alignment edit distance calculation
GitOrigin-RevId: 98b40c9d5aee4ccf3fe82baf0cd7c3b60407f8d0
2022-10-08 15:36:31 +00:00
Louis Vignier
1a01f7a8ac [intention preview] Use getViewProvider in RenameTagBeginOrEndIntentionAction
GitOrigin-RevId: b2fb890cdfe347643243d9715b0f132a12fa734e
2022-09-22 18:10:00 +00:00
Andrey Starovoyt
07d7d644b8 html: highlight exceptions as custom tags WEB-54337
GitOrigin-RevId: bca5d378a9f8a5d96b1160d517f3ff77d1a2098c
2022-09-13 13:16:05 +00:00
Andrey Starovoyt
e952b6e5c6 xml: custom tag, fix problem with case-sensitive names WEB-56311
GitOrigin-RevId: 0df9cd5052a619b502cd8d95189ae57a83714ea0
2022-09-13 13:16:02 +00:00
Alexey Kudravtsev
32a82a0a67 IDEA-299994 highlighting: reduce UnresolvedReferenceQuickFixProvider calls
Before: query UnresolvedReferenceQuickFixProvider for each HighlightInfo containing unresolved reference.
After: make these UnresolvedReferenceQuickFixProvider calls lazy and backgroundable. Instead of (synchronously) calling UnresolvedReferenceQuickFixProvider
whenever the unresolved reference is encountered, the highlighting now calls UnresolvedReferenceQuickFixUpdater.registerQuickFixesLater().
Then the highlighting subsystem tries to compute quick fixes for these HighlightInfos by calling UnresolvedQuickFixProvider in background, irrespective of the current highlighting session.
This background computation tries to compute quick fixes for the current caret position first, and it doesn't compute them at all for HighlightInfos far enough from the caret, in hope they won't be needed.
In case the client does need these quickfixes, e.g, in case when the user pressed Alt-Enter or in tests, it should call UnresolvedReferenceQuickFixUpdater.waitQuickFixesSynchronously()

GitOrigin-RevId: 510b0d9942e0226a8953d5195c98fb9f5ec68c33
2022-09-12 14:58:25 +00:00
Piotr Tomiak
c8f9466228 WEB-23469 Can't suppress "wrong attribute value" warning
GitOrigin-RevId: e4c2930469b3313c58c005b14b90068b5304103c
2022-09-02 11:45:47 +00:00
Alexey Kudravtsev
81b28717e0 XmlElementVisitor: notnull
GitOrigin-RevId: 4f180fea2d553e29de956fb0f45d27c33ff6cf28
2022-08-25 11:49:30 +00:00
Anna Kozlova
107d6e49b5 [intentions preview] ampersand escaping
GitOrigin-RevId: 5fb2f22152d2a6fdedac3bebe1ba93fb9929c4f1
2022-07-12 17:14:53 +00:00
Tagir Valeev
8ffce367b8 [xml-inspections] Preview-friendly (once more) (EA-479592)
GitOrigin-RevId: 4fe4006575e79ddda503b6834fbbfffb8ad8e2dd
2022-07-04 06:59:59 +00:00
Dmitry Avdeev
d0aa498bad collapse tag fix preview
GitOrigin-RevId: bbc562920e937d428b130ca88ba6fc59309f0efc
2022-06-27 17:28:31 +00:00
Nicolay Mitropolsky
d947728cc8 [spring-mvc] one single SpringMvcReference instead of hell of them (IDEA-290028)
GitOrigin-RevId: e04b84358e7bf0690901879f784048b4876523f0
2022-06-01 13:24:27 +00:00
Tagir Valeev
01d7186242 [xml-inspections] XmlUnusedNamespaceInspection: preview-friendly (EA-479592)
GitOrigin-RevId: 9cd9f401b4ed6d4694b4512d36f3c7b43cb6e725
2022-04-01 10:08:16 +00:00
Bas Leijdekkers
acf654773d xml: fix suspicious indentation
GitOrigin-RevId: 3dbb95f3ecef92bec7c9038dee23e1fc1bf68a7e
2022-02-21 18:49:43 +00:00
Tagir Valeev
697c037365 [xml] XmlUnusedNamespaceInspection: preview-friendly
GitOrigin-RevId: 1e222e140c51b7537761442fce7bdcdb1d540912
2022-02-21 16:56:56 +00:00
Tagir Valeev
38bfebaa23 Unnecessary fully-qualified names removed
GitOrigin-RevId: 903dbd15b9f5c307d2e17747a86d5eeecaff144a
2022-02-16 09:35:23 +00:00