Commit Graph

121 Commits

Author SHA1 Message Date
Anna Kozlova
abc4a9ae72 no need in overriding getDisplayName for inspections
in production InspectionEP#displayName should be used; highlighting tests just do not use default names

GitOrigin-RevId: f0c172e568219499e7b96982fe352c7d1d3acc69
2019-12-11 08:03:54 +00:00
Alexey Kudravtsev
850cf546dc replace Logger.getInstance(#fqn) with Logger.getInstance(klass.class) to reduce constant pool and code size and make code more refactorable
GitOrigin-RevId: 4ef94813858973e44449a20cf8b09174c8df5fce
2019-11-07 17:02:46 +00:00
Tagir Valeev
ab45760d28 PsiParameterList#getParameter
GitOrigin-RevId: 17117234a0eb12f458d1a4e549477535081fa785
2019-10-22 10:11:09 +00:00
peter
851124baf5 IDEA-165845 Intention "Remove annotation" does not remove @Nonnull/@Nullable annotation from methods overriddes
GitOrigin-RevId: bce0718604b643df12bbc4e4e3e379091a6293aa
2019-10-16 18:24:09 +00:00
Tagir Valeev
6ebd80cf9f IDEA-218253 Extract "Not-null field is not initialized" to separate inspection and improve it
GitOrigin-RevId: 0f709e869db16fe75318864e45bda2bed6b9e4f6
2019-07-15 11:05:15 +03:00
peter
d03ceed722 NullableStuffInspection: don't check hierarchy for @NotNull on primitive type (IDEA-217864)
GitOrigin-RevId: 0ecb2dd0809071c98c5e0ae25d7d82020af955a1
2019-07-10 13:03:18 +03:00
Alexander Zolotov
391bda1c4b Update color schemes
- support the new Go colors

GitOrigin-RevId: 4ecd779a6ceae3f36b60c6656d9ff819fe844f89
2019-07-02 06:52:16 +03:00
Rustam Vishnyakov
123242c4b2 EditorConfig documentation test
GitOrigin-RevId: fd52ace3d7a32ecd02c2c5ab90e077967604c15e
2019-06-16 04:03:21 +03:00
Egor Zhdan
c1813cfb52 Cleanup: NotNull/Nullable
GitOrigin-RevId: b8e892f32ea84c2115973155dba7127b892cc36e
2019-06-16 04:02:08 +03:00
Eldar Abusalimov
1120c30a56 Merge remote-tracking branch 'origin/master' into eldar/cidr-debugger
# Conflicts:
#	CIDR/clion/src/com/jetbrains/cidr/cpp/toolchains/MSVC.java

GitOrigin-RevId: f3593b526d1870f32b3f1451cab0c6a653e5beb5
2019-06-16 03:01:38 +03:00
peter
7cd2f834e6 EA-144019 - NPE: NullableStuffInspectionBase.checkNonStandardAnnotations
GitOrigin-RevId: 8b17b61144c6c9966ad4b3af556521a5f5957701
2019-06-14 22:03:24 +03:00
Anna Kozlova
91f7445298 constructor reference: don't ignore constructor parameters during method reference inference (IDEA-185578)
GitOrigin-RevId: e836468e05db28157713e9edd3c70382f8ecdebc
2019-06-13 03:15:49 +03:00
Egor Zhdan
39d2d77155 Cleanup: NotNull/Nullable
GitOrigin-RevId: b8e892f32ea84c2115973155dba7127b892cc36e
2019-06-13 03:14:35 +03:00
Vladimir Krivosheev
8440df0fda prefer ArrayUtilRt
GitOrigin-RevId: f4b11d48949267d778f6cdab4ef8ac60eb85aa2e
2019-05-30 19:13:22 +03:00
Aleksey Rostovskiy
185284cee6 get rid of intellij.build.toolbox.litegen parameter and use BuildOptions.TOOLBOX_LITE_GEN_STEP to skip it instead
GitOrigin-RevId: 9aac8ee4ed1ebf2a29de18a238825fafb1ab88f9
2019-05-27 15:08:08 +03:00
Alexandr Suhinin
9215f4240b [duplicates] enable duplicates analysis in PyCharm/WebStorm/PhpStorm/RubyMine
GitOrigin-RevId: 1545b79fdca4888f4b94f47f22703fd37694fa7a
2019-05-27 15:07:30 +03:00
Anton Makeev
c105e26db3 Merge remote-tracking branch 'origin/master' into amakeev/gradle
GitOrigin-RevId: f9a633252daf311ecab19002c0f4757052eee9dc
2019-05-17 19:13:15 +03:00
Anton Makeev
b54aaf7e4e IDEA-210281 Cleanup Gradle settings: separate Runner configurable removed
GitOrigin-RevId: adbc39121fe91beb633e125b4cf39bfe0a422e4b
2019-05-17 19:02:16 +03:00
peter
c2af9d2351 introduce NullableNotNullManager.findExplicitNullabilityAnnotation (IDEA-CR-47125, IDEA-210087)
GitOrigin-RevId: 0e523b7ca23e29d379a78c8d49d3b69300fc6219
2019-05-15 11:10:52 +03:00
peter
02fcb39a75 make AnnotationUtil.findOwnAnnotation skip type annotations inapplicable to declarations (IDEA-CR-47125, IDEA-210087)
GitOrigin-RevId: 677b8286169bda976caab66a18881729182c7e04
2019-05-14 15:08:45 +03:00
Dmitry Avdeev
83f21c7197 Merge remote-tracking branch 'origin/master'
GitOrigin-RevId: 211e84dab4063848c1d3d835a526271ee1466636
2019-05-07 17:03:19 +03:00
Dmitry Avdeev
f9664fc455 IDEA-211555 Freeze on completion in XML file
do not process xincludes in ExtensionDomExtender

GitOrigin-RevId: d631dcd52d5bf500b61960473e16237008ad02a3
2019-05-07 17:02:41 +03:00
Vladimir Krivosheev
98912e033d deprecate ContainerUtil.newArrayList()
GitOrigin-RevId: bff982a3dabd48c0e4f09e76653b40e2c58636b9
2019-05-03 15:04:35 +03:00
peter
c5a46ab4ac NullableStuffInspectionBase: cheaper scope calculation 2019-04-09 12:25:59 +02:00
peter
a943715bd5 NullableStuffInspection: report only property accessors that refer to correctly named fields (IDEA-202754) 2018-11-23 13:23:30 +01:00
Anna.Kozlova
c4b7de202d remove redundant suppressions 2018-10-04 12:09:46 +02:00
nik
0be3657ad0 cleanup: remove 'public' modifier from constructors in non-public classes (IDEA-195931)
public constructors in non-public classes may be confusing, and removing them makes code shorter.
2018-09-06 16:49:46 +03:00
Alexey Kudravtsev
9f97070926 bounded wildcards in API 2018-08-29 14:42:06 +03:00
Tagir Valeev
780c490823 NullableStuff: isNotNullParameterOverridingNonAnnotated should not fire for container annotation
When parameter is under @ParametersAreNotNullByDefault, but inherited from another context where there's no container annotation, it's considered as unannotated, thus no warning should be displayed
Fixes EA-123379 - assert: NullableStuffInspectionBase.checkParameters
2018-06-26 15:22:25 +07:00
Anna Kozlova
83d09acf8e hide change defaults intention if annotation is not accessible (IDEA-193685) 2018-06-20 14:49:51 +03:00
Tagir Valeev
f9a953e0c9 find(Effective/Own)NullabilityAnnotationInfo -> find(Effective/Own)NullabilityInfo
Review ID: IDEA-CR-33420
2018-06-19 12:02:52 +07:00
Roman Shevchenko
15fa931c9f [java] allows nulls to nullable parameters (IDEA-193726) 2018-06-11 18:56:53 +03:00
Tagir Valeev
f042e70b7a NullableNotNullManager#getNullability created and used 2018-06-09 14:37:24 +07:00
Tagir Valeev
91453c1649 Used Nullability instead of Nullness where possible
Nullness is still necessary to preserve compatibility with Kotlin plugin until they migrate
Renamings: (nullness, nullity) -> nullability
2018-06-09 14:29:28 +07:00
Tagir Valeev
c8384a57e1 Usage of checkBases-consuming methods reduced 2018-06-09 14:29:27 +07:00
Tagir Valeev
ee554a876c NullableNotNullManager: findEffectiveNullabilityAnnotationInfo, findEffectiveNullability
Removed isContainer* methods; more nullability refactoring
2018-06-09 14:29:26 +07:00
Tagir Valeev
49b710611c NullableNotNullManager: getNullable, getNotNull removed
NullableStuffInspectionBase#getPresentableAnnoName: findEffectiveNullabilityAnnotation used
2018-06-09 14:29:25 +07:00
Tagir Valeev
8e19b6c7fa NullableNotNullManager#findEffectiveNullabilityAnnotation 2018-06-08 13:04:14 +07:00
Alexey Kudravtsev
1efe1e355d cleanup 2018-05-24 13:47:41 +03:00
peter
47f5d6b9de IDEA-192372 'Annotate override method parameters as @Nonnull' quick-fix does nothing 2018-05-23 13:19:26 +02:00
peter
00222d2816 NullableStuffInspection: an option to not complain about generated implementation (IDEA-187625) 2018-04-27 20:19:00 +02:00
peter
cc551074c4 NullableStuffInspection: check overriding params when method is annotated (IDEA-190774) 2018-04-24 13:46:58 +02:00
Tagir Valeev
bc71b63a82 Create nullability annotation fixes via static factories
Dedicated classes AddNotNullAnnotationFix, AddNullableAnnotationFix, AddNullableNotNullAnnotationFix are deprecated.
Review ID: IDEA-CR-29519
2018-02-20 15:10:22 +07:00
peter
d6acde2edf IDEA-183585 Mismatching @NotNull/@Nullable values for several method with identical signatures in inherited classes are not detected 2017-12-19 22:36:38 +01:00
peter
465b9eaea5 IDEA-183759 "QuickFix-es with the same family name (Add 'NotNull' Annotation)..." com.intellij.codeInspection.nullable.NullableStuffInspection 2017-12-18 11:53:11 +01:00
Alexey Kudravtsev
f32b1c91d7 removed unnecessary startElement.isValid() checks from overriders because LocalQuickFixOnPsiElement.isAvailable() is guaranteed to be called with valid elements 2017-11-27 14:31:55 +03:00
Roman Shevchenko
4b3e26fb2f [java] deprecates outdated AnnotationUtil API (IDEA-181206) 2017-10-27 14:21:05 +02:00
Roman Shevchenko
5b431473dd [java] inlines a pair of superfluous base inspection classes 2017-10-04 19:00:57 +02:00
peter
4c876f8623 fix EA-107724 - SOE: NullableStuffInspectionBase$.isNullableNotNullCollectionConflict 2017-09-19 22:43:13 +02:00
Dmitry Batkovich
88542e3e86 cleanup: apply "static method referenced via subclass" for PropertyUtilBase methods 2017-09-18 10:36:51 +03:00