no need in overriding getDisplayName for inspections

in production InspectionEP#displayName should be used; highlighting tests just do not use default names

GitOrigin-RevId: f0c172e568219499e7b96982fe352c7d1d3acc69
This commit is contained in:
Anna Kozlova
2019-12-11 08:03:54 +00:00
committed by intellij-monorepo-bot
parent 90159a5f27
commit abc4a9ae72
918 changed files with 12 additions and 6158 deletions
@@ -32,13 +32,6 @@ import java.util.Collection;
*/
public class AnonymousGroupInspection extends LocalInspectionTool {
@Nls
@NotNull
@Override
public String getDisplayName() {
return "Anonymous capturing group or numeric back reference";
}
@NotNull
@Override
public PsiElementVisitor buildVisitor(@NotNull ProblemsHolder holder, boolean isOnTheFly) {
@@ -24,13 +24,6 @@ import java.util.Set;
*/
public class DuplicateAlternationBranchInspection extends LocalInspectionTool {
@Nls
@NotNull
@Override
public String getDisplayName() {
return "Duplicate branch in alternation";
}
@NotNull
@Override
public PsiElementVisitor buildVisitor(@NotNull ProblemsHolder holder, boolean isOnTheFly) {
@@ -16,13 +16,6 @@ import org.jetbrains.annotations.NotNull;
*/
public class EmptyAlternationBranchInspection extends LocalInspectionTool {
@Nls
@NotNull
@Override
public String getDisplayName() {
return "Empty branch in alternation";
}
@NotNull
@Override
public PsiElementVisitor buildVisitor(@NotNull ProblemsHolder holder, boolean isOnTheFly) {
@@ -20,13 +20,6 @@ import org.jetbrains.annotations.NotNull;
*/
public class EscapedMetaCharacterInspection extends LocalInspectionTool {
@Nls
@NotNull
@Override
public String getDisplayName() {
return "Escaped meta character";
}
@NotNull
@Override
public PsiElementVisitor buildVisitor(@NotNull ProblemsHolder holder, boolean isOnTheFly) {
@@ -18,13 +18,6 @@ import org.jetbrains.annotations.NotNull;
*/
public class OctalEscapeInspection extends LocalInspectionTool {
@Nls
@NotNull
@Override
public String getDisplayName() {
return "Octal escape";
}
@NotNull
@Override
public PsiElementVisitor buildVisitor(@NotNull ProblemsHolder holder, boolean isOnTheFly) {
@@ -30,13 +30,6 @@ import org.jetbrains.annotations.NotNull;
*/
public class ReDoSInspection extends LocalInspectionTool {
@Nls
@NotNull
@Override
public String getDisplayName() {
return "Exponential backtracking";
}
@NotNull
@Override
public PsiElementVisitor buildVisitor(@NotNull ProblemsHolder holder, boolean isOnTheFly) {
@@ -20,13 +20,6 @@ import org.jetbrains.annotations.NotNull;
*/
public class RedundantEscapeInspection extends LocalInspectionTool {
@Nls
@NotNull
@Override
public String getDisplayName() {
return "Redundant character escape";
}
@NotNull
@Override
public RegExpElementVisitor buildVisitor(@NotNull ProblemsHolder holder, boolean isOnTheFly) {
@@ -21,13 +21,6 @@ import org.jetbrains.annotations.Nullable;
*/
public class RepeatedSpaceInspection extends LocalInspectionTool {
@Nls
@NotNull
@Override
public String getDisplayName() {
return "Consecutive spaces";
}
@NotNull
@Override
public PsiElementVisitor buildVisitor(@NotNull ProblemsHolder holder, boolean isOnTheFly) {
@@ -21,13 +21,6 @@ import java.util.stream.Stream;
*/
public class SingleCharAlternationInspection extends LocalInspectionTool {
@Nls
@NotNull
@Override
public String getDisplayName() {
return "Single character alternation";
}
@NotNull
@Override
public PsiElementVisitor buildVisitor(@NotNull ProblemsHolder holder, boolean isOnTheFly) {
@@ -19,13 +19,6 @@ import org.jetbrains.annotations.NotNull;
*/
public class UnexpectedAnchorInspection extends LocalInspectionTool {
@Nls
@NotNull
@Override
public String getDisplayName() {
return "Begin or end anchor in unexpected position";
}
@NotNull
@Override
public PsiElementVisitor buildVisitor(@NotNull ProblemsHolder holder, boolean isOnTheFly) {
@@ -46,13 +46,6 @@ public class AnonymousCanBeLambdaInspection extends AbstractBaseJavaLocalInspect
return GroupNames.LANGUAGE_LEVEL_SPECIFIC_GROUP_NAME;
}
@Nls
@NotNull
@Override
public String getDisplayName() {
return "Anonymous type can be replaced with lambda";
}
@Override
public boolean isEnabledByDefault() {
return true;
@@ -93,11 +93,4 @@ public class BlockMarkerCommentsInspection extends AbstractBaseJavaLocalInspecti
}
};
}
@Nls
@NotNull
@Override
public String getDisplayName() {
return "Block marker comment";
}
}
@@ -23,13 +23,6 @@ public class ExplicitTypeCanBeDiamondInspection extends AbstractBaseJavaLocalIns
return GroupNames.LANGUAGE_LEVEL_SPECIFIC_GROUP_NAME;
}
@Nls
@NotNull
@Override
public String getDisplayName() {
return "Explicit type can be replaced with <>";
}
@Override
public boolean isEnabledByDefault() {
return true;
@@ -39,13 +39,6 @@ public class NumericOverflowInspection extends AbstractBaseJavaLocalInspectionTo
return GroupNames.NUMERIC_GROUP_NAME;
}
@Nls
@NotNull
@Override
public String getDisplayName() {
return "Numeric overflow";
}
@NotNull
@Override
public String getShortName() {
@@ -27,13 +27,6 @@ public class PossibleHeapPollutionVarargsInspection extends AbstractBaseJavaLoca
return GroupNames.LANGUAGE_LEVEL_SPECIFIC_GROUP_NAME;
}
@Nls
@NotNull
@Override
public String getDisplayName() {
return "Possible heap pollution from parameterized vararg type";
}
@Override
public boolean isEnabledByDefault() {
return true;
@@ -24,13 +24,6 @@ public class RedundantLambdaCodeBlockInspection extends AbstractBaseJavaLocalIns
return GroupNames.LANGUAGE_LEVEL_SPECIFIC_GROUP_NAME;
}
@Nls
@NotNull
@Override
public String getDisplayName() {
return "Statement lambda can be replaced with expression lambda";
}
@Override
public boolean isEnabledByDefault() {
return true;
@@ -21,11 +21,6 @@ public class AccessStaticViaInstanceBase extends AbstractBaseJavaLocalInspection
return "";
}
@Override
@NotNull
public String getDisplayName() {
return InspectionsBundle.message("access.static.via.instance");
}
@Override
@NotNull
@@ -216,12 +216,6 @@ public class CanBeFinalInspection extends GlobalJavaBatchInspectionTool {
return new AcceptSuggested(null);
}
@Override
@NotNull
public String getDisplayName() {
return DISPLAY_NAME;
}
@Override
@NotNull
public String getGroupDisplayName() {
@@ -21,12 +21,6 @@ public class JavacQuirksInspection extends AbstractBaseJavaLocalInspectionTool {
return GroupNames.COMPILER_ISSUES;
}
@Nls @NotNull
@Override
public String getDisplayName() {
return InspectionsBundle.message("inspection.compiler.javac.quirks.name");
}
@NotNull
@Override
public String getShortName() {
@@ -22,13 +22,6 @@ public class FieldAccessNotGuardedInspection extends AbstractBaseJavaLocalInspec
return GroupNames.CONCURRENCY_ANNOTATION_ISSUES;
}
@Override
@Nls
@NotNull
public String getDisplayName() {
return "Unguarded field access";
}
@Override
@NotNull
public String getShortName() {
@@ -18,13 +18,6 @@ public class InstanceGuardedByStaticInspection extends AbstractBaseJavaLocalInsp
return GroupNames.CONCURRENCY_ANNOTATION_ISSUES;
}
@Override
@Nls
@NotNull
public String getDisplayName() {
return "Instance member guarded by static field";
}
@Override
@NotNull
public String getShortName() {
@@ -16,13 +16,6 @@ public class NonFinalFieldInImmutableInspection extends AbstractBaseJavaLocalIns
return GroupNames.CONCURRENCY_ANNOTATION_ISSUES;
}
@Override
@Nls
@NotNull
public String getDisplayName() {
return "Non-final field in @Immutable class";
}
@Override
@NotNull
public String getShortName() {
@@ -18,13 +18,6 @@ public class NonFinalGuardInspection extends AbstractBaseJavaLocalInspectionTool
return GroupNames.CONCURRENCY_ANNOTATION_ISSUES;
}
@Override
@Nls
@NotNull
public String getDisplayName() {
return "Non-final @GuardedBy field";
}
@Override
@NotNull
public String getShortName() {
@@ -18,13 +18,6 @@ public class StaticGuardedByInstanceInspection extends AbstractBaseJavaLocalInsp
return GroupNames.CONCURRENCY_ANNOTATION_ISSUES;
}
@Override
@Nls
@NotNull
public String getDisplayName() {
return "Static member guarded by instance field or this";
}
@Override
@NotNull
public String getShortName() {
@@ -24,13 +24,6 @@ public class UnknownGuardInspection extends AbstractBaseJavaLocalInspectionTool
return GroupNames.CONCURRENCY_ANNOTATION_ISSUES;
}
@Override
@Nls
@NotNull
public String getDisplayName() {
return "Unknown @GuardedBy field";
}
@Override
@NotNull
public String getShortName() {
@@ -1113,12 +1113,6 @@ public abstract class DataFlowInspectionBase extends AbstractBaseJavaLocalInspec
return null;
}
@Override
@NotNull
public String getDisplayName() {
return InspectionsBundle.message("inspection.data.flow.display.name");
}
@Override
@NotNull
public String getGroupDisplayName() {
@@ -44,12 +44,6 @@ public class DummyEntryPointsTool extends UnusedDeclarationInspectionBase {
return JobDescriptor.EMPTY_ARRAY;
}
@Override
@NotNull
public String getDisplayName() {
return InspectionsBundle.message("inspection.dead.code.entry.points.display.name");
}
@Override
@NotNull
public String getGroupDisplayName() {
@@ -113,12 +113,6 @@ public class UnusedDeclarationInspectionBase extends GlobalInspectionTool {
TEST_ENTRY_POINTS = testEntryPoints;
}
@Override
@NotNull
public String getDisplayName() {
return DISPLAY_NAME;
}
@Override
@NotNull
public String getGroupDisplayName() {
@@ -34,12 +34,6 @@ public class DeprecationInspection extends DeprecationInspectionBase {
);
}
@Override
@NotNull
public String getDisplayName() {
return DISPLAY_NAME;
}
@Override
@NotNull
public String getGroupDisplayName() {
@@ -35,12 +35,6 @@ public class MarkedForRemovalInspection extends DeprecationInspectionBase {
return PsiElementVisitor.EMPTY_VISITOR;
}
@Override
@NotNull
public String getDisplayName() {
return DeprecationUtil.FOR_REMOVAL_DISPLAY_NAME;
}
@Override
@NotNull
public String getGroupDisplayName() {
@@ -19,12 +19,6 @@ public class DuplicateThrowsInspection extends AbstractBaseJavaLocalInspectionTo
@SuppressWarnings("PublicField")
public boolean ignoreSubclassing;
@Override
@NotNull
public String getDisplayName() {
return InspectionsBundle.message("inspection.duplicate.throws.display.name");
}
@Override
@NotNull
public String getGroupDisplayName() {
@@ -87,12 +87,6 @@ public class EqualsAndHashcodeBase extends AbstractBaseJavaLocalInspectionTool {
}
}
@Override
@NotNull
public String getDisplayName() {
return InspectionsBundle.message("inspection.equals.hashcode.display.name");
}
@Override
@NotNull
public String getGroupDisplayName() {
@@ -87,12 +87,6 @@ public class InconsistentLanguageLevelInspection extends GlobalInspectionTool {
return GroupNames.MODULARIZATION_GROUP_NAME;
}
@Override
@NotNull
public String getDisplayName() {
return "Inconsistent language level settings";
}
@Override
@NonNls
@NotNull
@@ -30,13 +30,6 @@ public class Java9RedundantRequiresStatementInspection extends GlobalJavaBatchIn
private static final Key<Set<String>> IMPORTED_JAVA_PACKAGES = Key.create("imported_java_packages");
@Nls
@NotNull
@Override
public String getDisplayName() {
return InspectionsBundle.message("inspection.redundant.requires.statement.name");
}
@Nullable
@Override
public CommonProblemDescriptor[] checkElement(@NotNull RefEntity refEntity,
@@ -300,12 +300,6 @@ public class LocalCanBeFinal extends AbstractBaseJavaLocalInspectionTool impleme
return true;
}
@Override
@NotNull
public String getDisplayName() {
return InspectionsBundle.message("inspection.local.can.be.final.display.name");
}
@Override
@NotNull
public String getGroupDisplayName() {
@@ -43,12 +43,6 @@ public class RedundantTypeArgsInspection extends GenericsInspectionToolBase {
return GroupNames.VERBOSE_GROUP_NAME;
}
@Override
@NotNull
public String getDisplayName() {
return InspectionsBundle.message("inspection.redundant.type.display.name");
}
@Override
@NotNull
public String getShortName() {
@@ -71,12 +71,6 @@ public class SuspiciousCollectionsMethodCallsInspection extends AbstractBaseJava
};
}
@Override
@NotNull
public String getDisplayName() {
return InspectionsBundle.message("inspection.suspicious.collections.method.calls.display.name");
}
@Override
@NotNull
public String getGroupDisplayName() {
@@ -628,12 +628,6 @@ public class NullableStuffInspectionBase extends AbstractBaseJavaLocalInspection
});
}
@Override
@NotNull
public String getDisplayName() {
return InspectionsBundle.message("inspection.nullable.problems.display.name");
}
@Override
@NotNull
public String getGroupDisplayName() {
@@ -40,7 +40,6 @@ import java.util.List;
*/
public class RedundantCastInspection extends GenericsInspectionToolBase {
private final LocalQuickFix myQuickFixAction;
private static final String DISPLAY_NAME = InspectionsBundle.message("inspection.redundant.cast.display.name");
@NonNls private static final String SHORT_NAME = "RedundantCast";
public boolean IGNORE_SUSPICIOUS_METHOD_CALLS;
@@ -125,12 +124,6 @@ public class RedundantCastInspection extends GenericsInspectionToolBase {
}
}
@Override
@NotNull
public String getDisplayName() {
return DISPLAY_NAME;
}
@Override
@NotNull
public String getGroupDisplayName() {
@@ -88,12 +88,6 @@ public class SameReturnValueInspection extends GlobalJavaBatchInspectionTool {
return false;
}
@Override
@NotNull
public String getDisplayName() {
return InspectionsBundle.message("inspection.same.return.value.display.name");
}
@Override
@NotNull
public String getGroupDisplayName() {
@@ -25,11 +25,6 @@ import java.util.List;
import static com.intellij.codeInsight.AnnotationUtil.CHECK_EXTERNAL;
public class TestOnlyInspection extends AbstractBaseJavaLocalInspectionTool {
@Override
@NotNull
public String getDisplayName() {
return InspectionsBundle.message("inspection.test.only.problems.display.name");
}
@Override
@NotNull
@@ -95,12 +95,6 @@ public class UnnecessaryModuleDependencyInspection extends GlobalInspectionTool
return GroupNames.DECLARATION_REDUNDANCY;
}
@Override
@NotNull
public String getDisplayName() {
return InspectionsBundle.message("unnecessary.module.dependency.display.name");
}
@Override
@NotNull
@NonNls
@@ -39,13 +39,6 @@ public class RedundantThrowsDeclarationInspection extends GlobalJavaBatchInspect
private final RedundantThrowsDeclarationLocalInspection myLocalInspection = new RedundantThrowsDeclarationLocalInspection(this);
@Nls
@NotNull
@Override
public String getDisplayName() {
return InspectionsBundle.message("inspection.redundant.throws.display.name");
}
@Nullable
@Override
public JComponent createOptionsPanel() {
@@ -33,12 +33,6 @@ public class RedundantThrowsDeclarationLocalInspection extends AbstractBaseJavaL
return myGlobalTool.getGroupDisplayName();
}
@Override
@NotNull
public String getDisplayName() {
return myGlobalTool.getDisplayName();
}
@Override
@NotNull
public String getShortName() {
@@ -57,12 +57,6 @@ public class UnusedImportInspection extends GlobalSimpleInspectionTool {
return SHORT_NAME;
}
@Override
@NotNull
public String getDisplayName() {
return DISPLAY_NAME;
}
@Override
public boolean worksInBatchModeOnly() {
return false;
@@ -226,12 +226,6 @@ public class UnusedLibrariesInspection extends GlobalInspectionTool {
return GroupNames.DECLARATION_REDUNDANCY;
}
@Override
@NotNull
public String getDisplayName() {
return InspectionsBundle.message("unused.library.display.name");
}
@Override
@NonNls
@NotNull
@@ -105,12 +105,6 @@ public class UnusedSymbolLocalInspectionBase extends AbstractBaseJavaLocalInspec
return GroupNames.DECLARATION_REDUNDANCY;
}
@Override
@NotNull
public String getDisplayName() {
return DISPLAY_NAME;
}
@Override
@NotNull
@NonNls
@@ -51,12 +51,6 @@ class AccessCanBeTightenedInspection extends AbstractBaseJavaLocalInspectionTool
return GroupNames.VISIBILITY_GROUP_NAME;
}
@Override
@NotNull
public String getDisplayName() {
return "Member access can be tightened";
}
@Override
@NotNull
public String getShortName() {
@@ -125,12 +125,6 @@ public final class VisibilityInspection extends GlobalJavaBatchInspectionTool {
return new AccessCanBeTightenedInspection(this);
}
@Override
@NotNull
public String getDisplayName() {
return DISPLAY_NAME;
}
@Override
@NotNull
public String getGroupDisplayName() {
@@ -62,13 +62,6 @@ public class DeprecatedClassUsageInspection extends XmlSuppressableInspectionToo
return "XML";
}
@Nls
@NotNull
@Override
public String getDisplayName() {
return "Deprecated API usage in XML";
}
@NotNull
@Override
public String getShortName() {
@@ -64,12 +64,6 @@ public class ClassHasNoToStringMethodInspection extends AbstractToStringInspecti
@Override
@NotNull
public String getDisplayName() {
return "Class does not override 'toString()' method";
}
@Override
@NotNull
public String getShortName() {
return "ClassHasNoToStringMethod";
@@ -35,12 +35,6 @@ import java.util.Collections;
*/
public class FieldNotUsedInToStringInspection extends AbstractToStringInspection {
@Override
@NotNull
public String getDisplayName() {
return "Field not used in 'toString()' method";
}
@Override
@NotNull
public String getShortName() {
@@ -32,13 +32,6 @@ public class AnonymousCanBeMethodReferenceInspection extends AbstractBaseJavaLoc
return GroupNames.LANGUAGE_LEVEL_SPECIFIC_GROUP_NAME;
}
@Nls
@NotNull
@Override
public String getDisplayName() {
return "Anonymous type can be replaced with method reference";
}
@Override
public boolean isEnabledByDefault() {
return true;
@@ -287,12 +287,6 @@ public class DefUseInspection extends AbstractBaseJavaLocalInspectionTool {
}
}
@Override
@NotNull
public String getDisplayName() {
return DISPLAY_NAME;
}
@Override
@NotNull
public String getGroupDisplayName() {
@@ -42,12 +42,6 @@ public class DefaultFileTemplateUsageInspection extends AbstractBaseJavaLocalIns
return GENERAL_GROUP_NAME;
}
@Override
@NotNull
public String getDisplayName() {
return InspectionsBundle.message("default.file.template.display.name");
}
@Override
@NotNull
@NonNls
@@ -63,12 +63,6 @@ public class DependencyInspection extends AbstractBaseJavaLocalInspectionTool {
return GroupNames.DEPENDENCY_GROUP_NAME;
}
@Override
@NotNull
public String getDisplayName() {
return InspectionsBundle.message("illegal.package.dependencies");
}
@Override
@NotNull
public String getShortName() {
@@ -232,13 +232,6 @@ public class EmptyMethodInspection extends GlobalJavaBatchInspectionTool {
return false;
}
@Override
@NotNull
public String getDisplayName() {
return DISPLAY_NAME;
}
@Override
@NotNull
public String getGroupDisplayName() {
@@ -172,12 +172,6 @@ public class Java15APIUsageInspection extends AbstractBaseJavaLocalInspectionToo
return GroupNames.LANGUAGE_LEVEL_SPECIFIC_GROUP_NAME;
}
@Override
@NotNull
public String getDisplayName() {
return InspectionsBundle.message("inspection.1.5.display.name");
}
@Override
@NotNull
public String getShortName() {
@@ -357,12 +357,6 @@ public class JavaDocLocalInspection extends LocalInspectionTool {
JavadocHighlightUtil.checkDuplicateTags(tags, holder);
}
@Override
@NotNull
public String getDisplayName() {
return InspectionsBundle.message("inspection.javadoc.display.name");
}
@Override
@NotNull
public String getGroupDisplayName() {
@@ -159,12 +159,6 @@ public class JavaDocReferenceInspection extends LocalInspectionTool {
return true;
}
@NotNull
@Override
public String getDisplayName() {
return InspectionsBundle.message("inspection.javadoc.ref.display.name");
}
@NotNull
@Override
public String getGroupDisplayName() {
@@ -75,13 +75,6 @@ public final class MagicConstantInspection extends AbstractBaseJavaLocalInspecti
return GroupNames.BUGS_GROUP_NAME;
}
@Nls
@NotNull
@Override
public String getDisplayName() {
return "Magic Constant";
}
@NotNull
@Override
public String getShortName() {
@@ -195,12 +195,6 @@ public class RedundantArrayForVarargsCallInspection extends GenericsInspectionTo
return GroupNames.VERBOSE_GROUP_NAME;
}
@Override
@NotNull
public String getDisplayName() {
return InspectionsBundle.message("inspection.redundant.array.creation.display.name");
}
@Override
@NotNull
@NonNls
@@ -148,12 +148,6 @@ public class SameParameterValueInspection extends GlobalJavaBatchInspectionTool
return false;
}
@Override
@NotNull
public String getDisplayName() {
return InspectionsBundle.message("inspection.same.parameter.display.name");
}
@Override
@NotNull
public String getGroupDisplayName() {
@@ -384,11 +378,6 @@ public class SameParameterValueInspection extends GlobalJavaBatchInspectionTool
return myGlobal.getGroupDisplayName();
}
@Override
@NotNull
public String getDisplayName() {
return myGlobal.getDisplayName();
}
@Override
@NotNull
@@ -40,12 +40,6 @@ public class SillyAssignmentInspection extends AbstractBaseJavaLocalInspectionTo
return new RemoveSillyAssignmentFix();
}
@Override
@NotNull
public String getDisplayName() {
return InspectionsBundle.message("inspection.variable.assigned.to.itself.display.name");
}
@Override
@NotNull
@NonNls
@@ -42,13 +42,6 @@ public class SimplifyForEachInspection extends AbstractBaseJavaLocalInspectionTo
return GroupNames.LANGUAGE_LEVEL_SPECIFIC_GROUP_NAME;
}
@Nls
@NotNull
@Override
public String getDisplayName() {
return InspectionsBundle.message("inspection.simplify.foreach.display.name");
}
@NotNull
@Override
public PsiElementVisitor buildVisitor(@NotNull ProblemsHolder holder, boolean isOnTheFly) {
@@ -70,13 +70,6 @@ public class StreamApiMigrationInspection extends AbstractBaseJavaLocalInspectio
return GroupNames.LANGUAGE_LEVEL_SPECIFIC_GROUP_NAME;
}
@Nls
@NotNull
@Override
public String getDisplayName() {
return "foreach loop can be collapsed with Stream API";
}
@Override
public boolean isEnabledByDefault() {
return true;
@@ -124,12 +124,6 @@ public class SuspiciousNameCombinationInspection extends AbstractBaseJavaLocalIn
return GroupNames.BUGS_GROUP_NAME;
}
@Override
@NotNull
public String getDisplayName() {
return InspectionsBundle.message("suspicious.name.combination.display.name");
}
@Override
@NotNull
@NonNls
@@ -133,12 +133,6 @@ public class UncheckedWarningLocalInspection extends AbstractBaseJavaLocalInspec
return "";
}
@Override
@NotNull
public String getDisplayName() {
return DISPLAY_NAME;
}
@Override
@NotNull
@NonNls
@@ -132,12 +132,6 @@ public class UnusedReturnValue extends GlobalJavaBatchInspectionTool{
return false;
}
@Override
@NotNull
public String getDisplayName() {
return InspectionsBundle.message("inspection.unused.return.value.display.name");
}
@Override
@NotNull
public String getGroupDisplayName() {
@@ -32,12 +32,6 @@ public class UnusedReturnValueLocalInspection extends AbstractBaseJavaLocalInspe
return myGlobal.getGroupDisplayName();
}
@Override
@NotNull
public String getDisplayName() {
return myGlobal.getDisplayName();
}
@Override
@NotNull
public String getShortName() {
@@ -359,12 +359,6 @@ public class FieldCanBeLocalInspection extends AbstractBaseJavaLocalInspectionTo
return GroupNames.CLASS_LAYOUT_GROUP_NAME;
}
@Override
@NotNull
public String getDisplayName() {
return InspectionsBundle.message("inspection.field.can.be.local.display.name");
}
@Override
@NotNull
public String getShortName() {
@@ -38,12 +38,6 @@ public class ParameterCanBeLocalInspection extends AbstractBaseJavaLocalInspecti
return GroupNames.CLASS_LAYOUT_GROUP_NAME;
}
@Override
@NotNull
public String getDisplayName() {
return InspectionsBundle.message("inspection.parameter.can.be.local.display.name");
}
@Override
@NotNull
public String getShortName() {
@@ -105,12 +105,6 @@ public class WrongPackageStatementInspection extends AbstractBaseJavaLocalInspec
return HighlightDisplayLevel.ERROR;
}
@Override
@NotNull
public String getDisplayName() {
return InspectionsBundle.message("wrong.package.statement");
}
@Override
@NotNull
@NonNls
@@ -50,13 +50,6 @@ import java.util.stream.Collectors;
public class JsonDuplicatePropertyKeysInspection extends LocalInspectionTool {
private static final String COMMENT = "$comment";
@Nls
@NotNull
@Override
public String getDisplayName() {
return JsonBundle.message("inspection.duplicate.keys.name");
}
@NotNull
@Override
public PsiElementVisitor buildVisitor(@NotNull final ProblemsHolder holder, boolean isOnTheFly) {
@@ -46,12 +46,6 @@ public class JsonStandardComplianceInspection extends LocalInspectionTool {
public boolean myWarnAboutTrailingCommas = true;
public boolean myWarnAboutMultipleTopLevelValues = true;
@Override
@NotNull
public String getDisplayName() {
return JsonBundle.message("inspection.compliance.name");
}
@NotNull
@Override
public HighlightDisplayLevel getDefaultLevel() {
@@ -18,12 +18,6 @@ import javax.swing.*;
public class Json5StandardComplianceInspection extends JsonStandardComplianceInspection {
@Override
@NotNull
public String getDisplayName() {
return JsonBundle.message("inspection.compliance5.name");
}
@NotNull
@Override
public PsiElementVisitor buildVisitor(@NotNull final ProblemsHolder holder, boolean isOnTheFly) {
@@ -22,12 +22,6 @@ import javax.swing.*;
public class JsonSchemaComplianceInspection extends JsonSchemaBasedInspectionBase {
public boolean myCaseInsensitiveEnum = false;
@Override
@NotNull
public String getDisplayName() {
return JsonBundle.message("json.schema.inspection.compliance.name");
}
@Override
protected PsiElementVisitor doBuildVisitor(@NotNull JsonValue root, @Nullable JsonSchemaObject schema, @NotNull JsonSchemaService service,
@NotNull ProblemsHolder holder,
@@ -18,11 +18,6 @@ import org.jetbrains.annotations.NotNull;
import org.jetbrains.annotations.Nullable;
public class JsonSchemaRefReferenceInspection extends JsonSchemaBasedInspectionBase {
@Override
@NotNull
public String getDisplayName() {
return JsonBundle.message("json.schema.ref.refs.inspection.name");
}
@Override
protected PsiElementVisitor doBuildVisitor(@NotNull JsonValue root,
@@ -16,12 +16,6 @@ import org.jetbrains.uast.UastContextKt;
public class StringToUpperWithoutLocale2Inspection extends AbstractBaseUastLocalInspectionTool {
@Nls
@NotNull
@Override
public String getDisplayName() { //TODO remove once inspection is registered in JvmAnalysisPlugin.xml
return "StringToUpperWithoutLocale2Inspection";
}
private static final UastCallMatcher MATCHER = UastCallMatcher.anyOf(
UastCallMatcher.builder()
@@ -21,7 +21,6 @@ import com.intellij.psi.PsiMethod;
import com.intellij.util.SmartList;
import com.intellij.util.containers.ContainerUtil;
import one.util.streamex.StreamEx;
import org.jetbrains.annotations.Nls;
import org.jetbrains.annotations.NotNull;
import org.jetbrains.annotations.Nullable;
import org.jetbrains.uast.UCallExpression;
@@ -45,13 +44,6 @@ public class BlockingMethodInNonBlockingContextInspection extends AbstractBaseUa
return new OptionsPanel();
}
@Nls
@NotNull
@Override
public String getDisplayName() {
return JvmAnalysisBundle.message("jvm.inspections.blocking.method.display.name");
}
@NotNull
@Override
public PsiElementVisitor buildVisitor(@NotNull ProblemsHolder holder, boolean isOnTheFly) {
@@ -7,6 +7,7 @@ import com.intellij.configurationStore.XmlSerializer;
import com.intellij.diagnostic.PluginException;
import com.intellij.lang.Language;
import com.intellij.lang.injection.InjectedLanguageManager;
import com.intellij.openapi.application.ApplicationManager;
import com.intellij.openapi.diagnostic.Logger;
import com.intellij.openapi.project.Project;
import com.intellij.openapi.util.DefaultJDOMExternalizer;
@@ -273,7 +274,9 @@ public abstract class InspectionProfileEntry implements BatchSuppressableTool {
return name;
}
}
PluginException.logPluginError(LOG, getClass() + ": display name should be overridden or configured via XML ", null, getClass());
if (!ApplicationManager.getApplication().isUnitTestMode()) {
PluginException.logPluginError(LOG, getClass() + ": display name should be overridden or configured via XML ", null, getClass());
}
return "";
}
@@ -40,12 +40,6 @@ public abstract class DefaultHighlightVisitorBasedInspection extends GlobalSimpl
public AnnotatorBasedInspection() {
super(false, true);
}
@Nls
@NotNull
@Override
public String getDisplayName() {
return getShortName();
}
@NotNull
@Override
@@ -58,12 +52,6 @@ public abstract class DefaultHighlightVisitorBasedInspection extends GlobalSimpl
public SyntaxErrorInspection() {
super(true, false);
}
@Nls
@NotNull
@Override
public String getDisplayName() {
return "Syntax error";
}
@NotNull
@Override
@@ -57,13 +57,6 @@ public class LossyEncodingInspection extends LocalInspectionTool {
return InspectionsBundle.message("group.names.internationalization.issues");
}
@Override
@Nls
@NotNull
public String getDisplayName() {
return InspectionsBundle.message("lossy.encoding");
}
@Override
@NonNls
@NotNull
@@ -54,13 +54,6 @@ public class NonAsciiCharactersInspection extends LocalInspectionTool {
return InspectionsBundle.message("group.names.internationalization.issues");
}
@Override
@Nls
@NotNull
public String getDisplayName() {
return InspectionsBundle.message("non.ascii.characters");
}
@Override
@NonNls
@NotNull
@@ -39,12 +39,6 @@ public class RedundantSuppressInspection extends GlobalSimpleInspectionTool {
return GroupNames.DECLARATION_REDUNDANCY;
}
@Override
@NotNull
public String getDisplayName() {
return InspectionsBundle.message("inspection.redundant.suppression.name");
}
@Override
@NotNull
@NonNls
@@ -329,13 +323,6 @@ public class RedundantSuppressInspection extends GlobalSimpleInspectionTool {
return SHORT_NAME;
}
@Nls
@NotNull
@Override
public String getDisplayName() {
return RedundantSuppressInspection.this.getDisplayName();
}
@NotNull
@Override
public PsiElementVisitor buildVisitor(@NotNull ProblemsHolder holder, boolean isOnTheFly) {
@@ -31,8 +31,6 @@ internal class ModuleNamesListInspection : LocalInspectionTool() {
return problems.toTypedArray()
}
override fun getDisplayName() = ProjectBundle.message("module.name.inspection.display.name")
override fun getStaticDescription() = ""
override fun isEnabledByDefault() = true
@@ -63,12 +63,6 @@ public class SSBasedInspection extends LocalInspectionTool {
return GENERAL_GROUP_NAME;
}
@Override
@NotNull
public String getDisplayName() {
return SSRBundle.message("SSRInspection.display.name");
}
@Override
@NotNull
@NonNls
@@ -44,13 +44,6 @@ public class StructuralSearchFullInspection extends LocalInspectionTool {
myConfigurations.add(configuration);
}
@Nls(capitalization = Nls.Capitalization.Sentence)
@NotNull
@Override
public String getDisplayName() {
return myName;
}
@NotNull
@Override
public String getShortName() {
@@ -61,11 +61,6 @@ public abstract class BaseInspection extends AbstractBaseJavaLocalInspectionTool
return m_shortName;
}
@Nls
@NotNull
@Override
public abstract String getDisplayName();
@Override
@Nls
@NotNull
@@ -16,7 +16,6 @@
package com.siyeh.ig;
import com.intellij.codeInspection.GlobalInspectionTool;
import org.jetbrains.annotations.Nls;
import org.jetbrains.annotations.NotNull;
/**
@@ -35,11 +34,4 @@ public abstract class BaseSharedLocalInspection<T extends GlobalInspectionTool>
public final String getShortName() {
return mySettingsDelegate.getShortName();
}
@Nls
@NotNull
@Override
public final String getDisplayName() {
return mySettingsDelegate.getDisplayName();
}
}
@@ -23,7 +23,6 @@ import com.siyeh.ig.BaseInspection;
import com.siyeh.ig.BaseInspectionVisitor;
import com.siyeh.ig.psiutils.LibraryUtil;
import com.siyeh.ig.psiutils.MethodCallUtils;
import org.jetbrains.annotations.Nls;
import org.jetbrains.annotations.NotNull;
import org.jetbrains.annotations.Nullable;
@@ -37,13 +36,6 @@ public class BooleanParameterInspection extends BaseInspection {
@SuppressWarnings("PublicField")
public boolean onlyReportMultiple = false;
@Nls
@NotNull
@Override
public String getDisplayName() {
return InspectionGadgetsBundle.message("boolean.parameter.display.name");
}
@NotNull
@Override
protected String buildErrorString(Object... infos) {
@@ -37,12 +37,6 @@ public class CastToConcreteClassInspection extends BaseInspection {
@SuppressWarnings("PublicField")
public boolean ignoreInEquals = true; // keep for compatibility
@Override
@NotNull
public String getDisplayName() {
return InspectionGadgetsBundle.message("cast.to.concrete.class.display.name");
}
@Override
@NotNull
protected String buildErrorString(Object... infos) {
@@ -26,13 +26,6 @@ import org.jetbrains.annotations.Nullable;
public class ClassReferencesSubclassInspection extends BaseInspection {
@Override
@NotNull
public String getDisplayName() {
return InspectionGadgetsBundle.message(
"class.references.subclass.display.name");
}
@Override
@NotNull
public String buildErrorString(Object... infos) {
@@ -53,13 +53,6 @@ public class DeclareCollectionAsInterfaceInspection extends BaseInspection {
return "CollectionDeclaredAsConcreteClass";
}
@Override
@NotNull
public String getDisplayName() {
return InspectionGadgetsBundle.message(
"collection.declared.by.class.display.name");
}
@Override
@NotNull
public String buildErrorString(Object... infos) {
@@ -31,13 +31,6 @@ public class InstanceVariableOfConcreteClassInspection extends BaseInspection {
@SuppressWarnings("PublicField")
public boolean ignoreAbstractClasses = false;
@Override
@NotNull
public String getDisplayName() {
return InspectionGadgetsBundle.message(
"instance.variable.of.concrete.class.display.name");
}
@Override
@NotNull
public String buildErrorString(Object... infos) {
@@ -39,12 +39,6 @@ public class InstanceofChainInspection extends BaseInspection {
return "ChainOfInstanceofChecks";
}
@Override
@NotNull
public String getDisplayName() {
return InspectionGadgetsBundle.message("chain.of.instanceof.checks.display.name");
}
@Override
@NotNull
protected String buildErrorString(Object... infos) {
@@ -50,13 +50,6 @@ public class InstanceofInterfacesInspection extends BaseInspection {
return "InstanceofInterfaces"; // keep old suppression working
}
@Override
@NotNull
public String getDisplayName() {
return InspectionGadgetsBundle.message(
"instanceof.concrete.class.display.name");
}
@Override
@NotNull
public String buildErrorString(Object... infos) {
@@ -29,12 +29,6 @@ public class InstanceofThisInspection extends BaseInspection {
private static final CallMatcher OBJECT_GET_CLASS =
CallMatcher.exactInstanceCall(CommonClassNames.JAVA_LANG_OBJECT, "getClass").parameterCount(0);
@Override
@NotNull
public String getDisplayName() {
return InspectionGadgetsBundle.message("instanceof.check.for.this.display.name");
}
@Override
@NotNull
public String buildErrorString(Object... infos) {
@@ -23,19 +23,12 @@ import com.intellij.psi.PsiType;
import com.siyeh.InspectionGadgetsBundle;
import com.siyeh.ig.BaseInspection;
import com.siyeh.ig.BaseInspectionVisitor;
import org.jetbrains.annotations.Nls;
import org.jetbrains.annotations.NotNull;
/**
* @author Bas Leijdekkers
*/
public class InterfaceMethodClashesWithObjectInspection extends BaseInspection {
@Nls
@NotNull
@Override
public String getDisplayName() {
return InspectionGadgetsBundle.message("interface.clashes.with.object.class.display.name");
}
@NotNull
@Override
@@ -32,13 +32,6 @@ public class LocalVariableOfConcreteClassInspection
@SuppressWarnings("PublicField")
public boolean ignoreAbstractClasses = false;
@Override
@NotNull
public String getDisplayName() {
return InspectionGadgetsBundle.message(
"local.variable.of.concrete.class.display.name");
}
@Override
@NotNull
public String buildErrorString(Object... arg) {

Some files were not shown because too many files have changed in this diff Show More