Commit Graph

433436 Commits

Author SHA1 Message Date
Denis Mukhametianov
8968d8475d [rider] application dictionary can be not initialized during spellchecker settings transfer activity
GitOrigin-RevId: de04fe6c970f8fe9511e69367750710c317ee9ac
2024-02-13 11:19:19 +00:00
Denis Mukhametianov
9e5d106088 [grazie] workarounds for Rider: custom modification tracker for text content caching, allow ranges inconsistency
GitOrigin-RevId: 99361ba365f1030e9c5c3de346f7bd21ec0eaecb
2024-02-13 11:19:18 +00:00
Den Mukhametianov
cabf0773f8 [spellchecker] extend DictionaryLevel to DictionaryLayer with corresponding extension point
In Rider we want to pass ReSharper settings layers to UI-parts like combobox for choosing default dictionary to save words.

GitOrigin-RevId: b6b395d0108f2f1142fc1ab3656d3493c5b9be9c
2024-02-13 11:19:18 +00:00
Den Mukhametianov
75284da775 [spellchecker] allow SpellCheckerStrategy to decide whether psi element fits or doesn't spell checker scope, pass this scope to getTokenizer
Some backend-driven languages in Rider don't have detailed frontend lexer/parser, so the only node visible to spellchecker will be root PsiFile. We pass range-scope information from backend, and then rider's spell checking strategy will handle it itself.

GitOrigin-RevId: b97c9eaaed30d6a0e09d69b13cf4cd5ad1b5d364
2024-02-13 11:19:18 +00:00
Den Mukhametianov
86c8fa3545 [spellchecker] added extension point for specifying additional built-in dictionaries
Used in Rider to show and edit R# spell checker user words

GitOrigin-RevId: b1ee8bdf064364800a712400af1c3e7095f306ac
2024-02-13 11:19:18 +00:00
Vera Petrenkova
8aa10bdf3d IDEA-343507 Replace localized AgreementsBundle files
GitOrigin-RevId: ab291508809c6766fe9b671dfeff3fce15cb3be5
2024-02-13 11:17:50 +00:00
Dmitry Avdeev
e1317d40ce IJPL-636 Quick Doc. Target stepper doesn't respect context change
GitOrigin-RevId: 9f55563db0ee8e856b0c6db2302fc24fbcc66242
2024-02-13 11:05:27 +00:00
Mikhail Filippov
3fe952d47c IJI-1571 Code cleanup
GitOrigin-RevId: b8ee4a240cb63dde31bda21588ca62f173cd2f1b
2024-02-13 10:48:22 +00:00
Mikhail Filippov
56c46e4945 IJI-1571 Extract ultimate and community home folder lockup into static properties.
GitOrigin-RevId: 3dda1f49e57b0e0b23deb5fe5b7fa4f670255b34
2024-02-13 10:48:22 +00:00
Vera Petrenkova
4d41a0c5b5 IDEA-341743 Refactor LocalizationUtil to a singleton object and make some function as Path extension function
GitOrigin-RevId: 45cb00ee18919de78ce7b8417437377af7b81d90
2024-02-13 10:21:07 +00:00
Ruslan Cheremin
bc31610df0 [vfs] run VFSHealthChecker only if idle>1min
GitOrigin-RevId: 501bd00e8c6c562a64d0bcad092df717e0df9cb8
2024-02-13 09:19:30 +00:00
Ruslan Cheremin
8efbb3e2bc [comments] IdleTracker.events usage javadocs
GitOrigin-RevId: f7a7f8656a50974a04f8de884ec6953b0886e2cc
2024-02-13 09:19:30 +00:00
Vera Petrenkova
7d6375d068 IDEA-343507 Bundle translations for 'User Agreement' and 'Data Sharing' dialogs (Chinese, Korean, and Japanese)
GitOrigin-RevId: 6fc072ca9f99fc2b205f238c6486b407702e57a8
2024-02-13 09:08:16 +00:00
Vera Petrenkova
cc2fae82bb IDEA-343507 Add the ability to resolve bundles with custom locale
This allows for resolving bundles with a custom locale, especially in cases where the plugin context is not initialized yet.

GitOrigin-RevId: 252e15e870d1ac6f573f94a6ffe6f524c25d4074
2024-02-13 09:08:13 +00:00
Sergei Tachenov
002690605c Experimental (disabled by default) bulk expand in TreeState
Just for internal testing at this point. It's unusable as it is,
because it spends too much time collecting the paths to expand,
and while it's doing that, nothing visible happens, which leads
to very poor UX.

GitOrigin-RevId: e6db4329984fe504677cd596b6b817794fd3dc1b
2024-02-13 08:59:10 +00:00
Sergei Tachenov
057fe7af19 IDEA-344769 Account for invisible insets for tool window floating bounds
Now that we have a separate property for external decorator bounds,
implement it for both decorators to account for invisible insets.

As there seems to be no API for getting those invisible insets,
we use guesswork: the top inset is usually the window header,
and it's visible; the other insets are usually invisible drag zones.

Insets aren't available until the window is connected to an actual display
(the peer is created), so the new property will work incorrectly before
the window is shown for the first time, but thankfully we already have
a helper class to fix the insets after the window is shown, so it works
as expected, even though it's still a dirty hack and not a proper fix.

GitOrigin-RevId: efd75de13d070a6873bda05898803cc533259194
2024-02-13 08:59:07 +00:00
Sergei Tachenov
e1c49b476b IDEA-344769 Rename bounds to visibleWindowBounds
We're going to implement more complicated bounds computation,
and they will no longer match what getBounds() returns,
so (ab)using the property inherited from Java isn't going to work
anymore. We need our own.

Use the new property wherever possible in ToolWindowManagerImpl.

GitOrigin-RevId: cd6deb14de4d629fa63d7b3e8b6810bc05a48558
2024-02-13 08:59:04 +00:00
Sergei Tachenov
612a568198 EA-1047486 Use read action in DependenciesHandlerBase.bgtPostAnalyze
Turns out some scopes require read actions to compute the scope name.

GitOrigin-RevId: b42fca28b4919f1fe0943266fa4d4cc001180f74
2024-02-13 08:59:01 +00:00
Sergei Tachenov
9de9afdb51 EA-1066109 QuickChangeToolWindowLayout.getActionUpdateThread
This action delegates to RestoreNamedLayoutActionGroup,
which already sets its update thread to BGT, but
it wasn't set for the delegating action itself, which is simply
a mistake.

GitOrigin-RevId: ab5f117eed45651096768663d3b18188b53c224c
2024-02-13 08:58:58 +00:00
Sergei Tachenov
e3b8643771 EA-1071353 Filter out null elements in ProjectViewImpl.SelectionInfo.create
Likely the exception happens because something is invalidated or disposed.
We can safely ignore nulls here, the worst that can happen is that some
element won't be re-selected properly, which is still much better than
an exception being thrown, and at least other, still valid, elements
will be re-selected.

GitOrigin-RevId: ce9cd345dd96175e3f53db249d1e3a9725c31efc
2024-02-13 08:58:54 +00:00
Sergei Tachenov
54354060a6 EA-938293 Call SelectInTarget.toString() on a BGT
Its implementations are almost always either:

- return a constant;
- return a string from a message bundle;
- delegate to some getTitle() which does one of the above.

However, there are a few cases where toString() here involves
some BGT stuff. The most notable one is
com.intellij.ide.impl.ProjectViewSelectInExplorerTarget.toString
which does some FS operation to detect what's the file manager
should be called (e.g. Explorer, Finder, etc.).

So let's move it into a BGT and only do the UI fallback part
(replace the tool window ID with its title) on the EDT.

GitOrigin-RevId: 82aa4d7618e33f73ccefa444a4349e54576fc18b
2024-02-13 08:58:51 +00:00
Frederik Haselmeier
4f5ecfc0f0 [Kotlin] Fixed IDEA product name in onboarding lessons
KTIJ-26048

GitOrigin-RevId: 4c492ec5b34b81f3a9d51bd495ce4ce1205d24e1
2024-02-13 07:07:02 +00:00
Ruslan Cheremin
2d0c59a36c [vfs] enable VFSHealthCheck to use RA by default
+ `-Dvfs.health-check.wrap-in-read-action=false` to disable
 (roll back to previous)

+ Main part of VFSHealthCheck wrapped in ReadAction. Since VFS modifications are done under WA, checking consistency without RA is generally incorrect, because the checker could see intermediate inconsistent results.

GitOrigin-RevId: 7010571603cc904ae7a1f2b4e11f0e808bdbdeb4
2024-02-13 07:00:03 +00:00
Ivan Migalev
3300411e59 Settings Import: fix issue with blocked VSCode import
GitOrigin-RevId: b8f7f1cabb6127afbb9a4da235de7a6ed30e4709
2024-02-13 05:17:03 +00:00
Arseny.Chernyaev
2636b4791b enable collection visualizers
GitOrigin-RevId: c5b623dc096830bb2392f416d0d4ed6cf82a512c
2024-02-13 04:43:41 +00:00
Sergey Pak
f109d54803 don't filter out plugins with the incompatible version during import (relates to IDEA-336470 New Import Settings: don't import plugins incompatible with the IDE type when importing from IntelliJ-based IDEs)
GitOrigin-RevId: 3907397723133af820add9bf98055a21512c34b9
2024-02-13 02:36:09 +00:00
Sergey Pak
314e9a9d03 1. handle exception during import (and always restart if one occurs during the import
2. add restart after installing/copying plugins (for consistency) (related to IDEA-336392 New Import Settings: IDE proceeds importing after it's cancelled)

GitOrigin-RevId: 6d9dc3910af45f8a99f5a2a95c8f7ff90863ae69
2024-02-13 02:36:09 +00:00
Sergey Simonchik
a1a09992e6 terminal: highlight terminal-links on hover (IDEA-218794, IDEA-342419)
GitOrigin-RevId: 3df858517b0634e6aaa63c39d6a416fede958ee7
2024-02-13 01:41:14 +00:00
Alexander Doroshko
d8a4977c01 IDEA-330687, WEB-38066 (wip) Fix 'Open Settings' action text, move text to LangBundle.properties
GitOrigin-RevId: ada2f5d4301aa6f07d57c74b43333ce369e625a5
2024-02-13 01:06:18 +00:00
Alexander Doroshko
536139412f IDEA-330687 (wip): locate Language Services status bar widget where people are used to see TypeScript widget
because Language Services widget is going to replace TypeScript widget

GitOrigin-RevId: 763ba88067b66e1c224b5ba3a827ce29862ac5e9
2024-02-13 01:06:11 +00:00
Alexander Doroshko
6b760c3e84 IDEA-330687 (wip): introduce LanguageServiceWidget.cachedWidgetItems
helps to avoid LanguageServiceWidgetItem.widgetActionLocation calculation in EDT

GitOrigin-RevId: 9b110f7b039d4449baf74bd3c6ecfb7bcc963657
2024-02-13 01:05:58 +00:00
Alexander Doroshko
79f753f9f7 Add NlsContexts annotations to LanguageServiceWidgetItem.statusBarText and statusBarTooltip
GitOrigin-RevId: 5bb29d659e347c06f86ca0bac78129589bfa999b
2024-02-13 01:05:52 +00:00
Alexander Doroshko
a391ffbaba Update documentation for LanguageServiceWidgetItemsProvider.registerWidgetUpdaters
GitOrigin-RevId: e366f75edb205ea77a7f483d9aeecb3675540096
2024-02-13 01:05:48 +00:00
Nikolay Kuznetsov
7a1a7925b8 [rdct] remove unused function
GitOrigin-RevId: b6cf6201579d4b87f1e69af318ec0b1b30654064
2024-02-13 01:05:08 +00:00
Nikolay Kuznetsov
ee0bea894c [rdct] add preloading self-contained native libraries
GitOrigin-RevId: 809f5d34098e831600237cc821b9b1c9c426dc41
2024-02-13 01:05:08 +00:00
Nikolay Kuznetsov
260a169a2b [tests] add test for fontconfig setup
GitOrigin-RevId: ed90c11b20fc8e5ea940c132d72926f143807886
2024-02-13 01:05:07 +00:00
Nikolay Kuznetsov
f06938c004 [rdct] add fontconfig setup for RD launch scenarios
GitOrigin-RevId: 13f244aa0eab0cd5572bdbcbf698fd9a77907a15
2024-02-13 01:05:07 +00:00
Nikolay Kuznetsov
d6d56dd87e [rdct] add utility function for environment variable parsing
GitOrigin-RevId: cf1e1ed23f95061d5dc1e3919e42755c2fe28242
2024-02-13 01:05:07 +00:00
Nikolay Kuznetsov
c0d7c75e86 [rdct] remove support for legacy per-project config dirs from native launcher
GitOrigin-RevId: 3667e4a65282db77118134dac85147b8d823f349
2024-02-13 01:05:07 +00:00
Gregory.Shrago
04d585910f avoid relying on beforeActionPerformedUpdate in tests
GitOrigin-RevId: 89df0c2a9e7ae175ad18fd7f20a3217842781d21
2024-02-13 01:04:31 +00:00
Dmitry Kichinsky
6716814bf2 [maven] IDEA-340501 sync Maven projects incrementally in tests
GitOrigin-RevId: 985a48a2dc767e1dc06cd171ba982da96c59ff8e
2024-02-13 00:58:14 +00:00
Dmitry Kichinsky
bf7fdbe6e6 [maven] IDEA-340501 sync Maven projects incrementally in MavenProjectAware
GitOrigin-RevId: 39bc350bfaaf5aaaa9a36bf50267b5ee8ca53802
2024-02-13 00:58:10 +00:00
Liudmila Kornilova
c175bfdd8a Persist indexable files filter (but it's still cleared before scanning starts)
GitOrigin-RevId: 30b0c2511b0b0a8b7f77d4c29978e0e131c2ba07
2024-02-13 00:31:59 +00:00
Liudmila Kornilova
724ae015b2 ProjectIndexableFilesFilterHolder class -> interface
GitOrigin-RevId: fa9b674727b9494f9c49224aeb9ee36259b6c18e
2024-02-13 00:31:54 +00:00
Liudmila Kornilova
3fe717a7bc Use only one ProjectCloseListener to have more control over order
GitOrigin-RevId: ef2f37c5989b10d94b765e55f0901de7d84688e3
2024-02-13 00:31:49 +00:00
Liudmila Kornilova
2d99d38d8d Write version into dirty file queue files
GitOrigin-RevId: 2d6b881af52fad08a70eea1ff20f81470aca3699
2024-02-13 00:31:44 +00:00
Piotr Tomiak
af9fa6862f IJPL-156 Make location sticky to the bottom and to the content. Hide location if empty
GitOrigin-RevId: c1b18984b86c26a7f69d49f44c4238fffd7f7037
2024-02-13 00:16:30 +00:00
Piotr Tomiak
b28149eb2a IDEA-345694 Rework documentation popup styling - move magic size constants to DocumentationHtmlUtil; support scaling
GitOrigin-RevId: c519b8fa6acd4bb6ee3d3da45954c846189e2c87
2024-02-13 00:16:25 +00:00
Piotr Tomiak
ed56e22f06 IDEA-345694 Rework margins and font-size for quick documentation popup - fix constant
GitOrigin-RevId: 323be70cae07d65c4ebb1ffd33cb18e7dd2c4e11
2024-02-13 00:16:20 +00:00
Piotr Tomiak
753100fb20 IDEA-345694 Rework margins and font-size for quick documentation popup
GitOrigin-RevId: 5bad86f21662ab785f4d8c62c538280a407a0352
2024-02-13 00:16:16 +00:00