Missing .key caused the index check to always be -1, resulting in lastActiveItemIndex being set to -1 after Ctrl + left mouse click selecting an item. This led to an array out-of-bounds error in the onExtendSelectionToKey method when using Shift to select items.
- Corrected the logic in toggleKeySelection to properly compare keys.
- Changed `selectableLazyListState.lastActiveItemIndex = allKeys.indexOfFirst { it == key }`
to `selectableLazyListState.lastActiveItemIndex = allKeys.indexOfFirst { it.key == key }`.
closes https://github.com/JetBrains/intellij-community/pull/2900
(cherry picked from commit 54992abe8c1a27133d89e6bc48dca7e1697554d1)
(cherry picked from commit 610806d90dc4902d0c01b62d5ffe4f161050393b)
IJ-MR-155570
GitOrigin-RevId: cf3000beeecf62d6c8441e8d4163c980724eec97
The Javadoc for the class was malformed; I took the opportunity to rewrite it.
(cherry picked from commit 8997ee70d7f5124f0a922ed451cf744ad68b487a)
(cherry picked from commit 569461707bd7280432d58e381b8a502b488ce069)
IJ-MR-155570
GitOrigin-RevId: 78aafb7a7f8da039f609b7e60ff34ea2cf1642a9
Keep the original component hierarchy.
(cherry picked from commit 8746d61bef8c62a1a41e27631c574ade59608ed7)
IJ-CR-157279
GitOrigin-RevId: 5466789040175232ac60e928bf85cc011d1c133b
It went missing due to the hardcoded `LookupBottomLayout` layout. Its wrapper size was not updated.
(cherry picked from commit 3cb66e335c3de50c5b310de87a314b6f5cf4c400)
IJ-CR-157279
GitOrigin-RevId: d099d412ba2455f995fdd2e2a6c2f7f06e6a6362
#IJPL-176927 Fixed
Turns out: we all make boolean logic errors every once in a while, no exceptions.
follow-up: f449ea4351689c3dac3b0ea23327addc30e25c1e
(cherry picked from commit 9ab72e969a704fa346e76c69d14cfba068bde0ee)
GitOrigin-RevId: 9088f5bdac7aa091d4abe89ae480c9fe7a526739
- support editorconfig
- more tests
(cherry picked from commit d7fd604e95b1dd197a3efbdbfcd54e81564b2490)
IJ-CR-156496
GitOrigin-RevId: 141bae22ad1f263d06b28618bf425a68e8d3cac6
In the accessor, use GradleVersionCatalogModel (a model for a single catalog) instead of GradleVersionCatalogsModel (a model for multiple catalogs). The last one also gives access to libraries, plugins, bundles and versions - but the result is nullable. Accessing them with `!!` looks suspicious to me. Probably, it was a cause of NPE while <init> of the accessor. Anyway, the usage of GradleVersionCatalogModel looks better to me.
Code review: IJ-CR-153929
(cherry picked from commit b659570aa14e89654ece34d81f6771706760caf2)
GitOrigin-RevId: 5d8796f59f35302f6dd70a5292a8ac5c5562157e
There are some cases of NPE while <init> of the SyntheticVersionCatalogAccessor. Probably they were caused by the usage of `!!` operator with found delegate that could be null
Code review: IJ-CR-153929
(cherry picked from commit 636fc616b7148b82d645872fdef13f3b42e37c99)
GitOrigin-RevId: b3b707895ad3a5887bcde084bb35e0b87b78cc1d
Store feedback dates globally to consider several major versions and RD scenario
(cherry picked from commit 7194d98f019efecc0dbbca2e8b097be19fd11cfc)
(cherry picked from commit 8729b09d1ef21adbecbf3cb15cdd9a329046ebf3)
IJ-MR-155667
GitOrigin-RevId: f908baec1667d1e10cada10250253ce315d9ff6c
Do not show Evaluate Feedback once we have shown any CSAT notifications
(cherry picked from commit ecc781963a95bd1bec36e6f5c95ad800e81882da)
(cherry picked from commit 3e29b3f95ec161a1749a87d6bbf8e89cfb17c991)
IJ-MR-155667
GitOrigin-RevId: 872d4e474fe95e350b38b90c6d6835ff95ca2841
Do not show request feedback notifications twice
(cherry picked from commit a5e2f3278ff19918725ba77dc592347a9ffc4d93)
(cherry picked from commit e43e71f84d59e4ed26e1bef564393e44ed9045a6)
IJ-MR-155667
GitOrigin-RevId: eda1992585305691e954b7356bc2d51f91542e49
Include Host IDE information to system info of the survey
(cherry picked from commit 3822a535fffbd494de578f53e14f5a50f143b36f)
(cherry picked from commit d511b0149b34ca002bb5b6d2502f9ee08db85531)
IJ-MR-155667
GitOrigin-RevId: 58eab78bf22e1ab08b41e7cc3625d3069d4f740d
New icons for survey dialog
(cherry picked from commit 7568433465d7096c0d4338865e8f253fdf1b5cd4)
(cherry picked from commit f643f35430729f69ade739900d80105cb1249dda)
IJ-MR-155667
GitOrigin-RevId: 704a4b9d069ce6f1f9c49582ab24d649b8bf6da5
Run CSAT survey on the client side
(cherry picked from commit eb0b819f9ad4326589f013e76998dcfdd3e01b1e)
(cherry picked from commit 3ff503981d589ac352f43707abdfd3ee10736036)
IJ-MR-155667
GitOrigin-RevId: bf4044b688f353af2d5cc4f57d4e5c58161ca71a
Show next CSAT date via internal action
(cherry picked from commit 5239a1bb889eb72c03880c0e4eaaf4bf2291efd1)
(cherry picked from commit 52deaf5498f65c4d613cbef89ef972cc453105cd)
IJ-MR-155667
GitOrigin-RevId: fc385859e5bc773bbe07c4518937b82815d8d2d9
Fix hashes computation for show condition
(cherry picked from commit b07545e8cb52c438bc26c487fb9672624c3c1217)
(cherry picked from commit b34b16e13a124ec955924fa613ce72f9e06cfa9e)
IJ-MR-155667
GitOrigin-RevId: 136aa670b8a125c4c41dcb69a9047258ad8d73b8
