Commit Graph

443903 Commits

Author SHA1 Message Date
alexey.afanasiev
80aa2f4cfd QD-9205 Replace "inspect qodana" with "qodana" AppStarter
GitOrigin-RevId: 61ddfe1ed1839fcec9e6a9053dccd02614c02915
2024-06-04 20:08:36 +00:00
Pavel Kirpichenkov
cd9e06da04 [Kotlin] Add a regression test for missing diagnostic in platforms
KT-65406

GitOrigin-RevId: 17b43135d368302e32c7d8d05e2d914ba2d45f35
2024-06-04 20:07:10 +00:00
Alexandr Trushev
b3e6e520bf IJPL-150226 Add stats for clicking on error stripe marker
This commits adds stats about clicking on stripe marker with the following payload: severity, total number of markers in a file, file type

GitOrigin-RevId: fbf54fa363471dc3c8227c4f90af6152696bbead
2024-06-04 20:06:32 +00:00
Sergei Vorobyov
0836f63d8a IDEA-352672 [Gradle|Sync] cleanup: added IntelliJ threading guard to GradleProjectResolverResultHandler
GitOrigin-RevId: 4baa07f3408814f395ec09dedf3eeb0950c596fb
2024-06-04 19:50:25 +00:00
Vladimir Parfinenko
ecac98fd39 Revert "[debugger] fix breakpoint merging, IJPL-155742"
This reverts commit b643036fd3c4e844a14fa3e4fa903d4fde6fbfad.

GitOrigin-RevId: 6b1087f06bbd00565b9a46bdbdcbe8e69996cbed
2024-06-04 19:48:05 +00:00
Rustam Vishniakov
ebebac8236 [devcontainers] IJPL-156027 Json Settings: com.intellij:app:BuiltInServerOptions.*
GitOrigin-RevId: ae37360562bfe6104d843a7f788b399b6f3b26ca
2024-06-04 19:17:55 +00:00
Rustam Vishniakov
0f4495470b [devcontainers] Settings: JavaScript:app:JsxEmmetOptions.*
GitOrigin-RevId: 4d596360a1a8d48d8e59c8885362f221007d09a7
2024-06-04 19:17:43 +00:00
Dmitry Avdeev
c97d567cf4 IDEA-354377 Create workspace via Project Wizard
status text + indent removed

GitOrigin-RevId: fc7808eb60840cc53f7118c17749b7267e7ef18f
2024-06-04 19:14:25 +00:00
Alexey Merkulov
9e5909a854 [debugger] Hide thread model counter handling from public API
GitOrigin-RevId: 56eee01ed400e242f431b7dcd004d7622ca5063f
2024-06-04 19:08:21 +00:00
Alexey Merkulov
2ea7b25fb9 [debugger] Bound threads consistency check to the pause command
So it will be dropped if the context becomes released

GitOrigin-RevId: e2443b140d462a10a6eff15d25254c5d6e12a4a2
2024-06-04 19:08:16 +00:00
Vlad Koshkin
33631e00c4 [kotlin] K2: fixes scripts red code on project re-open
GitOrigin-RevId: 355aa5d5949cfe4c5b2cbcc006aa035e39dd7b29
2024-06-04 18:37:08 +00:00
Alexey Merkulov
27bd668c67 [debugger] Anonymize error reports for non-internal users
GitOrigin-RevId: 30d3b8d15c0fa73d56b4e404ef62c875aa7da222
2024-06-04 18:22:03 +00:00
Alexander Lobas
b8a934bfbc IJPL-156059 list of Language are hardcoded
GitOrigin-RevId: 69237ebb8dd97e5e84b6dae640ccc83fdbe00322
2024-06-04 18:14:25 +00:00
Maxim.Kolmakov
a7f3f30b31 [performancePlugin] Make performance span current for commands executed via driver
Commands via Driver are executed in a different thread (JMX one) so ThreadLocal variable with current context is missing and all spans from the commands appear in the root.

GitOrigin-RevId: 646c4a5b1fa6610ce5c97bc109e74824bc32d7ad
2024-06-04 17:42:35 +00:00
Aleksey Pivovarov
c1aa63c583 EA-934127 git: fix AlreadyDisposedException
GitOrigin-RevId: e81cff46235aa018fea93fc1314b99e0a3783143
2024-06-04 17:31:13 +00:00
Alexey Belkov
56da77ddd9 [kotlin] K2 J2K: infer not-null type cast in more places
Try to avoid `expr as Type?` when `expr as Type` is possible.

Usually, this is further cleaned up to just `expr`
by the "useless cast" post-processing.

KTIJ-29147

GitOrigin-RevId: 91ee0d265b5ee0f123581df7b269181c91e96061
2024-06-04 17:08:02 +00:00
Alexey Belkov
ac6f47852b [kotlin] J2K: mark type argument of "arrayOfNulls" call as not-null
`arrayOfNulls` call returns an `Array<T?>`, but it seems that the type argument
to the call should be just `T`.

KTIJ-29147

GitOrigin-RevId: 52d73f8f35fe94fd5a4803f15731cc39bb9d0c79
2024-06-04 17:07:56 +00:00
Andrey Lisin
c2a7096de3 Cleanup: replace getTags() method with @EnvTestTagsRequired annotation
GitOrigin-RevId: 60aa962e74b98616275aac268604d9c18a38cd0d
2024-06-04 17:05:36 +00:00
Andrey Lisin
02b978c825 PY-61217 Put subprocess tests together to follow logical order
GitOrigin-RevId: a94104fd67b7c24d25845eab3277262251c5f92b
2024-06-04 17:05:29 +00:00
Andrey Lisin
4959962158 PY-61217 Run subprocess debugging tests on all CPython versions since they now pass on CPython 3.11 and 3.12
GitOrigin-RevId: 074f70e260d302b119c4e64952b5a56c5e0ad661
2024-06-04 17:05:23 +00:00
Vladimir Dolzhenko
892caf001e [kotlin] K2: Add notification for WASM targets that they are not supported
#KTIJ-30155 Fixed

GitOrigin-RevId: ab5a2319b11b1e20f6b71f5961e17595940644a1
2024-06-04 16:51:58 +00:00
Frederik Haselmeier
119a5a1744 [Kotlin] Fixed NoActualForExpectInspection showing errors for declarations annotated with OptionalExpectation
^KTIJ-30117 fixed

GitOrigin-RevId: fa03b81e410ff5dc24bbd9a48b8249454645832f
2024-06-04 16:15:23 +00:00
Sergei Tachenov
939b3d46dd IJPL-48490 Fix slow ops in ScopeEditorPanel
Migrate to AsyncTreeModel, just like with the Package Dependencies panel.

One difference is that this model needs to sort children, so introduce
a boolean parameter for that to distinguish between this and package dependencies.

Another important note is that instead of a regular NBRA, we use the model's
Invoker to retrieve package sets from the selected nodes. This is because the tree
model is single-threaded by its nature. The read lock would prevent
concurrent access, but it's still hard to reason about.

GitOrigin-RevId: 2095337ecceed015980212341e0075243d9c257e
2024-06-04 15:24:27 +00:00
Sergei Tachenov
fd9a9aa021 IJPL-155960 Move createActionHandler under slow ops section
There are other slow ops inside it already, so why keep this
one outside and get a lot of useless reports?

GitOrigin-RevId: 4444a1c871b6e2e87b651922d4cf37ae3970f490
2024-06-04 15:24:24 +00:00
Bart van Helvert
9c9a813ea2 [java] Don't run move directory with classes helper on light classes
This move directory with classes helper should only be responsible for moving Java files. #KTIJ-30171 Fixed

GitOrigin-RevId: 7d4b11ae7b0185920c60f51f7a3a4f5e1f7e7006
2024-06-04 15:10:13 +00:00
Maxim.Kolmakov
a8433123ee [performance-tests] Add new tests for SE with warmup
GitOrigin-RevId: 17d66efd3d0f9b1a11de227761c9ce32fa003328
2024-06-04 15:00:37 +00:00
Evgeny Abramov
cc938f1533 ML-based ranking in the plugin manager
(MP-6452) Fix failing project structure and packaging tests

(MP-6452) Make sure that machine learning score is calculated correctly for each plugin

Previously, there was a cache with mutable list of features. There were two issues with it. First, because of mutability, it could store mlScore for a different query sometimes. Second, there were no guarantees on consequent call of ranking and features logging before the next ranking event happens, so the feature cache could be inconsistent in certain scenarios.

(MP-6452) Introduce search index in plugin manager events that corresponds to actual query order

I also change the definition of plugin manager session. The session is restarted only in two cases: when a user clicks on the Plugins section in settings or when the search is restarted after a plugin installation.

(MP-6452) Add additional features: is result ordered by ML, is user internal, experiment group and version

(MP-6452) Fix missing date of latest plugin update, add days since latest updates and textual features

(MP-6452) Apply suggestions from the code review

(MP-6452) Integrate the ranking plugin with the search and the logging group

In feature extractors, during the first run, I calculate the features for a model to predict plugin relevance and on the second run the features to report to the MP collector (with predicted score, for example). I also implement features cache to calculate the most of the features only once

(MP-6452) Implement the baseline plugin manager session id definition and log it to FUS and MP recorders

I attach the start of a session to enableSearch method of PluginManagerConfigurable that gets triggered on "Plugins" setting group selection in the menu

(MP-6452) Add plugin for plugins ranking in the Plugin Manager

ML in SE: add embedding search integration test subsystem tag


Merge-request: IJ-MR-130364
Merged-by: Evgeny Abramov <Evgeny.Abramov@jetbrains.com>

GitOrigin-RevId: 9136d316aec2ede74bec07798dd8db16e7849f54
2024-06-04 14:58:32 +00:00
Roman Golyshev
d458731be8 KTIJ-28554 [kotlin][parcelize] Enable default implementation of ParcelizeAvailabilityProvider
It works in JPS, and enables `IdeParcelizeResolveExtension`
when there is a corresponding compiler plugin jar (namely "parcelize-compiler.jar")
specified with the `-Xplugin=` compiler argument

Currently this feature is under registry flag and disabled by default;
it should be enabled by default when it becomes clear that it
works as intended and does not break anything, and then the registry
flag should be completely removed.

Side note: `getInstance` function from `KotlinFacet.kt` returns
`compilerArguments`, but they do not include the arguments from the
"additionalArguments" sections in the Kotlin Facets.

This most probably means that currently the use-sites of this function
are not functioning properly, and need to be checked later - for example,
`KotlinSerializationEnabledChecker`

GitOrigin-RevId: 7fc0ff4dc07cf12770e004ccde93314a6b365ee2
2024-06-04 14:21:56 +00:00
Samuel Soukup
07d5ef1cb0 [ML in SE]: IJ-CR-135091 - Replace magic numbers by constants and make sure that EM categories do not overlap.
GitOrigin-RevId: 679654ebaab79bfb4ac6b3e89ee7ad0363a7d9ae
2024-06-04 14:09:55 +00:00
Pavel Kirpichenkov
0d8bae7058 [Kotlin] Add missing opt-in in test data
platform.posix.DIR is a type alias to a forward declaration
that hadn't been supported until KT-62936 was fixed.

GitOrigin-RevId: 1d726fbaa731007eb18a8c8329b7c8e358cce2f7
2024-06-04 14:06:13 +00:00
Pavel Kirpichenkov
9533a58a51 [Kotlin] Add K/N forward declarations integration test
Forward declaration switch is adjusted: don't disable services in test mode.

KTIJ-30119

GitOrigin-RevId: eadcd7661aed528d84d1dcffac18b09d52d8e0d7
2024-06-04 14:06:07 +00:00
Yann Cébron
3a4d44fce0 [devkit] PluginXmlFunctionalTest.testExtensionI18n: fix testdata
GitOrigin-RevId: 8af44344d517e3714e048f6914d401a57e9d5375
2024-06-04 13:53:05 +00:00
Yann Cébron
e11bc891e7 [devkit] PluginXmlFunctionalTest.testExtensionsHighlighting: fix testdata
GitOrigin-RevId: cb8a8bb9422fb054f167ad7807c31d5427a3b0cb
2024-06-04 13:53:01 +00:00
Yann Cébron
3b7fdf7f45 [devkit] IJPL-155995 DevKit plugin fails to add IntelliJ Platform SDK
GitOrigin-RevId: f935cd7784d238140cad8175fb57a2f3a704272f
2024-06-04 13:31:43 +00:00
Andrei.Kuznetsov
b3c882f56b IJPL-425: refactoring: drop FileIndexingJob (unneeded wrapper for FileIndexingRequest)
GitOrigin-RevId: 1ca6db07e807b8b8e8ce75ea887cd6ec6de613e4
2024-06-04 13:24:26 +00:00
Andrei.Kuznetsov
6ef4f3553f IJPL-425: refactoring: drop IndexingJob (unneeded wrapper for FileSet)
GitOrigin-RevId: 1d5d8c76cbfa922217f46ab5616428bb19a6e0c3
2024-06-04 13:24:20 +00:00
Andrei.Kuznetsov
8d91dbe24e IJPL-425: refactoring: remove redundant fields in IndexingJob
GitOrigin-RevId: 9ba3d20ddb8208920e880133a96eb1dcabf6d8dc
2024-06-04 13:24:15 +00:00
Andrei.Kuznetsov
816a427ee0 IJPL-425: refactoring: inline IndexingJob.setLocationBeingIndexed
GitOrigin-RevId: 0f8ff580220ad339197d5098f24b8eaa55e85a96
2024-06-04 13:24:10 +00:00
Andrei.Kuznetsov
2d8491b609 IJPL-425: refactoring: change signature and rename IndexUpdateRunner.indexOneFileOfJob to indexOneFileHandleExceptions
GitOrigin-RevId: e2dea0db1344ce3724d3877344628f56d30d81e2
2024-06-04 13:24:04 +00:00
Andrei.Kuznetsov
0a7f0550e6 IJPL-425: refactoring: move PCE and progress handling outside the IndexUpdateRunner.indexOneFileOfJob
GitOrigin-RevId: 9f476ec08916619f5ffe22483b70725118a923d3
2024-06-04 13:23:59 +00:00
Andrei.Kuznetsov
08a224e980 IJPL-425: refactoring: IndexUpdateRunner.indexOneFileOfJob now accepts FileIndexingJob as a parameter
GitOrigin-RevId: c6a8be88fe490a9c2e881aef602899a350b24965
2024-06-04 13:23:54 +00:00
Andrei.Kuznetsov
5968b559b0 IJPL-425: refactoring: extract method IndexUpdateRunner.runConcurrently
GitOrigin-RevId: 3f37578f2731683f9005b55fab49c34179809531
2024-06-04 13:23:48 +00:00
Kirill Likhodedov
6b6f096315 gradle: convert Groovy to Kotlin: IDEA-327336: IntelliJProjectSettingsBuilder
GitOrigin-RevId: 5c671f4202dfcdca9bda935ee588055fea09a687
2024-06-04 13:14:14 +00:00
Kirill Likhodedov
71b37c9c19 gradle: rename .groovy to .kt: IDEA-327336: IntelliJProjectSettingsBuilder
GitOrigin-RevId: 0eddf782145d186d6043a8a3639297d933645936
2024-06-04 13:14:14 +00:00
Roman Shevchenko
4000ec8f80 [platform] minor optimization in RevealFileAction + cleanup (typos; formatting)
GitOrigin-RevId: faac50569e755194e41e7330e949a34d0f7924e8
2024-06-04 12:42:50 +00:00
Roman Shevchenko
385097265e [platform] extracting a base class for building filesystem tree stats collecting visitors (IJ-CR-133215); cleanup
GitOrigin-RevId: 5d36f5539d0b969dce9cbb3531cfe0d829d49ac6
2024-06-04 12:42:50 +00:00
Anna Kozlova
71103967c2 [kotlin] k2 quick doc: support links to outer classes
^KTIJ-30141 fixed

GitOrigin-RevId: 8ff5a54f81584e3a32a764b2d23dc38ef1be54d4
2024-06-04 12:19:26 +00:00
Anna Kozlova
0b16502482 [settings] specify Any language explicitly
otherwise com.intellij.openapi.actionSystem.impl.Utils.reportEmptyTextMenuItem fails with empty presentation

https://jb-web.exa.aws.intellij.net/report/27768768

GitOrigin-RevId: c2147a9f63c8f16077cc2d935459445ddf2809f6
2024-06-04 12:19:26 +00:00
Maxim.Kolmakov
4fdfcacf73 AT-633 Report exceptions as separate failures from batch inspection tests
GitOrigin-RevId: eb55d7501142ffd4ff0cd041b3ec3058c5fe9964
2024-06-04 12:11:41 +00:00
Roman Shevchenko
f8e2a42fc9 [project] extracting API dump changes into a separate commit (2/2)
GitOrigin-RevId: 7c47e59faa037eb5c69128835cc05a4b1a99f1f9
2024-06-04 09:52:14 +00:00