Commit Graph
226012 Commits
Author SHA1 Message Date
Anna.Kozlova 779291d906 ensure fresh variables for the same context don't conflict by names (IDEA-196642) 2018-08-06 19:35:12 +02:00
Dennis Ushakov 83ed9bf603 use proper language for xml text encoding (WEB-31258) 2018-08-06 20:29:56 +03:00
Egor Ushakov 523a2ec997 compare jdk version strings correctly - do not reparse version 2018-08-06 20:06:09 +03:00
Eldar Abusalimov 83ace7852c CPP-13864 GDB: Provide a workaround for missing separate console on Windows 2018-08-06 19:43:47 +03:00
Egor Ushakov 3a06a2bba9 compare jdk version strings correctly
it was failing to match "java version "1.8.0_152"" and "1.8.0_152-release"
2018-08-06 19:42:03 +03:00
Mikhail Golubev 572fcb1625 Mind recently added @NotNull contract for PsiReference#isReferenceTo() 2018-08-06 19:38:37 +03:00
Dmitry Batkovich 61f24b3b4e resource bundles: make rename available in project view (IDEA-179826) remove odd condition 2018-08-06 19:34:43 +03:00
Dmitry Batkovich 0e4a20a098 cleanup 2018-08-06 19:34:43 +03:00
Alexey Kudravtsev 70cb988019 fix NPE 2018-08-06 19:18:50 +03:00
Mikhail Golubev 385defe38f PY-31074 Restore Quick Documentation in Python Console 2018-08-06 19:13:21 +03:00
Mikhail Golubev 34925eb8bc PY-30825 Unify how we find the element to refactor in type hinting intentions
Extracted detection of the right reference owner under the caret.
Resolving in all the different places now uses the same resolve context.
Also I reduce visibility of the shared methods.
2018-08-06 19:13:21 +03:00
Mikhail Golubev 618921d8bc PY-30825 Remove the controversial logic regarding annotating of a reference qualifier
Otherwise, we can't really tell whether the use wants to annotate the return type
of the method or the type of the qualifier in cases like the "param.met<caret>hod()".
It's better to be more explicit and ask them to invoke the intention on the right
element directly.

Handle the cases when the caret is at the end of an identifier using
TargetElementUtil#adjustOffset.
2018-08-06 19:13:21 +03:00
Mikhail Golubev 3f724495b2 PY-30713 Remove redundant casts and instanceof checks in PyAnnotateTypesIntention 2018-08-06 19:13:21 +03:00
Mikhail Golubev 29e344e4fc PY-30713 Fine-grained write actions and read-only status checks in type hinting intentions 2018-08-06 19:13:20 +03:00
Mikhail Golubev 6baab8c3e3 PY-30713 Use the same logic in isAvailable and doInvoke of type hints related intentions
Additionally, manually check that these elements are actually writable
before applying the respective changes and don't suggest these intention actions
if there are several possible definitions (though, we'd better show them all
in a popup in this case).

Otherwise, we may end up modifying dozens of library definitions without notifying
user about it anyhow in case of ambiguity in resolve results.
2018-08-06 19:13:20 +03:00
Daniil Ovchinnikov 3cf480485c [groovy] remove old parser 2018-08-06 19:09:22 +03:00
Daniil Ovchinnikov 81fa2c463e [groovy] use generated parser for docs, i.e. break last dependency on old parser 2018-08-06 19:09:22 +03:00
Kirill Likhodedov a63b7bc86c Add debug logging to track issue with disappearing "non-picked commits" highlighting in IDEA-196838 2018-08-06 18:31:28 +03:00
Mikhail Golubev 8cbb8af5c5 PY-31148 PY-10549 Avoid duplicate warnings about missing parameters in docstrings
Unfortunately, it's not easy to write a test for the original problem since
ExpectedHighlightingSet doesn't allow to keep two identical highlighting markers
for the same range in test data.
2018-08-06 18:30:14 +03:00
Mikhail Golubev 4017063bff PY-31148 Properly extract description from Sphinx ":param" tags containing type 2018-08-06 18:30:14 +03:00
Mikhail Golubev a41986b1b4 PY-31025 Properly extract description of the return value in Google docstrings
when both its type and optional name are omitted. Just as the reference implementation
in sphinxcontrib.napoleon we now require a trailing colon on the first line of a field
to treat this text as the return type, otherwise it's considered the return value description.

Also, I dropped support for named return and yield values in Google Code Style docstrings,
as Napoleon doesn't feature them as well.
2018-08-06 18:30:14 +03:00
Alexander Kass a8d1c3b958 Add javadoc IDEA-CR-35281 2018-08-06 18:12:41 +03:00
Rustam Vishnyakov 4124664602 Code Style groups 2018-08-06 18:11:08 +03:00
Sergey Ignatov 7ffd3c618d EA-125356 - NPE: ShowDiscoveredTestsAction.lambda$findMethods$ 2018-08-06 18:01:41 +03:00
Alexey Kudravtsev b050957204 fix NPE 2018-08-06 17:55:45 +03:00
Alexey Kudravtsev 0231417d8e fix NPE 2018-08-06 17:55:44 +03:00
Dmitry Batrak d1e343e07b Merge remote-tracking branch 'origin/master' 2018-08-06 17:50:00 +03:00
Dmitry Batrak 3a402c9e3e IDEA-196006 Link for files in JavaDoc generation output
existing patterns didn't work for messages of the form
<file>:<line>: error - <message>
<file>:<line>: error: <message>
2018-08-06 17:48:53 +03:00
Sergey Malenkov e6b7a752c5 Fix icon names for Darcula/Retina 2018-08-06 17:31:34 +03:00
Daniil Ovchinnikov 671d8853f7 [groovy] update test data after a2783ed229 2018-08-06 17:02:29 +03:00
Vassiliy.Kudryashov 3fa4847126 IDEA-186110 Esc doesn't close in-editor search during indexing 2018-08-06 16:44:18 +03:00
Nicolay Mitropolsky 2377666ee1 QuickEditHandler: focus owner null-check 2018-08-06 16:28:50 +03:00
Daniil Ovchinnikov 1c34af5029 disable AST loading when computing children and updating presentation of PSI based node in Project View 2018-08-06 16:22:56 +03:00
Daniil Ovchinnikov cc5ff3eac8 [groovy] updates indents settings page
- use enum for label style;
- use IntegerField for label size;
- disallow negative label size.
2018-08-06 16:19:21 +03:00
Daniil Ovchinnikov bafa226d64 clean up TargetElementUtil, apply fixes 2018-08-06 16:02:09 +03:00
Daniil Ovchinnikov 8d9afa2622 get rid of DaemonCodeAnalyzer#updateVisibleHighlighters usages 2018-08-06 16:02:08 +03:00
Konstantin Kolosovsky 44a58d2207 vcs: Add more svn tests to "VCS Tests" configuration 2018-08-06 15:54:34 +03:00
Konstantin Kolosovsky 4b3c98e5d0 svn: Remove fully commented and broken "SvnRootAboveTest", "SvnLocalChangesAndRootsTest"
* "SvnRootAboveTest" almost fully duplicates "SvnLocalChangesAndRootsTest"
* Mentioned use cases aren't tested, tests are broken and should be rewritten anyway if necessary

5bfb4c1f4c follow-up
2018-08-06 15:54:34 +03:00
Konstantin Kolosovsky 65aee4a32f svn: Refactor "ConflictCreator" 2018-08-06 15:54:34 +03:00
Konstantin Kolosovsky 7d407c13db svn: Refactor "SvnRenameTest" 2018-08-06 15:54:34 +03:00
Konstantin Kolosovsky bbf3431d94 svn: Override temp directory in tests
To make project directories be created under per-test temp directory
2018-08-06 15:54:33 +03:00
Konstantin Kolosovsky e3f07b9883 svn: Refactor "SvnTestCase.tearDown()" - simplify test directories deletion
Both working copy and repository directories will be deleted by "TempDirTestFixture.tearDown()"
2018-08-06 15:54:33 +03:00
Konstantin Kolosovsky b5a1946897 svn: Fix detecting if conflict item is file or directory in tests
If "FilePath.isDirectory()" value is incorrect, corresponding conflict change is not found
2018-08-06 15:54:33 +03:00
Konstantin Kolosovsky 6f80c67728 svn: Fix status checks in "SvnResolveTreeAcceptVariantsTest"
"local edit, incoming delete/move" conflict has "added with history" status after "mine-full" resolution
2018-08-06 15:54:33 +03:00
Konstantin Kolosovsky 8df77ac92f svn: Improve test performance - do not create unused test files 2018-08-06 15:54:32 +03:00
Konstantin Kolosovsky 3b8c961bc5 svn: Refactor "SvnResolveTreeAcceptVariantsTest" - unify conflict preparation logic 2018-08-06 15:54:32 +03:00
Konstantin Kolosovsky ae19fd9de2 svn: Refactor "SvnResolveTreeAcceptVariantsTest" - move method 2018-08-06 15:54:32 +03:00
Konstantin Kolosovsky bbfab8a2ad svn: Refactor "SvnResolveTreeAcceptVariantsTest" - remove useless deletion of all working copy files
Working copy is empty anyway
2018-08-06 15:54:32 +03:00
Konstantin Kolosovsky 7d908ea254 svn: Make "SvnResolveTreeAcceptVariantsTest" to be parameterized test 2018-08-06 15:54:31 +03:00
Konstantin Kolosovsky ebd6441899 svn: Refactor "SvnResolveTreeAcceptVariantsTest" 2018-08-06 15:54:31 +03:00