We can't use nonModal here as we are in a modal dialog already, but any isn't good either because we need to access a workspace
GitOrigin-RevId: 1c673631f3fb774a2b4c73775614357617b32103
Refactor addToken method
Refactor the addToken method to remove the originalElement parameter and streamline its usage across the visit methods. This change simplifies the method signature and ensures consistency in handling variable, field, and parameter elements.
Remove PHP module dependency.
Eliminated the `intellij.php.impl` module from the plugin's configuration and removed unused `PhpLangUtil` imports. This reduces unnecessary dependencies and simplifies the project.
Update offsets in PHP test fragments and actions
Adjusted the offset values for `name`, `color`, and `user` tokens in both `test.php_fragment` and `test2.php_fragment` files. This change ensures proper alignment with the code structure and correct token type identification.
Refactor reference check logic
Simplify conditional statement by renaming and inverting the reference check function. This improves readability and reduces the cognitive load for future code maintenance.
Simplify reference check logic in CommonActionsInvoker.kt
Refactored the code to remove type casting and streamline the reference check by introducing the `isNotThisReference` function. This improves code readability and maintainability.
Refactor token addition to include custom start offsets.
Modified the `addToken` method to accept an optional `startOffset` parameter and updated relevant calls to pass the correct offset, ensuring accurate token positioning in the PHP rename visitor logic.
Refactor logging setup in PhpRenameVisitor
Replaced direct Logger instance usage with logger<PhpRenameVisitor>() inside a companion object for consistency and cleaner code structure. This improves maintainability and follows standard logging practices.
Switch println to Logger for better logging
Replaced println statements with Logger in PhpRenameVisitor.kt to standardize logging practices. This change enables more robust and configurable logging control.
Update token type for PHP field in rename visitor
Correct the type property assignment for PHP fields from TOKEN to FIELD in the PhpRenameVisitor. This ensures that fields are accurately categorized, improving the rename functionality for PHP elements.
Add run configuration for PHP name suggestion evaluation (dev build)
fix typo
Enhance PHP rename visitor handling
Add detailed processing for different PHP elements like classes, methods, fields, functions, and parameters. Introduce utility methods for better variable and parameter handling within the rename visitor.
Optimize reference renaming in CommonActionsInvoker
Removed unnecessary logging from moveCaret and added conditional check to exclude PHP "this" references during renaming. This ensures more precise refactor operations and improves performance slightly.
update test files for PHP Rename
Split PhpRenameActionsProcessorTest into two classes
Separated tests into PhpRenameActionsProcessorTest1 and PhpRenameActionsProcessorTest2, each handling a different input file set. This change improves clarity and organization of the test files.
Remove obsolete run configuration for PHP Name Suggestion
Deleted the outdated run configuration file for the PHP Name Suggestion evaluation. This helps clean up unused configurations and streamline the project setup.
Add new PHP test cases for evaluation plugin
Introduced a new PHP file `test2.php` containing a trait `HasAuthor` with methods related to authorship functionality. Accompanied by necessary action and fragment files to support the new test cases in the evaluation plugin tests.
Merge-request: IJ-MR-142199
Merged-by: Berkay Özerbay <berkay.ozerbay@jetbrains.com>
GitOrigin-RevId: b85c18bd2d00cbb29ee6e11b2a4a2906eee69658
There is no much help from start trace in production, but this confuses EA a lot. Originally "start trace as cause" was introduced to help debugging tests. Let this feature remain active in tests only.
GitOrigin-RevId: d12dde30920e185cd33a050478d26de516b82cf6
1. Add a flag to disable write intent lock for coroutines and misc actions. Disable by default.
2. Use this flag.
3. Add an explicit wrapper for write intent lock.
GitOrigin-RevId: 7e8ca603b4e4d7d9d10bce3baeaacf0fa37fad62
Analogously to Java SSR override `handleSubstitution` method to form correct replacement of typed parameters. Added regression test.
GitOrigin-RevId: 8401f6f82d14d886c0fd60e20c0ce989387f24ab
