Commit Graph

1136 Commits

Author SHA1 Message Date
peter
4d005013e6 CodeEditUtil.addChildren: avoid returning invalid AST 2017-11-24 16:55:59 +01:00
Anna.Kozlova
c4804ea189 comments based test data for remove arg fix
assume that argument with all comments inside should be deleted
2017-11-24 11:34:19 +01:00
Tagir Valeev
cb4f3f1a89 IDEA-182526 Move assignment to field declaration swallows comments 2017-11-24 11:17:26 +07:00
Tagir Valeev
e71ffcdb58 IDEA-182004 Collection.containsAll() can be simplified in certain cases
RedundantCollectionOperation: strings externalized, description fixed
2017-11-24 10:40:51 +07:00
Tagir Valeev
0393b4fe2f IDEA-182206 Simplification for Arrays.asList().sublist().toArray() 2017-11-23 11:52:59 +07:00
Tagir Valeev
80e63e20fc DFA: support partial streams and ::isInstance method reference
Fixes:
IDEA-182519 Support non-terminated Stream API chains in data flow
IDEA-182520 Support Xyz.class::isInstance in stream/optional chains
2017-11-22 14:23:00 +07:00
Anna.Kozlova
443fa52729 restore comments on convert to local (IDEA-178942) 2017-11-21 16:51:10 +01:00
Anna.Kozlova
d6b550aa66 convert to local for switch block: add decl before switch (IDEA-181440) 2017-11-21 16:51:09 +01:00
Pavel Dolgov
4c3dfe6001 Java: Don't delete class cast when deleting unused variable (IDEA-181346) 2017-11-10 14:36:04 +03:00
Tagir Valeev
5bd30e691d IDEA-181743 IntelliJ suggests bad refactoring for compareTo with Optionals
Reference expressions are compared instead of variables now
2017-11-10 17:38:53 +07:00
Daniil Ovchinnikov
243e4d078e [jvm-lang] java: add more Create Constructor tests 2017-11-09 18:52:51 +03:00
Roman
4e8bbcd4a3 create SortContent intention to sort varargs and array initializers 2017-11-01 16:05:25 +07:00
Dmitry Batkovich
6e2c225c5e "Initialize variable" leads to an exception on invalid code IDEA-181272 2017-10-27 16:35:42 +03:00
Dmitry Batkovich
eac0894f8a fix test data 2017-10-25 15:46:06 +03:00
Tagir Valeev
0ff0cfe3bc IDEA-180862 'Wrap using Collections.singletonList' intention doesn't work with subtypes of return type
Also anonymous classes supported
2017-10-24 16:46:42 +07:00
Bas Leijdekkers
b6a75ac21d IG: fix containsConflictingDeclarations() 2017-10-22 19:41:59 +02:00
Anna.Kozlova
08752000cd fix testdata 2017-10-18 10:50:03 +02:00
Tagir Valeev
e4efb836cd RedundantStringOperationInspection: fixes after review IDEA-CR-25339
1. messages cleanup
2. new StringBuilder(""). PrintStream.println("") are warned
2017-10-17 10:58:07 +07:00
Bas Leijdekkers
8c17d9fee4 fix split-filter intention on anyMatch() 2017-10-15 11:40:59 +02:00
Bas Leijdekkers
cad8001898 grammar fix in merge and split filter intentions 2017-10-15 11:40:59 +02:00
peter
609eea57ac IDEA-178434 "Unwrap 'if' statement" produces incompilable code if variable declared in the if body shadows the outer scope variable 2017-10-13 21:17:37 +02:00
Tagir Valeev
14759e531a IDEA-180417 Generated code ("Replace with collect") is invalid follow-up
Fixed for groupingBy as well
2017-10-13 13:12:17 +07:00
Tagir Valeev
59c3fd672a IDEA-180417 Generated code ("Replace with collect") is invalid 2017-10-13 13:04:12 +07:00
Anna.Kozlova
f253087643 bring var to scope: disabled for resource variables (IDEA-180436)
EA-61004 - assert: BringVariableIntoScopeFix.invoke
2017-10-12 19:38:49 +02:00
Pavel Dolgov
24a6c66183 Java: Fixed removing unused variable occurrences from 'for' loop's update and init clauses (IDEA-180217) 2017-10-11 15:35:05 +03:00
Tagir Valeev
a07277260c DeleteSideEffectsAwareFix: do not remove message for non-expression-statement
The fix is still useful if invoked for if condition/switch expression/etc. Fixes IDEA-180372.
2017-10-11 15:51:21 +07:00
Tagir Valeev
31b328cdca RedundantStringOperation: append("") (IDEA-180178), intern()
ConstantStringInternInspection removed
2017-10-11 14:35:28 +07:00
Tagir Valeev
454efb3280 RedundantStringOperationInspection: SubstringZero and StringToString merged 2017-10-11 14:35:27 +07:00
Tagir Valeev
6fcd75db84 IDEA-180288 Quick fix breaks code: Optional.ofNullable() with not-null argument 2017-10-11 10:28:14 +07:00
Tagir Valeev
08cea712a2 MoveFieldAssignmentToInitializerInspection: allow unknown methods
As this is intention-like part of inspection (no warning), we can allow it even if we are not sure that semantics will be preserved. See comments in IDEA-177602
2017-10-09 16:38:56 +07:00
Tagir Valeev
319d4c205a ChangeToAppendUtil: do not add useless .append("")
Partially fixes IDEA-180178 String concatenation as argument to 'StringBuilder.append()' call should be smarter
2017-10-09 12:12:34 +07:00
Tagir Valeev
cdd80f8de4 UnrollLoopAction: support counting loop; limit max iterations to unroll 2017-10-09 11:24:05 +07:00
Tagir Valeev
9a91789f27 MethodReturnTypeFix: do not suggest when type refers to type parameter not available at method declaration 2017-10-09 09:27:16 +07:00
Tagir Valeev
504300662d IDEA-179382 intention to change return type works when assigning but not when passing a return value as an argument to some different method 2017-10-06 17:46:20 +07:00
Roman Shevchenko
5c5c3ce691 [java] class-like annotation wrapping in modules 2017-10-02 20:19:01 +02:00
Roman Shevchenko
d8b2de2b28 [java] fixes formatting around soft keywords 2017-10-02 17:56:32 +02:00
Roman
19551bd6af ComparatorCombinatorsInspection: support chain comparisons, provide fix 2017-10-02 18:43:25 +07:00
Tagir Valeev
389e6a828d ConstantExpressionVisitor: for class access expression return the operand type
Before for String.class the "Class<String> type was returned (instead of simply "String" type). This was usually fine, but for int.class and Integer.class the same "Class<Integer>" type was returned, despite the constants are different.
2017-09-28 13:15:14 +07:00
Roman
545ae69261 StreamApiMigrationInspection: improve stream source recognition 2017-09-27 12:28:23 +07:00
Tagir Valeev
1779a8a871 FuseStreamOperationsInspection: fixes according to review IDEA-CR-24873
1. Code sample in description
2. Supported toCollection with parameterized method-reference
2017-09-27 10:50:03 +07:00
Roman
c20bbf70d2 Simplify Stream API call chain inspection improvements: IDEA-179118 2017-09-27 09:43:29 +07:00
Anna Kozlova
0ca243309f LVTI: var -> explicit type (IDEA-179177) 2017-09-26 16:13:12 +02:00
Tagir Valeev
4e24c72077 IDEA-179557 Merge nested if's removes comment 2017-09-26 16:58:46 +07:00
Tagir Valeev
2a29c82c70 FuseStreamOperationsInspection
Fixes IDEA-179303 Suggest replacing Collectors.toList()/toSet() + collection constructor with Collectors.toCollection
2017-09-26 11:01:37 +07:00
Tagir Valeev
b2df7a760a IDEA-179490 "Can be replaced with single expression in functional style" in Java fails when field name matches class name 2017-09-26 09:44:21 +07:00
Tagir Valeev
fa6bbd0b5d CollectMigration: prepare to IncorporateStreamOperationsInspection; fix NewListTerminal to support collections only 2017-09-26 09:29:37 +07:00
Anna Kozlova
776b8f9474 LVTI: explicit variable type is redundant (IDEA-179177) 2017-09-25 15:05:22 +02:00
Tagir Valeev
29e2383afd IDEA-179370 "Constant conditions and exceptions" quickfix "Replace with 'x != null ?:'" does nothing 2017-09-22 16:20:55 +07:00
Tagir Valeev
cade4517aa IDEA-168343 Suggest to change called method return type when used in return statement 2017-09-22 14:15:40 +07:00
Tagir Valeev
dede7b30f7 IDEA-113585 Cast to Type quick fix creates code that doesn't help 2017-09-19 16:10:34 +07:00