Commit Graph
3053 Commits
Author SHA1 Message Date
Tagir Valeev 14759e531a IDEA-180417 Generated code ("Replace with collect") is invalid follow-up
Fixed for groupingBy as well
2017-10-13 13:12:17 +07:00
Tagir Valeev 59c3fd672a IDEA-180417 Generated code ("Replace with collect") is invalid 2017-10-13 13:04:12 +07:00
Anna.Kozlova 2f1a299401 captured of non-proper wildcard can't be used as solving bound (IDEA-180042) 2017-10-12 19:38:49 +02:00
Anna.Kozlova f253087643 bring var to scope: disabled for resource variables (IDEA-180436)
EA-61004 - assert: BringVariableIntoScopeFix.invoke
2017-10-12 19:38:49 +02:00
Anna.Kozlova 0056220d8b generic throwable: detect generics through ancestors (IDEA-179958) 2017-10-12 19:38:48 +02:00
Pavel Dolgov 24a6c66183 Java: Fixed removing unused variable occurrences from 'for' loop's update and init clauses (IDEA-180217) 2017-10-11 15:35:05 +03:00
Tagir Valeev a07277260c DeleteSideEffectsAwareFix: do not remove message for non-expression-statement
The fix is still useful if invoked for if condition/switch expression/etc. Fixes IDEA-180372.
2017-10-11 15:51:21 +07:00
Tagir Valeev 31b328cdca RedundantStringOperation: append("") (IDEA-180178), intern()
ConstantStringInternInspection removed
2017-10-11 14:35:28 +07:00
Tagir Valeev 454efb3280 RedundantStringOperationInspection: SubstringZero and StringToString merged 2017-10-11 14:35:27 +07:00
Tagir Valeev 6fcd75db84 IDEA-180288 Quick fix breaks code: Optional.ofNullable() with not-null argument 2017-10-11 10:28:14 +07:00
Anna.Kozlova 8b84f7ab8e include tree ancestors in type parameters iterable (IDEA-179958)
anonymous and local classes are inner classes which are not members of any other class, they are implicitly generics if applicable
2017-10-10 18:17:29 +02:00
Anna.Kozlova 79b362e643 precise rethrow: runtime exception special case for generic declared type only (IDEA-180035) 2017-10-10 18:17:29 +02:00
Anna.Kozlova 14cb19fa39 overload resolution: accept unqualified calls of static interface methods (IDEA-180236) 2017-10-09 15:00:48 +02:00
Tagir Valeev 08cea712a2 MoveFieldAssignmentToInitializerInspection: allow unknown methods
As this is intention-like part of inspection (no warning), we can allow it even if we are not sure that semantics will be preserved. See comments in IDEA-177602
2017-10-09 16:38:56 +07:00
Tagir Valeev 319d4c205a ChangeToAppendUtil: do not add useless .append("")
Partially fixes IDEA-180178 String concatenation as argument to 'StringBuilder.append()' call should be smarter
2017-10-09 12:12:34 +07:00
Tagir Valeev cdd80f8de4 UnrollLoopAction: support counting loop; limit max iterations to unroll 2017-10-09 11:24:05 +07:00
Tagir Valeev 9a91789f27 MethodReturnTypeFix: do not suggest when type refers to type parameter not available at method declaration 2017-10-09 09:27:16 +07:00
Tagir Valeev 504300662d IDEA-179382 intention to change return type works when assigning but not when passing a return value as an argument to some different method 2017-10-06 17:46:20 +07:00
Roman Shevchenko 96373cd2c9 [java] supports @uses, @provides and @hidden tags in Javadoc inspection 2017-10-05 21:25:08 +02:00
Roman Shevchenko a714a3703c [tests] merges Javadoc inspection tests; drops duplicates 2017-10-05 13:36:32 +02:00
Roman Shevchenko 5c5c3ce691 [java] class-like annotation wrapping in modules 2017-10-02 20:19:01 +02:00
Roman Shevchenko d8b2de2b28 [java] fixes formatting around soft keywords 2017-10-02 17:56:32 +02:00
Roman 19551bd6af ComparatorCombinatorsInspection: support chain comparisons, provide fix 2017-10-02 18:43:25 +07:00
Anna.Kozlova d13ad07be9 LVTI: don't report resource list as multiple var declaration (IDEA-CR-24864) 2017-10-02 11:52:51 +02:00
Anna.Kozlova aa8576f3ce LVTI: shrink the highlighting range
move functional expression errors to var declaration
2017-10-02 11:52:51 +02:00
Anna.Kozlova 9728678ff4 method references: don't swallow errors during method ref inference (IDEA-179706) 2017-09-29 14:31:21 +02:00
Tagir Valeev 389e6a828d ConstantExpressionVisitor: for class access expression return the operand type
Before for String.class the "Class<String> type was returned (instead of simply "String" type). This was usually fine, but for int.class and Integer.class the same "Class<Integer>" type was returned, despite the constants are different.
2017-09-28 13:15:14 +07:00
Roman 545ae69261 StreamApiMigrationInspection: improve stream source recognition 2017-09-27 12:28:23 +07:00
Tagir Valeev 1779a8a871 FuseStreamOperationsInspection: fixes according to review IDEA-CR-24873
1. Code sample in description
2. Supported toCollection with parameterized method-reference
2017-09-27 10:50:03 +07:00
Roman c20bbf70d2 Simplify Stream API call chain inspection improvements: IDEA-179118 2017-09-27 09:43:29 +07:00
Anna Kozlova 0ca243309f LVTI: var -> explicit type (IDEA-179177) 2017-09-26 16:13:12 +02:00
Anna.Kozlova 643e046c85 EA-107704 - assert: InferenceSession.<init> 2017-09-26 14:33:30 +02:00
Tagir Valeev 4e24c72077 IDEA-179557 Merge nested if's removes comment 2017-09-26 16:58:46 +07:00
Tagir Valeev 2a29c82c70 FuseStreamOperationsInspection
Fixes IDEA-179303 Suggest replacing Collectors.toList()/toSet() + collection constructor with Collectors.toCollection
2017-09-26 11:01:37 +07:00
Tagir Valeev b2df7a760a IDEA-179490 "Can be replaced with single expression in functional style" in Java fails when field name matches class name 2017-09-26 09:44:21 +07:00
Tagir Valeev fa6bbd0b5d CollectMigration: prepare to IncorporateStreamOperationsInspection; fix NewListTerminal to support collections only 2017-09-26 09:29:37 +07:00
Anna Kozlova 776b8f9474 LVTI: explicit variable type is redundant (IDEA-179177) 2017-09-25 15:05:22 +02:00
Tagir Valeev 29e2383afd IDEA-179370 "Constant conditions and exceptions" quickfix "Replace with 'x != null ?:'" does nothing 2017-09-22 16:20:55 +07:00
Tagir Valeev cade4517aa IDEA-168343 Suggest to change called method return type when used in return statement 2017-09-22 14:15:40 +07:00
Anna Kozlova e22a89050d LVTI: un-capture wildcards for variable declarations 2017-09-19 20:13:16 +03:00
Anna Kozlova e38b24c694 LVTI: ensure standalone context for vars 2017-09-19 20:13:15 +03:00
Tagir Valeev dede7b30f7 IDEA-113585 Cast to Type quick fix creates code that doesn't help 2017-09-19 16:10:34 +07:00
Anna Kozlova 2f165da164 LVTI: accept explicit array types, javadoc (follow IDEA-CR-24690) 2017-09-19 09:28:42 +03:00
Tagir Valeev 36999ebfc4 IDEA-179128 Quick-fix for "'if' statement has empty body" 2017-09-19 13:04:21 +07:00
Anna Kozlova 29bc5a12c0 LVTI: warnings for var as class name (IDEA-178868) 2017-09-18 19:05:20 +03:00
Anna Kozlova 2180c05b71 initial highlighting for LVTI (IDEA-178868) 2017-09-18 17:04:30 +03:00
Tagir Valeev d7f09f6cdd StreamToLoop: support array slice (Arrays.stream(arr, from, to)) 2017-09-18 17:30:53 +07:00
Tagir Valeev 7345e8b0ef UnrollLoopAction: fixes according to review IDEA-CR-24513
1. Check that loop parameter is not written
2. Support List.of, Collections.singleton, Collections.singletonList
3. Support if w/o braces
4. Support break not in last position
2017-09-18 16:37:40 +07:00
Tagir Valeev 717076ee3c SimplifyForEachContext#from: fix nullability problem
EA-107550 - NPE: SimplifyForEachInspection.extractLambdaFromForEach
2017-09-18 15:21:32 +07:00
peter dd920e884e completion: place functional expressions after variables of expected type (IDEA-174428, IDEA-178600) 2017-09-15 22:04:11 +02:00