Commit Graph
232768 Commits
Author SHA1 Message Date
Anna.Kozlova 316f8bfc63 change extends <-> implements: ensure resulted list is formatted (IDEA-201751)
lists are created from light elements which are created from canonical texts and they just do not contain whitespaces
2018-11-06 19:04:10 +01:00
Anna.Kozlova b7c8e98770 ensure inspection provides expected getShortName() used in tests 2018-11-06 19:04:10 +01:00
Roman Shevchenko f7a51ab756 [tests] extracts helper method 2018-11-06 18:48:42 +01:00
peter e206d805a6 less log spam when loading stubs for a file deleted from disk (IDEA-200475) 2018-11-06 18:39:04 +01:00
Daniil Ovchinnikov 36f1ba94d1 [groovy] rename PropertyResolveResult to AccessorResolveResult 2018-11-06 20:25:11 +03:00
Daniil Ovchinnikov fdd8f78e08 [groovy] invert inverted condition 2018-11-06 20:25:11 +03:00
Nadya Zabrodina 7a70c87d89 shelf: create separated methods for external usages, make others private
* modify shelves model inside private methods and do not use as return value if possible;
* do not change parameter value in public method restore - get a copy from model by name;
* create 2 separated methods to delete list completely or mark as deleted;
* move additional empty checks inside saveRemainingPatchesIfNeeded;
* add javadoc;
2018-11-06 20:24:38 +03:00
Nadya Zabrodina 546b19b94b shelf: make restore method more safe - change list from model if exist 2018-11-06 20:24:38 +03:00
Nadya Zabrodina 568ba52997 shelf: cleanup - rename methods 2018-11-06 20:24:38 +03:00
Nadya Zabrodina 4ae7efb380 shelf: make shelf list copy creation package private 2018-11-06 20:24:38 +03:00
Nadya Zabrodina 5cbbf62377 shelf: create shelf delete message manually, remove useless property 2018-11-06 20:24:38 +03:00
Nadya Zabrodina ed02283896 shelf: add tests for unshelve and delete operations 2018-11-06 20:24:37 +03:00
Nadya Zabrodina d2d7a09227 shelf: cleanUp - rename 2018-11-06 20:24:37 +03:00
Nadya Zabrodina 5c3bdfbc02 shelf: cleanUp - extract shelf delete logic to ShelveChangesManager 2018-11-06 20:24:37 +03:00
Nadya Zabrodina 74fae6b7d2 shelf: change cleaning shelf strategy and action
* convert system unshelved lists to deleted;
* clean all deleted list older than a week;
* remove clean system unshelved from clean action and appropriate dialog;
* mark system list as deleted when unshelve performed and remove markToDelete option;
2018-11-06 20:24:37 +03:00
Nadya Zabrodina 5b5f51dfcf shelf: show only latest notification for undo shelf deletion
* do not keep all "undo delete" notification valid cause it can produce useless data storing; it's enough to show only latest one;
* check that we can restore deleted lists when undo or warn;
* add util method to show only one notification of type;
2018-11-06 20:24:37 +03:00
Nadya Zabrodina 2251e3aaee shelf: IDEA-167703 Shelf deletion undo instead of confirmation
* provide undo action with notification instead of confirmation;
* return newly created recycled/deleted list as return value;
* remember original changelist date to proper undo action;
* add Show Recently Deleted action;
* reword text in the delete notification;
2018-11-06 20:24:37 +03:00
Nadya Zabrodina b860b421c1 shelf: cleanup - DRY 2018-11-06 20:24:37 +03:00
Nadya Zabrodina 62e4f6dd19 shelf: cleanup - use Objects.equals 2018-11-06 20:24:36 +03:00
Nadya Zabrodina acb49d7a03 shelf: cleanup - reuse existing method and optimize error notifications 2018-11-06 20:24:36 +03:00
Nadya Zabrodina 5dc71a66cb shelf: change Restore action to be applied for deleted changeLists 2018-11-06 20:24:36 +03:00
Nadya Zabrodina 3babcc4455 shelf: add deleted flag for shelved list, add Recently Deleted in Shelf Tab
* show recently deleted shelved changeLists in a separated node;
* delete list completely only when delete action performed for recently deleted list; otherwise mark list as deleted;
2018-11-06 20:24:36 +03:00
Nadya Zabrodina d0ff8b6f27 shelf: cleanup - add static import 2018-11-06 20:24:36 +03:00
Nadya Zabrodina c68efae239 shelf: refactoring - change SHELVED_CHANGELIST data keys to list 2018-11-06 20:24:36 +03:00
Nadya Zabrodina f959ab0d4c shelf: cleanup 2018-11-06 20:24:36 +03:00
Nadya Zabrodina 093d3709aa shelf: make getSelectedLists method more flexible for tree structure changes
* delete hacky code of getting certain path component instead of filtering paths by type;
2018-11-06 20:24:35 +03:00
Nadya Zabrodina 34ba45c6ff shelf: add default rendering for text 2018-11-06 20:24:35 +03:00
Nadya Zabrodina 9ec2259450 shelf: remove entire shelved changelist if all changes have been removed 2018-11-06 20:24:35 +03:00
Nadya Zabrodina 29bcffe991 shelf: cleanup - remove code duplication 2018-11-06 20:24:35 +03:00
Nadya Zabrodina 8f1f7d3dc7 shelf: cleanup - inline vars, use direct sort method, optimize imports 2018-11-06 20:24:35 +03:00
Nadya Zabrodina 851e833608 shelf: refactoring - extract methods, inline recycling
* create separated methods for 2 cases:
 1. only update modified old list
 2. update modified old list and create new separated recycled list
  with unshelved changes;
* inline recycled method for second case to avoid useless view update;
* update view after all (notify changes);
2018-11-06 20:24:35 +03:00
Nadya Zabrodina 141aa56bea shelf: refactoring - extract separated methods, rename and simplify
* create separated methods for filtering changes/binaries in shelveList;
* simplify recycle method - now it marked as recycled;
* extract saveListAsScheme method with addition empty check;
2018-11-06 20:24:34 +03:00
Nadya Zabrodina 0855936931 shelf: cleanup - rename method and add annotation 2018-11-06 20:24:34 +03:00
Nadya Zabrodina dbe37aac7f shelf: cleanup - rename var, change to forEach 2018-11-06 20:24:34 +03:00
Nadya Zabrodina 71d9016107 shelf: cleanup - extract method 2018-11-06 20:24:34 +03:00
peter 6a27b1b5f7 enable completion proximity sorting in files with no module, e.g. scratches (IDEA-201188) 2018-11-06 18:23:26 +01:00
Roman Shevchenko 027dda9f9c [tests] extracts helper method 2018-11-06 18:05:19 +01:00
Andrey Vlasovskikh 488d17e5ac Disable Run Anything in PyCharm 2018-11-06 20:03:02 +03:00
Dmitry Trofimov 4c45cb8cc4 Cleanup 2018-11-06 17:48:47 +01:00
peter aa825c4bbb IDEA-201678 Analyze stacktrace hangs 2018-11-06 17:46:20 +01:00
Dmitry Trofimov feae80fb90 Avoid duplication of documentation entries; simplify code 2018-11-06 17:44:35 +01:00
Dmitry Trofimov 30e096b858 Fix usage after rename 2018-11-06 17:44:35 +01:00
Dmitry Trofimov 6862769aa2 Handle builtins for external quick doc 2018-11-06 17:44:35 +01:00
Roman Shevchenko f15d638fb9 Cleanup (warnings; formatting) 2018-11-06 17:43:33 +01:00
Egor Ushakov c7b6c69442 do not invoke methods for instanceof evaluation 2018-11-06 19:39:04 +03:00
Vladimir Krivosheev 400a837a4f IDEA-201793 Find Action for 'Run Configuration Templates' opens active run configurations editor for current project 2018-11-06 17:17:09 +01:00
Mikhail Golubev 4fa85a78de RM-18328 Update Tips of the Day for PyCharm 2018.3 2018-11-06 19:12:31 +03:00
Alexey Kudravtsev b4195182c4 cleanup 2018-11-06 19:10:00 +03:00
Alexey Kudravtsev f1b217be4c fail fast when creating range marker with invalid offsets from virtual file in presence of cached document 2018-11-06 19:09:59 +03:00
Alexey Kudravtsev ba5dd7a2ee on document load invalidate markers which were created with invalid offsets from virtual file when validity couldn't be verified 2018-11-06 19:09:59 +03:00