Commit Graph

276484 Commits

Author SHA1 Message Date
Nikita Eshkeev
299e3d31e1 [codeInsight] IDEA-113640 Provide intention to combine System.out.println(String.format(...)) into System.out.printf
This patch fixes the notes from the code review, it inclues:

- renaming method to methodNameReference for variables that contain the name of a method that is being called, i.e. either `println` or `print` or `format`
- using a different overloaded createProblemDescriptor method that does not accept a `TextRange`
- using `getParent` in quick fixes to get the `PsiMethodExpressionCall`
- proper handling arguments with parenthesis

Signed-off-by: Nikita Eshkeev <nikita.eshkeev@jetbrains.com>

GitOrigin-RevId: ea1e335372bf7b1ce3e6c87a3816baa0ab54e11e
2020-05-06 13:46:11 +00:00
Dmitry Batrak
7f537d3466 IDEA-238872 Cursor On Folded Block Is Not Intuitive
GitOrigin-RevId: c90073a7ae23da573da8dba3af72d128f1c36e79
2020-05-06 13:15:07 +00:00
Alexandr Suhinin
5347c755c7 IDEA-CR-62340: move common prefix out of the error message & test expected errors messages
GitOrigin-RevId: 218608616889b2021860dc1ec31d5a30b30ebfb6
2020-05-06 13:15:07 +00:00
Alexandr Suhinin
e71428cc30 extract method: fix error messages
GitOrigin-RevId: a24365ff57b8a7389900e84f829375e31283ee52
2020-05-06 13:15:07 +00:00
Sergey Patrikeev
6dd0901ca0 Revert "Fix return value of EmptyInputDataDiffBuilder and MapInputDataDiffBuilder."
This reverts commit 8308aaac

GitOrigin-RevId: b8eef48ffb606aa1f3f202a896132323812fd210
2020-05-06 13:15:07 +00:00
Sergey Patrikeev
882a041682 Revert "Indexes: revert "first — map, second — update data structure" for MapReduceIndex."
This reverts commit 83350764

GitOrigin-RevId: 249bf20b15f69102d835c5351001983d98806d34
2020-05-06 13:15:07 +00:00
Vitaliy.Bibaev
ded42d0313 IDEA-240174 Allow using a simple class name instead of fully qualified name (fix test data)
GitOrigin-RevId: fdd5eb1cc0f15000cb9046b11483c1bb6d72a5f6
2020-05-06 12:26:47 +00:00
Vitaliy.Bibaev
01a8b27fcd IDEA-240174 Allow using a simple class name instead of fully qualified name
GitOrigin-RevId: 0062123580edab9d0628d6dd2a2e1593d6a96562
2020-05-06 12:26:47 +00:00
dmitriy.tseyler
87bbcc2064 make project path macro manager not final
GitOrigin-RevId: 928edc3dbd78b5e1d363e2664d02d6687ac1937f
2020-05-06 12:26:47 +00:00
Dmitry Batrak
48132e6b4a IDEA-240181 Leaked references to EditorProvider on plugin unload
GitOrigin-RevId: 10ac525867d471a5acd974999565265bec7b97d6
2020-05-06 11:58:04 +00:00
Sergey Patrikeev
6e1a7c55b1 Indexes: revert "first — map, second — update data structure" for MapReduceIndex.
MapReduceIndex firstly maps input using provided indexer. Then it updates internal IO data structures.
FileBasedIndexImpl needs that the first part is decoupled from the second because it sets up "buffering state" policy for each update. Input mapping may take a long time, so "buffering state" may be locked for too long. This commit fixes "2bd7aed: InvertedIndex: simplify update() method signature. Clients don't need Computable<Boolean>.

GitOrigin-RevId: cc959312ea2511e48e4e1ec73e2a202c6c2528f5
2020-05-06 11:58:04 +00:00
Sergey Patrikeev
deab14aa55 Fix return value of EmptyInputDataDiffBuilder and MapInputDataDiffBuilder.
EmptyInputDataDiffBuilder used to return "true" even if data hasn't changed.

GitOrigin-RevId: 8308aaac1a09b4be7f0c1fc455d0ecbd5457db5e
2020-05-06 11:58:04 +00:00
Alex Plate
5b079513c0 [Workspace Model] Refactor workspaceModel listener in legacy bridge
GitOrigin-RevId: f4819209587bb4de22b09754b03e67619b19f09e
2020-05-06 11:44:28 +00:00
Nikolay Chashnikov
2d1d02f505 [platform] mark webHelpProvider extension point as dynamic (IDEA-240187)
GitOrigin-RevId: cff8b0fda3435cf030542f601a1b31703688e6b3
2020-05-06 11:29:09 +00:00
Nicolay Mitropolsky
3b774a8c82 Uast: CACHED_UELEMENT_KEY removed (IDEA-234777)
GitOrigin-RevId: 5087be2e5ea595801d664eb438c45e89603c4b6c
2020-05-06 11:23:12 +00:00
Eugene Zhuravlev
7f19039ea3 explicitly declare dependency on a dynamic EP (IDEA-CR-62338)
GitOrigin-RevId: 5d7734ed0ed64427be252e09e935bf0ee3ffac58
2020-05-06 11:23:12 +00:00
Ilia Shulgin
36fce9cb86 IJI-244 Use PythonHelpersLocator to resolve paths to jupyter frontend files
GitOrigin-RevId: 776300b076d8599d45ce70587e3064274ce47313
2020-05-06 11:11:20 +00:00
Alexandr Suhinin
90a476deb1 EA-231509: dont use PsiType.NULL as a return type
GitOrigin-RevId: 23f8141f25a7b1ba7779debe97002663c543be31
2020-05-06 11:00:24 +00:00
Kirill Kirichenko
897ea7110a Fix tooltips in Inspection Widget, update icons and button text color
GitOrigin-RevId: 8048be195688f8b2b40283075fbc144b3157131d
2020-05-06 11:00:24 +00:00
Artemiy Sartakov
797f33df75 ProjectProblemsView: make hints text red, move settings to context menu
GitOrigin-RevId: 1f23e96c7e2ff544415a830f165017a556edd98e
2020-05-06 11:00:24 +00:00
Anna Marchenko
eaad9a461e Put memory snapshots created during unloading failure to memorySnapshots dir
GitOrigin-RevId: 38cf1b76a95e9838026ca5adecb2e432f073cf5b
2020-05-06 10:42:41 +00:00
Mikhail Mazurkevich
d935337466 [jps-cache] Publish caches with commit's hash as name
GitOrigin-RevId: 3380569c4c33d43910d3d1045baf64313f0ee679
2020-05-06 10:36:41 +00:00
Eugene Zhuravlev
fa6290b09b javadoc added
GitOrigin-RevId: ee6b957915bfb0fa50829faa6d54822cd8c722c3
2020-05-06 10:36:41 +00:00
Tagir Valeev
0a990c728e Better disjoint range presentation, fix testdata
GitOrigin-RevId: 0934bdf41959062204e50066356e21c1ae0be2fa
2020-05-06 10:36:41 +00:00
Tagir Valeev
9c748a27e2 parseNormalStackTraceLine: take into account STANDALONE_AT
GitOrigin-RevId: bded7f001325da88dfc4ed755935c09d8186f685
2020-05-06 10:36:41 +00:00
Tagir Valeev
046b9b79f1 UsageInfo2UsageAdapter#getElement @Nullable; null-check added (IDEA-CR-62327)
GitOrigin-RevId: 416b388a98da6bb5f4fc8a91af0db3e2bd291ed5
2020-05-06 10:36:41 +00:00
Tagir Valeev
845da23990 IDEA-204608 Integrate production stacktraces into static nullability analysis (first draft)
Recognized exceptions:
- Assertion error (get value filter from condition)
- AIOOBE (get value filter from array index)
- NPE when JEP-358 works (value filter is simply null)
- CCE (get value filter from actual exception type)
- Explicit throw (find surrounding if/switch or previous if and define filter from condition)

TODO:
- Recognize failing method contracts (e.g. Objects.requireNonNull)
- Recognize JB notnull instrumentation
- Filter by stack-trace
- Externalize messages

GitOrigin-RevId: a7bac13663d0b18ddede0455ab25ec0cb4752976
2020-05-06 10:36:41 +00:00
Tagir Valeev
f0f24ad59e LongRangeSet: better presentation for disjoint sets
GitOrigin-RevId: 4f3ecbe3d6cf391b9195123a8ca4876ea1a19aa3
2020-05-06 10:36:41 +00:00
Tagir Valeev
068485bb39 DfConstantType: PsiType presentation
GitOrigin-RevId: 43aa2d579a1e1d251fdb7dcdc4524f6726131ce7
2020-05-06 10:36:41 +00:00
Tagir Valeev
81e8a05733 tryNegate for ranges
GitOrigin-RevId: 795a566407f6733d1861dff34b82a9b1dd8a8f88
2020-05-06 10:36:41 +00:00
Tagir Valeev
799c902d55 LongRangeSet: subtract fixed for modRange
GitOrigin-RevId: e366f4e42e83bddc3fa898c55de616dbbaf13d5f
2020-05-06 10:36:41 +00:00
Alexandr Suhinin
71200e29f8 IDEA-CR-62339: dont report excluding fields & clarify event name
GitOrigin-RevId: c73f60319ba144df3e7368bae7e31c0ef43184c2
2020-05-06 10:19:46 +00:00
Dmitry Batrak
ce64696fce IDEA-168218 'Copy as Rich Text' should use some fallback font
GitOrigin-RevId: 81f06315e0f3decdd6a868aa8e89b09203c22212
2020-05-06 10:13:48 +00:00
Egor Ushakov
75a47ba64c removed 2 strange spaces
GitOrigin-RevId: 3fb24a88cc2f43b5cfbb0a4f76a6971de1a5d257
2020-05-06 10:13:48 +00:00
Mikhail Golubev
4d2f1a33b1 Reduce memory footprint of PyPI package cache by re-using PackageInfo.EMPTY singleton
Previously, it wasn't considered when deserializing the map from JSON.
For the map with 231k entries it's a saving of about 4 Mb (1/7).

GitOrigin-RevId: 94676157ea09b7c2dc05eab241abf4cef4631ad6
2020-05-06 09:53:58 +00:00
Vladimir Krivosheev
243bd79d6f assign unsorted to module level to avoid concurrent access during parallel module loading
GitOrigin-RevId: 541b3f796568486415cce03eaf8b09bf85105242
2020-05-06 09:45:40 +00:00
Vladimir Krivosheev
eeeddb5052 avoid removing connection on disconnect from list on each disconnect because removing is a linear operation
GitOrigin-RevId: df90d83f66ae2ab2876a9d11223b1ae5c8fa81eb
2020-05-06 09:45:40 +00:00
Vladimir Krivosheev
4f131e54b3 StubIndexImpl - remove outdated storage file
GitOrigin-RevId: ac02af76b140c053aa6c1de5d0c58fb07babf5af
2020-05-06 09:45:40 +00:00
Vladimir Krivosheev
aa5d1c3d0a lazy compute source file to avoid exceptions on tear down if set up was not performed correctly
GitOrigin-RevId: 44ab3060dca5c5e7f399cbc478776fb85352f7bb
2020-05-06 09:45:40 +00:00
Vladimir Krivosheev
46ac5712b5 SenderPreloadingActivity should not use yet another pooled thread on preloading
GitOrigin-RevId: 9789148ab357162114927a48c073cd7a9e1c5f05
2020-05-06 09:45:40 +00:00
Vladimir Krivosheev
56b677a139 convenient way to get editors stream to avoid creating intermediate list/array
GitOrigin-RevId: cc6293bee95bf2cb1cee219f318d34ea2562511c
2020-05-06 09:45:40 +00:00
Vladimir Krivosheev
fb0d82914a do not execute JBCefStartup in tests
GitOrigin-RevId: 654aff01054c3832a402d2fd1356bddc4857a69e
2020-05-06 09:45:40 +00:00
Vladimir Krivosheev
4759539c14 get rid of useless xpointer (part 1)
GitOrigin-RevId: 3224aeb7110e35108d80cd8c14e6fdab53890cf3
2020-05-06 09:45:40 +00:00
Vladimir Krivosheev
4318898c50 cleanup
GitOrigin-RevId: 09e062d39c060ca8996abd9b6bfaab58d39c7d96
2020-05-06 09:45:40 +00:00
Konstantin Aleev
d0d5adbd5d [service-view] make Show Services action enabled only in Services tool window
GitOrigin-RevId: bad66ec273a4800e77ea251593722f5565f6a62f
2020-05-06 09:45:40 +00:00
Aleksey Pivovarov
b892a8a3f1 vcs: fix widget disposal checks during plugin unloading
GitOrigin-RevId: 63cd290b973414449c055d2222733bdd210a3037
2020-05-06 09:24:43 +00:00
Aleksey Pivovarov
0c0e9a7e4c vcs: do not leak CommitExecutor via CommitWorkflowManager on plugin unloading
GitOrigin-RevId: 8e0fb57e77857fa5c176e75bb1a9ad6278801189
2020-05-06 09:24:43 +00:00
Olga.Klisho
e8c34977ec IDEA-238461 fix + test added
GitOrigin-RevId: b9f1aba1cc04c07c7ea3bb75eaad0449c5f0ad8b
2020-05-06 09:24:43 +00:00
Olga.Klisho
24356ef062 IDEA-238461 fix + test added
GitOrigin-RevId: 5877a5e3b416869b1e427ca2d4af10b32ecb3ad7
2020-05-06 09:24:43 +00:00
Mikhail Mazurkevich
c12158e854 [jps-cache] Use rename of metadata file instead of copy
GitOrigin-RevId: 8857d995ce1a9f1572f04622c67e37a496bacbc6
2020-05-06 09:24:43 +00:00