Commit Graph
6721 Commits
Author SHA1 Message Date
Anna.Kozlova 2658d37da0 inference: don't remember captured wildcard with non-proper bound (IDEA-180042)
later check could fail e.g. if bound was created inside one of nested session
2017-10-17 17:58:55 +02:00
Anna.Kozlova 3b40515140 show method parameters: ensure inference results on wrong overloads not cached (IDEA-177725) 2017-10-17 11:48:38 +02:00
Anna.Kozlova bffca304b9 glb: ensure each super class processed once (IDEA-176779) 2017-10-17 11:48:38 +02:00
Anna.Kozlova 465458db4d method references: don't fall to raw substitutor with second search (IDEA-180615) 2017-10-17 11:48:38 +02:00
Yaroslav Lepenkin c6d8b2f05e join lines do not merge closing brace and catch keyword, when 'catch on new line' enabled (IDEA-179581) 2017-10-17 10:21:10 +03:00
Tagir Valeev e4efb836cd RedundantStringOperationInspection: fixes after review IDEA-CR-25339
1. messages cleanup
2. new StringBuilder(""). PrintStream.println("") are warned
2017-10-17 10:58:07 +07:00
Pavel Dolgov 16cbf02774 Java: Add conditional return when replacing duplicate fragment (IDEA-180601) 2017-10-16 17:41:29 +03:00
Dmitry Batrak 47d248a44b disable bullets in Javadoc inheritance list
list-style attribute used in standard javadoc's stylesheet seems to be
unsupported by JDK's HTML kit
(following IDEA-107790)
- fix tests
2017-10-16 12:33:59 +03:00
Anna.Kozlova 69a5061bf7 inline class to anonymous in exp lambda (IDEA-180491) 2017-10-16 09:39:41 +02:00
Bas Leijdekkers 8c17d9fee4 fix split-filter intention on anyMatch() 2017-10-15 11:40:59 +02:00
Bas Leijdekkers cad8001898 grammar fix in merge and split filter intentions 2017-10-15 11:40:59 +02:00
peter 45c3906af1 a rough fix for dfa false positive with nested for loop over a reassigned array variable (IDEA-CR-25468) 2017-10-14 07:53:14 +02:00
peter 609eea57ac IDEA-178434 "Unwrap 'if' statement" produces incompilable code if variable declared in the if body shadows the outer scope variable 2017-10-13 21:17:37 +02:00
Anna.Kozlova ef689b16b1 LVTI: warn on references to illegal class var (IDEA-180079) 2017-10-13 20:25:49 +02:00
Anna.Kozlova 084655d49f don't capture when checking subtypes deep in hierarchy (IDEA-179850) 2017-10-13 19:36:58 +02:00
Maxim.Mossienko 418d31e9e8 Java static imports are not classified as imports in Find Usages (IDEA-180332) 2017-10-13 15:32:41 +02:00
Eugene Zhuravlev 3233c3606c IDEA-176693 incremental modules compilation 2017-10-13 14:34:54 +02:00
peter ceb018b369 complete java class keywords after top-level annotation
regression after IDEA-CR-25484
2017-10-13 13:32:10 +02:00
Anna.Kozlova 6d9327a71f lvti: additional test data for projections 2017-10-13 12:45:56 +02:00
Anna.Kozlova 250956f8b0 report inference error if resolution failed (IDEA-179978)
in the issue, non-vararg overload candidate was chosen cause it was not filtered as inapplicable
2017-10-13 10:47:47 +02:00
peter 44a2ffa2ff JavaKeywordCompletion: simplify
make short code out of long ElementFilters
remove dead logic
cleanup unused filters
also fixes IDEA-179855 Double "final" suggestion after annotation
2017-10-13 09:49:22 +02:00
Tagir Valeev 14759e531a IDEA-180417 Generated code ("Replace with collect") is invalid follow-up
Fixed for groupingBy as well
2017-10-13 13:12:17 +07:00
Tagir Valeev 59c3fd672a IDEA-180417 Generated code ("Replace with collect") is invalid 2017-10-13 13:04:12 +07:00
Tagir Valeev 326b6c5ba0 Idempotent loop body inspection
Fixes IDEA-180227 Better infinite loop detection
2017-10-13 12:53:40 +07:00
peter 94adcce99f infer nested foreach parameter nullability (IDEA-175736) 2017-10-12 20:02:39 +02:00
peter 4eb2fe474e hardcode Map#get as having unknown nullity (IDEA-176626)
until we have a better solution
2017-10-12 20:02:39 +02:00
peter 6551b38303 IDEA-179934 Action "Complete current statement" introduces incorrect code 2017-10-12 20:02:38 +02:00
Anna.Kozlova 2f1a299401 captured of non-proper wildcard can't be used as solving bound (IDEA-180042) 2017-10-12 19:38:49 +02:00
Anna.Kozlova f253087643 bring var to scope: disabled for resource variables (IDEA-180436)
EA-61004 - assert: BringVariableIntoScopeFix.invoke
2017-10-12 19:38:49 +02:00
Anna.Kozlova 0056220d8b generic throwable: detect generics through ancestors (IDEA-179958) 2017-10-12 19:38:48 +02:00
Pavel Dolgov 0fe0c296c4 Java: Extract method from similar expressions by introducing a parameter (IDEA-179924, IDEA-180107) 2017-10-12 16:02:04 +03:00
peter abca97e2ad IDEA-178922 A few more null annotation problems with arrays 2017-10-11 22:01:07 +02:00
Anna.Kozlova 74d1bdb5f3 safe delete: ignore imports on inner classes (IDEA-180327) 2017-10-11 18:16:56 +02:00
Pavel Dolgov 8e22643771 Java: Fixed safe-deleting variable used in 'for' loop's update or init clause (IDEA-180217) 2017-10-11 15:35:05 +03:00
Pavel Dolgov 24a6c66183 Java: Fixed removing unused variable occurrences from 'for' loop's update and init clauses (IDEA-180217) 2017-10-11 15:35:05 +03:00
Anna.Kozlova 4e2a83d6d0 unused parameter: correctly ignore parameters used in overridden methods
when graph was build over not project scope (IDEA-180281)
2017-10-11 12:09:57 +02:00
Tagir Valeev a07277260c DeleteSideEffectsAwareFix: do not remove message for non-expression-statement
The fix is still useful if invoked for if condition/switch expression/etc. Fixes IDEA-180372.
2017-10-11 15:51:21 +07:00
Tagir Valeev 31b328cdca RedundantStringOperation: append("") (IDEA-180178), intern()
ConstantStringInternInspection removed
2017-10-11 14:35:28 +07:00
Tagir Valeev 454efb3280 RedundantStringOperationInspection: SubstringZero and StringToString merged 2017-10-11 14:35:27 +07:00
Tagir Valeev 6fcd75db84 IDEA-180288 Quick fix breaks code: Optional.ofNullable() with not-null argument 2017-10-11 10:28:14 +07:00
Anna.Kozlova 8b84f7ab8e include tree ancestors in type parameters iterable (IDEA-179958)
anonymous and local classes are inner classes which are not members of any other class, they are implicitly generics if applicable
2017-10-10 18:17:29 +02:00
Anna.Kozlova 79b362e643 precise rethrow: runtime exception special case for generic declared type only (IDEA-180035) 2017-10-10 18:17:29 +02:00
Pavel Dolgov f3bfbb473f Java: Extract method from duplicates where some of parameters are hard-coded (IDEA-180092) 2017-10-10 13:23:41 +03:00
Egor Ushakov fb3a605637 IDEA-180061 Debugger evaluates private field instead of captured local 2017-10-10 10:04:15 +03:00
Tagir Valeev cf615a6c99 DataFlowInspection: detect possible ArrayStoreException 2017-10-10 09:37:12 +07:00
Anna.Kozlova 14cb19fa39 overload resolution: accept unqualified calls of static interface methods (IDEA-180236) 2017-10-09 15:00:48 +02:00
Pavel Dolgov e1a6a54c65 Java: Fixed handling of complex constant expressions in parametrized duplicates matching (IDEA-179924) 2017-10-09 15:30:42 +03:00
Tagir Valeev 08cea712a2 MoveFieldAssignmentToInitializerInspection: allow unknown methods
As this is intention-like part of inspection (no warning), we can allow it even if we are not sure that semantics will be preserved. See comments in IDEA-177602
2017-10-09 16:38:56 +07:00
Tagir Valeev 59526abd92 ControlFlowAnalyzer: pop result of resource expression (Java 9)
If it's not popped, it causes misbalanced stack which may lead to exceptions/strange behavior in data flow analysis.
2017-10-09 15:59:45 +07:00
Tagir Valeev 319d4c205a ChangeToAppendUtil: do not add useless .append("")
Partially fixes IDEA-180178 String concatenation as argument to 'StringBuilder.append()' call should be smarter
2017-10-09 12:12:34 +07:00