Commit Graph

49 Commits

Author SHA1 Message Date
Alexandr Suhinin
d75d619ab9 [extract method] IDEA-251837 use type element to annotate method nullability
[extract method] IDEA-251837 fix texts

GitOrigin-RevId: 37da2e7e8f83a4d85a87c644788a66ce6ea1e05f
2024-01-12 16:42:18 +00:00
Alexandr Suhinin
656b22fd2d [extract method] IDEA-269072 IDEA-188743: reuse 'declare var type' option from 'introduce variable' refactoring
GitOrigin-RevId: 7a8f7a9eba3c7277da7b54e30a03afbbf771f84e
2023-04-21 10:58:34 +00:00
Alexandr Suhinin
1d2c163976 Revert "[extract method] IDEA-269072 IDEA-188743: add option to declare extracted variable as 'var'"
This reverts commit 27b857ab3be3a76bc80417338ac34e691c64ebca.

GitOrigin-RevId: ba9ba9b3846f9dc56c3184f8e5a1ff7a59e1b072
2023-04-21 10:58:30 +00:00
Alexandr Suhinin
f0f3a59d2a [extract method] IDEA-269072 IDEA-188743: add option to declare extracted variable as 'var'
avoid unnecessary change in type element

GitOrigin-RevId: 27b857ab3be3a76bc80417338ac34e691c64ebca
2023-04-19 12:03:23 +00:00
Alexandr Suhinin
6b3d57627c [extract method] IDEA-315449 fix regression: don't suggest bad signatures when parameter number is not changed
GitOrigin-RevId: bde662ca1d248af84a69f60713c6ab6aa836d275
2023-04-14 16:02:22 +00:00
Alexandr Suhinin
f2ff1ff151 [extract method] IDEA-318013: check explicit parent of identifier instead of search
GitOrigin-RevId: d632f6dfffdbfe8912882f30c9bd203e95362a54
2023-04-14 09:46:34 +00:00
Alexandr Suhinin
23ff859664 [extract method] IDEA-317499: infer type arguments for class usage parameters ('this')
GitOrigin-RevId: 7e1b558415ac7a7d381287e99bf54ce87eeef6cb
2023-04-07 13:13:30 +00:00
Alexandr Suhinin
26bae9e549 [extract method] IDEA-317497: search static context until target class only
GitOrigin-RevId: 1e5c8e3319a9a45506e0785d4e7912d71f0233c6
2023-04-07 13:13:27 +00:00
Alexandr Suhinin
41a158d131 IDEA-316766: fold array accesses after duplicate analysis
GitOrigin-RevId: f839cc3b2ab3443ca7a95a8e8f116e72b8b943f7
2023-04-05 10:50:08 +00:00
Alexandr Suhinin
ca161902dc [extract method] IDEA-316471: enable when there is no parent code block (class context)
GitOrigin-RevId: b7a37f10cc2249b640e086c28102187578ae9971
2023-03-29 15:13:37 +00:00
Alexandr Suhinin
b5b3ceda3d [extract method] IDEA-315737: enable extract method on virtual expressions
GitOrigin-RevId: a6ca3dea5d3ab7ec8237c21a06e366e3e5c68a89
2023-03-20 17:18:51 +00:00
Alexandr Suhinin
f7bef79b1b [extract method] IDEA-315225: pass all type parameters in static methods
GitOrigin-RevId: d4bc466d3df5935404485ab95635894acb9aa448
2023-03-17 13:19:56 +00:00
Alexandr Suhinin
a580c212c5 [extract method] IDEA-315575: test extract to interface
GitOrigin-RevId: b6a0879ba137c4a375c2b3258d7afc9217d4d153
2023-03-17 10:21:07 +00:00
Alexandr Suhinin
72af44b14d [extract method] IDEA-313664: allow 'make static' for methods inside inner classes if language level supports this
GitOrigin-RevId: 3eba22a8685ecb6905a867ff68b9f96f7438140d
2023-03-02 09:12:52 +00:00
Alexandr Suhinin
7a80c0d0ed [extract method] IDEA-313673: don't suggest to make method static if there is a non-static class usage
GitOrigin-RevId: 5b2c6e7a16b730c1fc563b295509e1439b03fc97
2023-03-01 18:25:19 +00:00
Alexandr Suhinin
6ed0762529 [extract method with object] fix: check class conflicts inside nested classes
GitOrigin-RevId: 6648c003ae7030c371b83fd68550e81ad1debdf9
2023-02-27 13:03:57 +00:00
Alexandr Suhinin
990b365dd5 [extract duplicates] IDEA-285135: make main method static if duplicates are in static context
GitOrigin-RevId: 238b34892819401c23a6853f81e5664779e00136
2023-02-16 09:34:17 +00:00
Alexandr Suhinin
9ac124a247 [extract method with object] show error when variables can not be extracted
GitOrigin-RevId: 3be26214e06d11a2ce42ff5ddb89be146d338d47
2023-01-30 21:35:36 +00:00
Alexandr Suhinin
8a3a0b1d0b [extract method with object] add tests
GitOrigin-RevId: 0e2d72f613e0b8d1f396bd3a28ca32dd834893c7
2023-01-30 21:35:35 +00:00
Bas Leijdekkers
3c556d8fe0 Java: ignore "as" and "to" prefixes to generate better variable names (IJP-1469)
GitOrigin-RevId: 12cde9892bece40321b4655e7d32b75bd43748e8
2023-01-26 00:04:15 +00:00
Alexandr Suhinin
bf8d0d520b [extract method] IDEA-306846 CR-100378: test qualified field usage
GitOrigin-RevId: 357b69f3e94cb1d2cda2bead8d749b1de7df6a4d
2022-12-28 10:54:24 +00:00
Alexandr Suhinin
e3d89760cb [extract method] IDEA-306846: don't miss member usages after this expression
GitOrigin-RevId: 12043137a28a9de984f2065c7cdca3b049e10a87
2022-12-01 13:46:36 +00:00
Alexandr Suhinin
214599080e [extract duplicates] IDEA-298940: check top level expression nodes to be equal
GitOrigin-RevId: 5f6d408132c2e835434f2b19572e8e1e74fd572d
2022-11-23 12:39:14 +00:00
Alexandr Suhinin
bb4b66ff8e IDEA-293965 [extract method]: suggest change signature always when possible
GitOrigin-RevId: d64f60521297e7e45907e729fe475342afc40cb5
2022-11-21 12:35:19 +00:00
Alexandr Suhinin
d5593b65d0 IDEA-292159 [extract method]: consider parameter folding when replace exact duplicates
GitOrigin-RevId: 4b218bcd4269cf907c22ee67c1da3b410d6f6e43
2022-11-11 11:33:37 +00:00
Alexandr Suhinin
c273ad1c22 IDEA-293965 [extract method]: don't suggest change signature if there are exact duplicates
GitOrigin-RevId: aa4f6990105f607a3edc0a62bed0655ca1f30acd
2022-11-11 11:33:35 +00:00
Alexandr Suhinin
73f35ed28c IDEA-274123 [extract method]: don't suggest too abstract change signatures
GitOrigin-RevId: 4c59710e2304288ad4465a92ec36bff633bd661e
2022-11-10 01:05:51 +00:00
Alexandr Suhinin
b41164371c [java extract method] make method static by default
GitOrigin-RevId: 3cac9f65131e216cc2dd43fe58bf0cccbcb69839
2022-04-26 04:59:44 +00:00
Alexandr Suhinin
a8f79fd185 IDEA-283316 [extract method] fix: inplace template should only rename inserted call
GitOrigin-RevId: f6b2f583deb1726da8ac5672d94f55496c586ba0
2022-02-07 16:34:19 +00:00
Alexandr Suhinin
78900e11cd [extract duplicates] test: check when duplicates or change signature is declined
GitOrigin-RevId: 04d1cbdcac5721fca2817ecb4e5d20c6ebba191e
2022-02-07 13:25:43 +00:00
Alexandr Suhinin
7bce69f60f [extract method] fix: don't declare variable twice
GitOrigin-RevId: a7b8bcccb1e4bf4fb5ea35975f12767dae882813
2021-12-13 16:56:24 +00:00
Alexandr Suhinin
bc709cf5e1 [extract duplicates] CR-17069: add test
GitOrigin-RevId: 7afa3d926701d11f1daddaeab43b300fd02a2a5f
2021-11-16 08:54:37 +00:00
Alexandr Suhinin
9c55edaef5 [extract duplicates] EA-370575 CR-17071: add test
GitOrigin-RevId: 6fe2dc6449642899b9ff8a058dec446b2b779ede
2021-11-15 10:33:23 +00:00
Alexandr Suhinin
e51e5a8919 [extract duplicates] fix: compare diamond types properly
GitOrigin-RevId: 59c01e8bb14142b2c85a573a1fb0c1c8ebd67a99
2021-11-15 10:33:22 +00:00
Alexandr Suhinin
1210f80627 [extract duplicates] fix: don't suggest change signature for expressions with local refs
GitOrigin-RevId: 58b7c2debe3960bbe2c64a1cbc521a8ebd872a1a
2021-11-12 16:32:44 +00:00
Alexandr Suhinin
5371a9a6f6 [extract duplicates] IDEA-278213: don't distinguish references to same local members
GitOrigin-RevId: 4a9f84d48d5fea93696262df333f6964c89cf757
2021-11-12 16:32:43 +00:00
Alexandr Suhinin
94f3aff222 [extract duplicates] IDEA-262587: don't skip duplicates with local assignments
GitOrigin-RevId: f0385f26151e310bb070de1ad07c637b14ef3354
2021-10-26 09:17:18 +00:00
Alexandr Suhinin
c3afc8b902 [extract method] IDEA-278872: fix missed return variable
GitOrigin-RevId: 55ffed6010a531c34dfa18e22ad5b82ced9599ba
2021-10-14 09:49:26 +00:00
Alexandr Suhinin
5428a6afbf [extract method] CR-12557 fix: don't search duplicates inside inserted expression
GitOrigin-RevId: c5e2e61abf625fe9b7f17fe4bad7e1060e703274
2021-10-14 08:49:09 +00:00
Alexandr Suhinin
fae79f2222 IDEA-275892 [extract method]: align expression statements inside enhanced switch
GitOrigin-RevId: d2908c8bd460b4488f2c2a7c86c8f80899e2667c
2021-08-18 10:36:23 +00:00
Alexandr Suhinin
3d9770213b IDEA-275893 [extract method]: align selection for switch statement rules
GitOrigin-RevId: 00c58a19d98bdc99b95cd228b1cc2fa746e9d301
2021-08-18 10:36:21 +00:00
Alexandr Suhinin
27a128ba6b IDEA-275529 extract method: support yield statement
GitOrigin-RevId: 7b277cc420b34693ad3791e80c128328ef671fe2
2021-08-18 09:51:50 +00:00
Alexandr Suhinin
31c5102ca1 [extract duplicates] fix: ignore overlapped duplicates
GitOrigin-RevId: d5f3a1f737ec3a4b362a5abc04d63f48f4303496
2021-08-11 16:54:23 +00:00
Alexandr Suhinin
d854449386 IDEA-275808 [extract method]: don't search changes in duplicates under the inferred parameters
GitOrigin-RevId: 8526a6ed4cbf06586fa9daa96be230c4cec13682
2021-08-11 16:54:18 +00:00
Alexandr Suhinin
b8c5f4a2c8 IDEA-275318 [extract method] fix: use RangeMarker instead of SmartPointers
SmartPointers are too fragile and can be invalidated by live template

GitOrigin-RevId: 0deac2e5e94eb067da7a822ca91126b47e0f941c
2021-08-11 11:10:45 +00:00
Alexandr Suhinin
3f8e6aa3dd IJ-CR-12238 [extract duplicates] fix: keep generated parameter names in ascending order
GitOrigin-RevId: c8ad6fca0bcc19ee8fad935e804de8bafe637f5a
2021-07-26 09:36:42 +00:00
Alexandr Suhinin
c830e27b4c [extract duplicates]: sort parameters corresponding to expression order
GitOrigin-RevId: 968b0105c6dcccf8de5dbb780d78fefba1193d7a
2021-07-23 12:16:29 +00:00
Alexandr Suhinin
4006cf3f70 [extract duplicates]: enable new extract duplicates in tests
GitOrigin-RevId: 4565d1a6939b489e5261c07fa86fb10ed30561f5
2021-07-23 12:16:26 +00:00
Alexandr Suhinin
820529b67a [extract duplicates]: copy existing tests
GitOrigin-RevId: 0cf0aa8d5875e2bc52dfaa96c1259ccb314bbd96
2021-07-23 12:16:23 +00:00