[extract duplicates] IDEA-262587: don't skip duplicates with local assignments

GitOrigin-RevId: f0385f26151e310bb070de1ad07c637b14ef3354

java/java-impl/src/com/intellij/refactoring/extractMethod/newImpl/JavaDuplicatesFinder.kt

@@ -128,7 +128,6 @@ class JavaDuplicatesFinder(pattern: List<PsiElement>, private val predefinedChan
     return when {
       pattern !is PsiExpression || candidate !is PsiExpression -> false
       pattern.parent is PsiExpressionStatement -> false
-      pattern is PsiReferenceExpression && pattern.parent?.parent is PsiExpressionStatement -> false
       pattern is PsiReferenceExpression && pattern.resolve() is PsiMethod && candidate is PsiReferenceExpression -> pattern.resolve() == candidate.resolve()
       else -> pattern.type.isAssignableFrom(candidate.type)
     }

java/java-tests/testData/refactoring/extractMethodAndDuplicatesInplace/LocalAssignmentDuplicates.java

@@ -0,0 +1,16 @@
+public class Sample2 {
+
+    void test1(){
+        <selection>int a = 1;
+        int b = 2;
+        a = 42;
+        System.out.println(a);</selection>
+    }
+
+    void test2(){
+        int x = 1;
+        int y = 2;
+        x = 42;
+        System.out.println(x);
+    }
+}

java/java-tests/testData/refactoring/extractMethodAndDuplicatesInplace/LocalAssignmentDuplicates_after.java

@@ -0,0 +1,17 @@
+public class Sample2 {
+
+    void test1(){
+        extracted();
+    }
+
+    private void extracted() {
+        int a = 1;
+        int b = 2;
+        a = 42;
+        System.out.println(a);
+    }
+
+    void test2(){
+        extracted();
+    }
+}

java/java-tests/testData/refactoring/extractMethodAndDuplicatesInplace/WrongLocalAssignmentDuplicates.java

@@ -0,0 +1,16 @@
+public class Sample2 {
+
+    void test1(){
+        <selection>int a = 1;
+        int b = 2;
+        a = 42;
+        System.out.println(a);</selection>
+    }
+
+    void test2(){
+        int x = 1;
+        int y = 2;
+        y = 42;
+        System.out.println(x);
+    }
+}

java/java-tests/testData/refactoring/extractMethodAndDuplicatesInplace/WrongLocalAssignmentDuplicates_after.java

@@ -0,0 +1,20 @@
+public class Sample2 {
+
+    void test1(){
+        extracted();
+    }
+
+    private void extracted() {
+        int a = 1;
+        int b = 2;
+        a = 42;
+        System.out.println(a);
+    }
+
+    void test2(){
+        int x = 1;
+        int y = 2;
+        y = 42;
+        System.out.println(x);
+    }
+}

java/java-tests/testSrc/com/intellij/java/refactoring/ExtractMethodAndDuplicatesInplaceTest.kt

@@ -162,6 +162,14 @@ class ExtractMethodAndDuplicatesInplaceTest: LightJavaCodeInsightTestCase() {
     doTest()
   }
 
+  fun testLocalAssignmentDuplicates(){
+    doTest();
+  }
+
+  fun testWrongLocalAssignmentDuplicates(){
+    doTest();
+  }
+
   fun testRefactoringListener(){
     templateTest {
       configureByFile("$BASE_PATH/${getTestName(false)}.java")