Lots of code returns `null` without any reason. This ill pattern covers errors effectively making it impossible to find the root cause of any problem.
We replace `null` with `Result` to log and report errors.
Merge-request: IJ-MR-139850
Merged-by: Ilya Kazakevich <ilya.kazakevich@jetbrains.com>
GitOrigin-RevId: 7cbb173f672a44a98f24e89e247428ab6e8ca01d
1. Delete `intellij.python.community.impl.xml` (move content to `PythonCore` plugin). It is necessary to fix incorrect dependencies: `PythonCore`, `Pythonid` include the same module.
2. Fixed dependencies: if some plugin/module needs Python core functionality, then it should depend on `PythonCore`.
Co-authored-by: Vladimir Koshelev <Vladimir.Koshelev@jetbrains.com>
Merge-request: IJ-MR-136158
Merged-by: Egor Eliseev <Egor.Eliseev@jetbrains.com>
GitOrigin-RevId: ce9ed4c17f601ee1ca2b6cf608f4e30fdac1d879
Since the debug toolbar is showing on the left, edit the GotIt tooltips positions to not intersect with tool window stripes.
GitOrigin-RevId: a801c231e87728ae7bf16edfb8135660ef574266
Previously we have enabled the navigation bar to make the actions of the IDE header visible, but in the New UI it makes no sense. So, we have to enable the Main Toolbar now.
GitOrigin-RevId: cc29207ecc86dd56280556b9a3b43df240acb53f
It would be better to get rid of using mutable lesson properties and store mutable lesson state inside the lesson context or something with a clear life cycle. But such a solution requires more work.
GitOrigin-RevId: 1ab2b16a9af2ecc9713f2b77501c68830cb61f33
Layout:
JPS modules
`intellij.python.community`
`intellij.python.community.impl`
`intellij.python.parser`
`intellij.python.psi`
`intellij.python.psi.impl`
`intellij.python.ast`
use package `com.jetbrains.python`
and go to `intellij.python.community.impl` v2 module
JPS module
`intellij.python`
uses package `com.intellij.python.pro`
and goes to `intellij.python/pro` v2 module
Both v2 modules (along with lots of others) come with
`PythonId` (prof) or `PythonCore` (community) plugins
DS bundles `intellij.python.community.impl`
Idea and other Mini IDEs get `PythonCore` or `PythonId` plugin that bundle modules for Idea and mini IDEs
GitOrigin-RevId: 98f418c52d90d51b9adf3250c561f2c36c767e2d
Found that `com.intellij.AbstractBundle.getMessage` applies the formatting to the parameters passed as a `Number`. For example, it translates 1032 int to "1,032" string. And then `toInt` method fails to parse it.
Better to use String value as ID for callbacks to avoid this problem.
GitOrigin-RevId: 95a667a35f6107ec71df0da26892541d1d964b98
See KT-36770 in particular.
Note: beginning from Kotlin 1.6, we control nullability of type parameter-based
types more strictly. For example, it's not allowed to pass something of type 'T'
when '@NotNull T' or 'T : Any' is required. It's correct both for K1 & K2.
(cherry picked from commit a2f95c85d2673ff4688cd38aeacb5030df6000a8)
IJ-MR-99516
GitOrigin-RevId: d91601956a53489f29bc72b32e4810122ede0b1c
This lesson is designed to show run configurations feature, so running the current file should take no effect.
IJ-CR-98349
GitOrigin-RevId: 3a5b084488e564c15919e7ecd8e9f4e91e2ac0ca