IDEA-300739 Remove obsolete declarations of tips for lessons

GitOrigin-RevId: 23f0dc181089c24280e88702da46228b3777750f
2026-09-27 10:03:11 +07:00 · 2022-09-01 15:42:24 +00:00
parent 26265ef6ff
commit 5ae19d4044
40 changed files with 1 additions and 76 deletions
@@ -111,8 +111,6 @@ open class JavaBasicCompletionLesson : KLesson("Basic completion", LessonsBundle

  private fun TaskTestContext.invokeCompletion() = invokeActionViaShortcut("CTRL SPACE")

-  override val suitableTips = listOf("CodeCompletion")
-
  override val helpLinks: Map<String, String> get() = mapOf(
    Pair(LessonsBundle.message("basic.completion.help.code.completion"),
         LessonUtil.getHelpLink("auto-completing-code.html#basic_completion")),
@@ -72,8 +72,6 @@ class JavaSmartTypeCompletionLesson : KLesson("Smart type completion", LessonsBu
    }
  }

-  override val suitableTips = listOf("SmartTypeCompletion", "SmartTypeAfterNew", "SecondSmartCompletionToar")
-
  override val helpLinks: Map<String, String> get() = mapOf(
    Pair(LessonsBundle.message("help.code.completion"),
         LessonUtil.getHelpLink("auto-completing-code.html")),
@@ -88,8 +88,6 @@ class JavaStatementCompletionLesson
    return trimmedText == "{if(){}}"
  }

-  override val suitableTips = listOf("CompleteStatement", "FinishBySmartEnter")
-
  override val helpLinks: Map<String, String> get() = mapOf(
    Pair(JavaLessonsBundle.message("java.statement.completion.help.link"),
         LessonUtil.getHelpLink("auto-completing-code.html#statements_completion")),
@@ -134,8 +134,6 @@ class JavaInheritanceHierarchyLesson
  private fun TaskContext.findToolWindow() = strong(UIBundle.message("tool.window.name.find"))
  private fun TaskContext.hierarchyToolWindow() = strong(UIBundle.message("tool.window.name.hierarchy"))

-  override val suitableTips = listOf("HierarchyBrowser")
-
  override val helpLinks: Map<String, String> get() = mapOf(
    Pair(JavaLessonsBundle.message("java.inheritance.hierarchy.help.link"),
         LessonUtil.getHelpLink("viewing-structure-and-hierarchy-of-the-source-code.html")),
@@ -66,8 +66,6 @@ class JavaExtractMethodCocktailSortLesson
      restoreRefactoringOptionsInformer()
    }

-  override val suitableTips = listOf("ExtractMethod")
-
  override val helpLinks: Map<String, String> get() = mapOf(
    Pair(LessonsBundle.message("extract.method.help.link"),
         LessonUtil.getHelpLink("extract-method.html")),
@@ -137,8 +137,6 @@ class JavaRenameLesson
    return newName.toString()
  }

-  override val suitableTips = listOf("Rename")
-
  override val helpLinks: Map<String, String> get() = mapOf(
    Pair(LessonsBundle.message("rename.help.link"),
         LessonUtil.getHelpLink("rename-refactorings.html")),
@@ -411,8 +411,6 @@ class GitAnnotateLesson : GitLesson("Git.Annotate", GitLessonsBundle.message("gi
    }
  }

-  override val suitableTips = listOf("AnnotationsAndDiffs")
-
  override val helpLinks: Map<String, String> get() = mapOf(
    Pair(GitLessonsBundle.message("git.annotate.help.link"),
         LessonUtil.getHelpLink("investigate-changes.html#annotate_blame")),
@@ -349,8 +349,6 @@ class GitCommitLesson : GitLesson("Git.Commit", GitLessonsBundle.message("git.co
    }
  }

-  override val suitableTips = listOf("partial_git_commit")
-
  override val helpLinks: Map<String, String>
    get() = mapOf(
      Pair(GitLessonsBundle.message("git.commit.help.link"),
@@ -324,8 +324,6 @@ class GitQuickStartLesson : GitLesson("Git.QuickStart", GitLessonsBundle.message
    backupSearchEverywhereLocation = null
  }

-  override val suitableTips = listOf("VCS_general")
-
  override val helpLinks: Map<String, String> get() = mapOf(
    Pair(GitLessonsBundle.message("git.quick.start.help.link"),
         LessonUtil.getHelpLink("set-up-a-git-repository.html")),
@@ -43,6 +43,7 @@ abstract class Lesson(@NonNls val id: String, @Nls val name: String) {
  open val helpLinks: Map<String, String> get() = emptyMap()

  /** IDs of TipAndTrick suggestions in that this lesson can be promoted */
+  @Deprecated("Specify tips in LearningCourse.getLessonIdToTipsMap()")
  open val suitableTips: List<String> = emptyList()

  open val testScriptProperties: TaskTestContext.TestScriptProperties = TaskTestContext.TestScriptProperties()
@@ -69,8 +69,6 @@ class CommentUncommentLesson(private val sample: LessonSample, private val block
    }
  }

-  override val suitableTips = listOf("CommentCode")
-
  override val helpLinks: Map<String, String> get() = mapOf(
    Pair(message("help.lines.of.code"),
         LessonUtil.getHelpLink("working-with-source-code.html#editor_lines_code_blocks")),
@@ -31,8 +31,6 @@ abstract class CompletionWithTabLesson(private val proposal: String) :
      }
    }

-  override val suitableTips = listOf("TabInLookups")
-
  override val helpLinks: Map<String, String> get() = mapOf(
    Pair(LessonsBundle.message("help.code.completion"),
         LessonUtil.getHelpLink("auto-completing-code.html")),
@@ -119,8 +119,6 @@ abstract class ContextActionsLesson : KLesson("context.actions", LessonsBundle.m
    }
  }

-  override val suitableTips = listOf("ContextActions")
-
  override val helpLinks: Map<String, String> get() = mapOf(
    Pair(LessonsBundle.message("context.actions.help.intention.actions"),
         LessonUtil.getHelpLink("intention-actions.html")),
@@ -62,8 +62,6 @@ class DuplicateLesson(private val sample: LessonSample) :
    return start.column == end.column && abs(start.line - end.line) >= 2
  }

-  override val suitableTips = listOf("CtrlD", "DeleteLine")
-
  override val helpLinks: Map<String, String> get() = mapOf(
    Pair(LessonsBundle.message("help.lines.of.code"),
         LessonUtil.getHelpLink("working-with-source-code.html#editor_lines_code_blocks")),
@@ -128,8 +128,6 @@ class GotoActionLesson(private val sample: LessonSample, private val firstLesson

  private fun isLineNumbersShown() = EditorSettingsExternalizable.getInstance().isLineNumbersShown

-  override val suitableTips = listOf("find_action", "GoToAction")
-
  override val helpLinks: Map<String, String> get() = mapOf(
    Pair(LessonsBundle.message("help.search.everywhere"),
         LessonUtil.getHelpLink("searching-everywhere.html")),
@@ -37,8 +37,6 @@ class MoveLesson(private val caretText: String, private val sample: LessonSample
      }
    }

-  override val suitableTips = listOf("MoveUpDown")
-
  override val helpLinks: Map<String, String> get() = mapOf(
    Pair(LessonsBundle.message("help.lines.of.code"),
         LessonUtil.getHelpLink("working-with-source-code.html#editor_lines_code_blocks")),
@@ -98,8 +98,6 @@ abstract class NewSelectLesson : KLesson("Select", LessonsBundle.message("select
    return selection.toString().trim() == needSelection.trim()
  }

-  override val suitableTips = listOf("smart_selection", "CtrlW")
-
  override val helpLinks: Map<String, String> get() = mapOf(
    Pair(LessonsBundle.message("selection.help.select.code.constructs"),
         LessonUtil.getHelpLink("working-with-source-code.html#editor_code_selection")),
@@ -33,5 +33,4 @@ class SelectLesson(private val sample: LessonSample) : KLesson("Select", Lessons
      }
    }

-  override val suitableTips = listOf("CtrlW")
 }
@@ -102,8 +102,6 @@ abstract class SurroundAndUnwrapLesson
    }
  }

-  override val suitableTips = listOf("SurroundWith")
-
  override val helpLinks: Map<String, String> = mapOf(
    Pair(LessonsBundle.message("surround.and.unwrap.help.surround.code.fragments"),
         LessonUtil.getHelpLink("surrounding-blocks-of-code-with-language-constructs.html")),
@@ -69,8 +69,6 @@ class CodeFormatLesson(private val sample: LessonSample, private val optimizeImp
    }
  }

-  override val suitableTips = listOf("LayoutCode")
-
  override val helpLinks: Map<String, String> get() = mapOf(
    Pair(LessonsBundle.message("code.format.help.link"),
         LessonUtil.getHelpLink("configuring-code-style.html")),
@@ -113,8 +113,6 @@ abstract class EditorCodingAssistanceLesson(private val sample: LessonSample) :
    return caretOffset != sequence.length && sequence[caretOffset].isLetter()
  }

-  override val suitableTips = listOf("HighlightUsagesInFile", "NextPrevError", "NavigateBetweenErrors")
-
  override val helpLinks: Map<String, String> get() = mapOf(
    Pair(LessonsBundle.message("editor.coding.assistance.help.link"),
         LessonUtil.getHelpLink("working-with-source-code.html")),
@@ -382,8 +382,6 @@ class LocalHistoryLesson : KLesson("CodeAssistance.LocalHistory", LessonsBundle.
    }
  }

-  override val suitableTips = listOf("local_history")
-
  override val helpLinks: Map<String, String> get() = mapOf(
    Pair(LessonsBundle.message("local.history.help.link"),
         LessonUtil.getHelpLink("local-history.html")),
@@ -44,8 +44,6 @@ class ParameterInfoLesson(private val sample: LessonSample) :
    return partOfSequence.matches(parametersRegex)
  }

-  override val suitableTips = listOf("ParameterInfo")
-
  override val helpLinks: Map<String, String> get() = mapOf(
    Pair(LessonsBundle.message("parameter.info.help.link"),
         LessonUtil.getHelpLink("viewing-reference-information.html#view-parameter-info")),
@@ -52,8 +52,6 @@ class QuickPopupsLesson(private val sample: LessonSample) :
    return activeDocComponent == null || !activeDocComponent.isShowing
  }

-  override val suitableTips = listOf("CtrlShiftIForLookup", "CtrlShiftI", "QuickJavaDoc")
-
  override val helpLinks: Map<String, String> get() = mapOf(
    Pair(LessonsBundle.message("quick.popups.help.link"),
         LessonUtil.getHelpLink("using-code-editor.html#quick_popups")),
@@ -98,8 +98,6 @@ abstract class BasicCompletionLessonBase : KLesson("Basic completion", LessonsBu
  private fun isTheFirstVariant(it: JList<*>) =
    it.model.size >= 1 && it.model.getElementAt(0).isToStringContains(item1Completion)

-  override val suitableTips = listOf("CodeCompletion")
-
  override val helpLinks: Map<String, String> get() = mapOf(
    Pair(LessonsBundle.message("basic.completion.help.code.completion"),
         LessonUtil.getHelpLink("auto-completing-code.html#basic_completion")),
@@ -50,8 +50,6 @@ abstract class PostfixCompletionLesson : KLesson("Postfix completion", LessonsBu
    }
  }

-  override val suitableTips = listOf("PostfixCompletion")
-
  override val helpLinks: Map<String, String> get() = mapOf(
    Pair(LessonsBundle.message("postfix.completion.help.link"),
         LessonUtil.getHelpLink("auto-completing-code.html#postfix_completion")),
@@ -146,8 +146,6 @@ abstract class DeclarationAndUsagesLesson

  private data class MyPosition(val file: PsiFile, val offset: Int)

-  override val suitableTips = listOf("GoToDeclaration", "ShowUsages")
-
  override val helpLinks: Map<String, String> get() = mapOf(
    Pair(LessonsBundle.message("declaration.and.usages.help.link"),
         LessonUtil.getHelpLink("navigating-through-the-source-code.html#go_to_declaration")),
@@ -68,8 +68,6 @@ abstract class FileStructureLesson
    return false
  }

-  override val suitableTips = listOf("FileStructurePopup")
-
  override val helpLinks: Map<String, String> get() = mapOf(
    Pair(LessonsBundle.message("file.structure.help.link"),
         LessonUtil.getHelpLink("viewing-structure-of-a-source-file.html")),
@@ -225,8 +225,6 @@ class FindInFilesLesson(override val sampleFilePath: String)

  override val testScriptProperties = TaskTestContext.TestScriptProperties(10)

-  override val suitableTips = listOf("FindReplaceToggle", "FindInPath")
-
  override val helpLinks: Map<String, String> get() = mapOf(
    Pair(LessonsBundle.message("find.in.files.help.link"),
         LessonUtil.getHelpLink("finding-and-replacing-text-in-project.html")),
@@ -227,8 +227,6 @@ abstract class RecentFilesLesson : KLesson("Recent Files and Locations", Lessons
  override val testScriptProperties: TaskTestContext.TestScriptProperties
    get() = TaskTestContext.TestScriptProperties(duration = 20)

-  override val suitableTips = listOf("recent-locations", "RecentFiles")
-
  override val helpLinks: Map<String, String> get() = mapOf(
    Pair(LessonsBundle.message("recent.files.locations.help.link"),
         LessonUtil.getHelpLink("navigating-through-the-source-code.html#recent_locations")),
@@ -160,8 +160,6 @@ abstract class SearchEverywhereLesson : KLesson("Search everywhere", LessonsBund
    return UIUtil.getParentOfType(SearchEverywhereUI::class.java, focusOwner) != null
  }

-  override val suitableTips = listOf("SearchEverywhere", "GoToClass", "search_everywhere_general")
-
  override val helpLinks: Map<String, String> get() = mapOf(
    Pair(LessonsBundle.message("help.search.everywhere"),
         LessonUtil.getHelpLink("searching-everywhere.html")),
@@ -85,8 +85,6 @@ class ExtractMethodCocktailSortLesson(private val sample: LessonSample)
    it.className.contains(ExtractMethodHelper::class.java.simpleName)
  }

-  override val suitableTips = listOf("ExtractMethod")
-
  override val helpLinks: Map<String, String> get() = mapOf(
    Pair(LessonsBundle.message("extract.method.help.link"),
         LessonUtil.getHelpLink("extract-method.html")),
@@ -61,8 +61,6 @@ class ExtractVariableFromBubbleLesson(private val sample: LessonSample)
      restoreRefactoringOptionsInformer()
    }

-  override val suitableTips = listOf("IntroduceVariable")
-
  override val helpLinks: Map<String, String> get() = mapOf(
    Pair(LessonsBundle.message("extract.variable.help.link"),
         LessonUtil.getHelpLink("extract-variable.html")),
@@ -83,8 +83,6 @@ abstract class RefactoringMenuLessonBase(lessonId: String) : KLesson(lessonId, L

  private fun TaskRuntimeContext.hasInplaceRename() = editor.getUserData(InplaceRefactoring.INPLACE_RENAMER) != null

-  override val suitableTips = listOf("RefactorThis")
-
  override val helpLinks: Map<String, String> get() = mapOf(
    Pair(LessonsBundle.message("refactoring.menu.help.link"),
         LessonUtil.getHelpLink("refactoring-source-code.html#refactoring_invoke")),
@@ -482,8 +482,6 @@ abstract class CommonDebugLesson(id: String) : KLesson(id, LessonsBundle.message
    ?: checkDebugIsRunning()
  }

-  override val suitableTips = listOf("BreakpointSpeedmenu", "QuickEvaluateExpression", "EvaluateExpressionInEditor")
-
  override val helpLinks: Map<String, String> get() = mapOf(
    Pair(LessonsBundle.message("debug.workflow.help.link"),
         LessonUtil.getHelpLink("debugging-code.html")),
@@ -145,8 +145,6 @@ abstract class CommonRunConfigurationLesson(id: String) : KLesson(id, LessonsBun
  override val testScriptProperties: TaskTestContext.TestScriptProperties
    get() = TaskTestContext.TestScriptProperties(duration = 20)

-  override val suitableTips = listOf("SelectRunDebugConfiguration")
-
  override val helpLinks: Map<String, String> get() = mapOf(
    Pair(LessonsBundle.message("run.configuration.help.link"),
         LessonUtil.getHelpLink("run-debug-configuration.html")),
@@ -85,5 +85,4 @@ class PythonTabCompletionLesson
    }
  }

-  override val suitableTips = listOf("TabInLookups")
 }
@@ -172,8 +172,6 @@ class PythonInPlaceRefactoringLesson
    return result.toString()
  }

-  override val suitableTips = listOf("InPlaceRefactoring")
-
  override val helpLinks: Map<String, String> get() = mapOf(
    Pair(PythonLessonsBundle.message("python.in.place.refactoring.help.rename.link"),
         LessonUtil.getHelpLink("rename-refactorings.html#inplace_rename")),
@@ -166,8 +166,6 @@ class PythonQuickFixesRefactoringLesson
    }
  }

-  override val suitableTips = listOf("QuickFixRightArrow")
-
  override val helpLinks: Map<String, String> get() = mapOf(
    Pair(PythonLessonsBundle.message("python.quick.fix.refactoring.help.link"),
         LessonUtil.getHelpLink("change-signature.html")),
@@ -172,8 +172,6 @@ class PythonRenameLesson : KLesson("Rename", LessonsBundle.message("rename.lesso
    }
  }

-  override val suitableTips = listOf("Rename")
-
  override val helpLinks: Map<String, String> get() = mapOf(
    Pair(LessonsBundle.message("rename.help.link"),
         LessonUtil.getHelpLink("rename-refactorings.html")),