MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

get rid of placeholder objects in FramesPanel

Browse Source
This commit is contained in:
Eugene Zhuravlev
2010-09-15 15:31:51 +04:00
parent 25cfe8396f
commit fff2e1d2c0
1 changed files with 9 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files
java/debugger/impl/src/com/intellij/debugger/ui/FramesPanel.java
+9 -24
View File
@@ -460,8 +460,7 @@ public class FramesPanel extends UpdatableDebuggerView {
evaluationContext,
tracker,
index++,
stackFrameProxy.equals(contextFrame),
totalFramesCount,
stackFrameProxy.equals(contextFrame),
timestamp,
indexCounter
)
@@ -510,12 +509,12 @@ public class FramesPanel extends UpdatableDebuggerView {
private IndexCounter(int totalSize) {
myData = new int[totalSize];
for (int idx = 0; idx < totalSize; idx++) {
myData[idx] = 1;
myData[idx] = 0;
}
}
public void markHidden(int idx){
myData[idx] = 0;
public void markCalculated(int idx){
myData[idx] = 1;
}
public int getActualIndex(final int index) {
@@ -534,20 +533,17 @@ public class FramesPanel extends UpdatableDebuggerView {
private final MethodsTracker myTracker;
private final int myIndexToInsert;
private final boolean myIsContextFrame;
private final int myTotalFramesCount;
private final long myTimestamp;
private final IndexCounter myCounter;
public AppendFrameCommand(SuspendContextImpl suspendContext, StackFrameProxyImpl frame, EvaluationContextImpl evaluationContext,
MethodsTracker tracker, int indexToInsert, final boolean isContextFrame, final int totalFramesCount,
final long timestamp, IndexCounter counter) {
MethodsTracker tracker, int indexToInsert, final boolean isContextFrame, final long timestamp, IndexCounter counter) {
super(suspendContext);
myFrame = frame;
myEvaluationContext = evaluationContext;
myTracker = tracker;
myIndexToInsert = indexToInsert;
myIsContextFrame = isContextFrame;
myTotalFramesCount = totalFramesCount;
myTimestamp = timestamp;
myCounter = counter;
}
@@ -566,25 +562,14 @@ public class FramesPanel extends UpdatableDebuggerView {
if (model.isEmpty() || myFramesLastUpdateTime < myTimestamp) {
myFramesLastUpdateTime = myTimestamp;
model.clear();
for (int idx = 0; idx < myTotalFramesCount; idx++) {
final String label = "<frame " + idx + ">";
model.addElement(new Object() {
public String toString() {
return label;
}
});
}
}
if (myTimestamp != myFramesLastUpdateTime) {
return; // the command has expired
}
final int actualIndex = myCounter.getActualIndex(myIndexToInsert);
model.removeElementAt(actualIndex); // remove placeholder
boolean shouldHide = !myShowLibraryFrames && !myIsContextFrame && myIndexToInsert != 0 && (descriptor.isSynthetic() || descriptor.isInLibraryContent());
if (shouldHide) {
myCounter.markHidden(myIndexToInsert);
}
else {
final boolean shouldHide = !myShowLibraryFrames && !myIsContextFrame && myIndexToInsert != 0 && (descriptor.isSynthetic() || descriptor.isInLibraryContent());
if (!shouldHide) {
myCounter.markCalculated(myIndexToInsert);
final int actualIndex = myCounter.getActualIndex(myIndexToInsert);
model.insertElementAt(descriptor, actualIndex);
if (myIsContextFrame) {
myFramesList.setSelectedIndex(actualIndex);