MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

getText is expensive

Browse Source
This commit is contained in:
Alexey Kudravtsev
2012-02-27 13:29:14 +04:00
parent be2f43b777
commit fec608ae34
2 changed files with 8 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/groovy/src/org/jetbrains/plugins/groovy/intentions/control/InvertIfIntention.java
+3 -4
View File
@@ -93,10 +93,6 @@ public class InvertIfIntention extends Intention {
return new PsiElementPredicate() {
@Override
public boolean satisfiedBy(PsiElement element) {
if (!"if".equals(element.getText())) {
return false;
}
PsiElement parent = element.getParent();
if (!(parent instanceof GrIfStatement)) {
return false;
@@ -105,6 +101,9 @@ public class InvertIfIntention extends Intention {
if (((GrIfStatement)parent).getCondition() == null) {
return false;
}
if (!"if".equals(element.getText())) {
return false;
}
return true;
}
};
plugins/groovy/src/org/jetbrains/plugins/groovy/intentions/control/SplitIfIntention.java
+5 -11
View File
@@ -64,17 +64,11 @@ public class SplitIfIntention extends Intention {
return new PsiElementPredicate() {
@Override
public boolean satisfiedBy(PsiElement element) {
if ("&&".equals(element.getText()) &&
element.getParent() instanceof GrBinaryExpression &&
((GrBinaryExpression)element.getParent()).getRightOperand() != null &&
element.getParent().getParent() instanceof GrIfStatement &&
((GrIfStatement) element.getParent().getParent()).getElseBranch() == null
) {
return true;
}
return false;
return element.getParent() instanceof GrBinaryExpression &&
((GrBinaryExpression)element.getParent()).getRightOperand() != null &&
element.getParent().getParent() instanceof GrIfStatement &&
((GrIfStatement)element.getParent().getParent()).getElseBranch() == null
&& "&&".equals(element.getText());
}
};
}