MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

[PyCharm Tables] PY-78903 Added a registry key to save preferences between new and old tables #PY-78903 Ready for Merge

Browse Source 
* Added the "python.data.view.allow.save.preferences.community.vs.powerful.data.view" registry key. If it's enabled, then we will remember a user's choice which data viewer they prefer.
* Will show the Slicing editor field in the new data view by default, as users cannot find this slicing field (the "input expression" field)

GitOrigin-RevId: 1c03357451d3dc8a228b06fd4c59210b313e8478
This commit is contained in:
Natalia.Murycheva
2025-09-10 10:48:31 +00:00
committed by intellij-monorepo-bot
parent 483ba28afe
commit feb51851df
2 changed files with 29 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
python/pluginResources/intellij.python.community.impl.xml
+3
View File
@@ -467,6 +467,9 @@
<registryKey defaultValue="false" description="Use legacy system python detection method based on flavors"
restartRequired="false" key="python.use.system.legacy.provider"/>
<registryKey defaultValue="false" description="Save preferences what type of data view will be used: the old data view or the new one."
restartRequired="false" key="python.data.view.allow.save.preferences.community.vs.powerful.data.view"/>
<!-- typing -->
<multiHostInjector implementation="com.jetbrains.python.codeInsight.typing.PyTypingAnnotationInjector"/>
python/src/com/jetbrains/python/debugger/containerview/PyDataViewerPanel.kt
+26 -6
View File
@@ -2,11 +2,13 @@
package com.jetbrains.python.debugger.containerview
import com.intellij.ide.DataManager
import com.intellij.ide.util.PropertiesComponent
import com.intellij.openapi.Disposable
import com.intellij.openapi.actionSystem.CompositeDataProvider
import com.intellij.openapi.actionSystem.DataKey
import com.intellij.openapi.actionSystem.DataProvider
import com.intellij.openapi.project.Project
import com.intellij.openapi.util.registry.Registry
import com.jetbrains.python.debugger.PyDebugValue
import com.jetbrains.python.debugger.PyFrameAccessor
import java.awt.BorderLayout
@@ -24,7 +26,7 @@ class PyDataViewerPanel(
init {
val dataViewerModel = PyDataViewerModel(project, frameAccessor)
var dataViewerPanel = if (isPanelsFromFactoryAvailable()) {
var dataViewerPanel = if (isPanelFromFactory()) {
isPanelFromFactory = true
createPanelFromFactory(dataViewerModel)
}
@@ -52,6 +54,7 @@ class PyDataViewerPanel(
fun switchBetweenCommunityAndFactoriesTables() {
isPanelFromFactory = !isPanelFromFactory
savePreferencesIfNeeded(isPanelFromFactory)
val dataViewerModel = getDataViewerModel()
val debugValue = dataViewerModel.debugValue
@@ -80,10 +83,6 @@ class PyDataViewerPanel(
}
}
private fun isPanelsFromFactoryAvailable(): Boolean {
return PyDataViewPanelFactory.EP_NAME.extensionList.isNotEmpty()
}
private fun createPanelFromFactory(dataViewerModel: PyDataViewerModel): PyDataViewerAbstractPanel {
return PyDataViewPanelFactory.EP_NAME.extensionList.first().createDataViewerPanel(dataViewerModel)
}
@@ -106,7 +105,6 @@ class PyDataViewerPanel(
override fun dispose() {}
companion object {
val PY_DATA_VIEWER_PANEL_KEY: DataKey<PyDataViewerPanel> = DataKey.create<PyDataViewerPanel>("PY_DATA_VIEWER_PANEL_KEY")
fun addDataProvider(component: JComponent, provider: DataProvider) {
@@ -119,5 +117,27 @@ class PyDataViewerPanel(
DataManager.registerDataProvider(component, provider)
}
}
private fun isPanelsFromFactoryAvailable(): Boolean {
return PyDataViewPanelFactory.EP_NAME.extensionList.isNotEmpty()
}
private fun isPanelFromFactory(): Boolean {
if (!isPanelsFromFactoryAvailable()) return false
if (Registry.`is`("python.data.view.allow.save.preferences.community.vs.powerful.data.view", false)) {
return isUsingCommunityPanel()
}
return true
}
private fun savePreferencesIfNeeded(newValue: Boolean): Unit {
if (Registry.`is`("python.data.view.allow.save.preferences.community.vs.powerful.data.view", false)) {
setUsingCommunityPanel(newValue)
}
}
private const val DATA_VIEWER_SHOW_COMMUNITY_PANEL = "py.data.viewer.powerful.table.shown.on.each.data.view.opening"
fun isUsingCommunityPanel(): Boolean = PropertiesComponent.getInstance().getBoolean(DATA_VIEWER_SHOW_COMMUNITY_PANEL, true)
fun setUsingCommunityPanel(value: Boolean): Unit = PropertiesComponent.getInstance().setValue(DATA_VIEWER_SHOW_COMMUNITY_PANEL, value, true)
}
}