IDEA-115660 Fix Spock library in Create test dialog does not work

java/java-impl/src/com/intellij/testIntegration/createTest/CreateTestDialog.java

@@ -232,9 +232,16 @@ public class CreateTestDialog extends DialogWrapper {
   }
 
   private void onLibrarySelected(TestFramework descriptor) {
-    String text = CodeInsightBundle.message("intention.create.test.dialog.library.not.found", descriptor.getName());
-    myFixLibraryLabel.setText(text);
-    myFixLibraryPanel.setVisible(!descriptor.isLibraryAttached(myTargetModule));
+    if (descriptor.isLibraryAttached(myTargetModule)) {
+      myFixLibraryPanel.setVisible(false);
+    }
+    else {
+      myFixLibraryPanel.setVisible(true);
+      String text = CodeInsightBundle.message("intention.create.test.dialog.library.not.found", descriptor.getName());
+      myFixLibraryLabel.setText(text);
+
+      myFixLibraryButton.setVisible(descriptor.getLibraryPath() != null);
+    }
 
     String superClass = descriptor.getDefaultSuperClass();
 

platform/core-api/src/com/intellij/testIntegration/TestFramework.java

@@ -38,7 +38,7 @@ public interface TestFramework {
 
   boolean isLibraryAttached(@NotNull Module module);
 
-  @NotNull
+  @Nullable
   String getLibraryPath();
 
   @Nullable

plugins/groovy/src/org/jetbrains/plugins/groovy/spock/SpockTestFramework.java

@@ -37,15 +37,9 @@ public class SpockTestFramework extends GroovyTestFramework {
     return "Spock";
   }
 
-  @NotNull
   @Override
   public String getLibraryPath() {
-    try {
-      return PathUtil.getJarPathForClass(Class.forName(getMarkerClassFQName()));
-    }
-    catch (ClassNotFoundException e) {
-      throw new RuntimeException(e);
-    }
+    return null;
   }
 
   @Nullable

plugins/groovy/src/org/jetbrains/plugins/groovy/testIntegration/GroovyTestFramework.java

@@ -122,7 +122,6 @@ public class GroovyTestFramework extends JavaTestFramework {
     return JetgroovyIcons.Groovy.Groovy_16x16;
   }
 
-  @NotNull
   @Override
   public String getLibraryPath() {
     return GroovyUtils.getBundledGroovyJar().getAbsolutePath();