MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

[devkit] ComponentNotRegisteredInspection: performance

Browse Source
This commit is contained in:
Yann Cébron
2017-07-01 17:28:11 +02:00
parent c509d84a27
commit fd9350a030
1 changed files with 12 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/devkit/src/inspections/ComponentNotRegisteredInspection.java
+12 -14
View File
@@ -85,31 +85,23 @@ public class ComponentNotRegisteredInspection extends DevKitInspectionBase {
@Nullable
public ProblemDescriptor[] checkClass(@NotNull PsiClass checkedClass, @NotNull InspectionManager manager, boolean isOnTheFly) {
PsiFile psiFile = checkedClass.getContainingFile();
PsiIdentifier classIdentifier = checkedClass.getNameIdentifier();
if (checkedClass.getQualifiedName() != null &&
classIdentifier != null &&
psiFile != null &&
psiFile.getVirtualFile() != null &&
if (classIdentifier != null &&
checkedClass.getQualifiedName() != null &&
checkedClass.getContainingFile().getVirtualFile() != null &&
!checkedClass.hasModifierProperty(PsiModifier.ABSTRACT) &&
!checkedClass.isEnum()) {
if (PsiUtil.isInnerClass(checkedClass)) {
// don't check inner classes (make this an option?)
return null;
}
!checkedClass.isEnum() &&
!PsiUtil.isInnerClass(checkedClass)) {
GlobalSearchScope scope = checkedClass.getResolveScope();
if (CHECK_ACTIONS) {
if (shouldCheckActionClass(checkedClass)) {
PsiClass actionClass = JavaPsiFacade.getInstance(manager.getProject()).findClass(AnAction.class.getName(), scope);
if (actionClass == null) {
// stop if action class cannot be found (non-devkit module/project)
return null;
}
if (checkedClass.isInheritor(actionClass, true)) {
if (IGNORE_NON_PUBLIC && !checkedClass.hasModifierProperty(PsiModifier.PUBLIC)) {
return null;
}
if (!isActionRegistered(checkedClass) && canFix(checkedClass)) {
LocalQuickFix fix = new RegisterActionFix(org.jetbrains.idea.devkit.util.PsiUtil.createPointer(checkedClass));
ProblemDescriptor problem =
@@ -169,6 +161,12 @@ public class ComponentNotRegisteredInspection extends DevKitInspectionBase {
return ContainerUtil.getFirstItem(types);
}
private boolean shouldCheckActionClass(PsiClass psiClass) {
if (!CHECK_ACTIONS) return false;
if (IGNORE_NON_PUBLIC && !psiClass.hasModifierProperty(PsiModifier.PUBLIC)) return false;
return true;
}
private static boolean isActionRegistered(PsiClass actionClass) {
final PsiClass registrationType = findRegistrationType(actionClass, RegistrationCheckerUtil.RegistrationType.ACTION);
if (registrationType != null) {